From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F15133242D4 for ; Fri, 24 Jul 2026 15:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784908199; cv=none; b=b2H+Tdt6OlyIBjuDobDfM5/oUiLHmmUvFUlXl1pF+y9UMVcjg7OfkqU3vCk7o9xxifkXnnvjDRTpihmtk4ao2wp9KfkrMFKQtnT3qXX/rvuLyFakEAwlmLzqRRLLJ7QzOUqr1qQercxbHQuIRkPRMtpsvhDmT1jVGnqiktVA69w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784908199; c=relaxed/simple; bh=j7B4danz/ZEcE9/NjNIzey4qh7P8tB8Rwlo/mr7Npf4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JR253j+T1Z7C5nG0cjBl0wB8MlyP8RXZcTbnP6pb4KyMzQE8nLkVVwN0GIKuY85f/yMO3SXgYkrPsGs4Mrtvy43WllTRlvme705OngFSsCfZdP2hn53iW8qiyQ9O5s3FqYSMpChWaob7x4F50X0yUykIesZVjHiAEO0f1EgnW6k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dO5+kO2T; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nDyDRIX9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dO5+kO2T"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nDyDRIX9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784908196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XDO5JZJvZtfl6cmues5X36AY0ZaUTn38I+SGeN802WA=; b=dO5+kO2TjtUPMJc4CK2wYewZOICeYT+2bnRan6rv1/LltO1xp42Wgy0Fw7Ed6Ec/WfgPPc zUZUOl/oVtOTqsSIGA4nTRoNTZjPRL8naX/rw1aAl+oGCF3PHgoXt/vVws1wKkLsZv/m/S qVGmj/W4t+EHtL/eEhM/M6RdPth6Q2Q= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-222-HEjjA6CLNcejQFon9iN1dQ-1; Fri, 24 Jul 2026 11:49:53 -0400 X-MC-Unique: HEjjA6CLNcejQFon9iN1dQ-1 X-Mimecast-MFC-AGG-ID: HEjjA6CLNcejQFon9iN1dQ_1784908193 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-520a00c7a03so11947381cf.1 for ; Fri, 24 Jul 2026 08:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784908193; x=1785512993; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=XDO5JZJvZtfl6cmues5X36AY0ZaUTn38I+SGeN802WA=; b=nDyDRIX90wUsAuIiuDMJXBqmmk1s/XaGU5oskdv2/wmj3W7vrjsFa5/s0yqdnoobjo BGTG7Uy6jlegOFngAXufqPGHxCRgCo0WqO3Sc4E9BvlMqYJBqTl/pzYdhduVR28NCs2j NibmTygzTm8clyT3LMBLVtFXHF+0vGeUBNrVQUqX/bTNN6bxrUGgwh605/a9/DKeJ1Lo n0E6fJeUlXNm857dCOKIso2rivZv7MfyAHM9dnalHcRKyyEx3mvjQSz011C+wbgCvdB6 +4okxcNWZug3vDQcQFdl0ByvgeMFI1GzsdJiqARafUOX2yK1AWbvTvowKYQOWdq50yVO OTvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784908193; x=1785512993; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XDO5JZJvZtfl6cmues5X36AY0ZaUTn38I+SGeN802WA=; b=N5RLECioHyedM8mRtJYWM/BOBU8GVsmDw3rPP+XtLJRwACHmF07zGEiXZxEPXCvNWv npTQK3i6HP4hdADj5zGstZmmTh1j3pZC6t7ju+C6n14OLOVNW7d+3Y1kYPGl2aA+WrRo JNhj21VwOwtRUM4KIUrC4FfXVg9t1CMjzQ2oBIDuvIF4Drl7zgMsgCsiEYUjO6q7Q3tw X/T1uVtDjM6vywp/gabYCUkFJyM3CquMXq/JPWH287waB0aPwYDQzxhH0it8fKJKyhbv VhO0myCkwTAl3AJNq3JOr3iSlGhQnhbuSDXyNe2baW5m/IAAT3KNydQM5pohvsX/q+RU k0rA== X-Forwarded-Encrypted: i=1; AHgh+Rr5UmqZ4BFCJWkdzXRrMBHz36j/VYaxmA1CAFhLh/4GQdp7npT1aKJcZIPQsOSaCKh/NK+x0DHyrD6qv3c=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ5XzJLTv6K5jd+vx3nY32Wv7qXNeub8WcqO/aE2coJ4De0sEF tWUCAD8XNdTjYwyD9IsKibwNCAYYRKRPb6MJt+T3Cytp/nv7EbpVtcivR7I8Y/g9AanaLcrJFvQ w3TR4tddIkUB+O6InvShYjKe9CZ2bNMfF5byxrJ2eHBpTl1Z/rVMiISxrU1HnK58PhQ== X-Gm-Gg: AR+sD10ICWS4DPdF8L9Joj7n5zim81q8POQQRZ7w0aMalq+ItsSQ+GRekOg3K7n5A+V gZJ87rLJ86QAl5EM7FJ+NFhKq+EAKJibvLk+BolhiMEm+tt7U7N8X5eyidjpKy5K08mCJ2wOZl2 Ug/+eJ7Wq6BZtP0HCxGGa0tCLcw6WOv5icEbFHe76OQA/aiYlNX9E2bzZVpRspuMf3RwTX+jgcl NFLt6OYtF/0m50TOKodJzUbPz6cf/CuhwsxwlL/fVZz1MsylGg1LEeOKgaozwEA6U749mj85Cs7 PDKAOp0WBj2BJ0WmH8PTM5WvQAbceLyd23zhscvBskVdCYhZoP2vobhs7SdMFTEnKYqU4xdyTU+ UhCK/XeU8/7ntaDJ76UAOrn3iwKaWtDdyjxE= X-Received: by 2002:a05:622a:8c:b0:51a:8c9a:8fb6 with SMTP id d75a77b69052e-5283df6172fmr71861141cf.71.1784908192791; Fri, 24 Jul 2026 08:49:52 -0700 (PDT) X-Received: by 2002:a05:622a:8c:b0:51a:8c9a:8fb6 with SMTP id d75a77b69052e-5283df6172fmr71860711cf.71.1784908192117; Fri, 24 Jul 2026 08:49:52 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-529a27cedccsm2245391cf.4.2026.07.24.08.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 08:49:51 -0700 (PDT) Date: Fri, 24 Jul 2026 11:49:49 -0400 From: Brian Masney To: Sang-Heon Jeon Cc: Julia.Lawall@inria.fr, Michael Turquette , Stephen Boyd , cocci@inria.fr, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/36] clk: remove conditional return with no effect Message-ID: References: <20260723184538.3888637-1-ekffu200098@gmail.com> <20260723184538.3888637-18-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723184538.3888637-18-ekffu200098@gmail.com> User-Agent: Mutt/2.4.0 (2026-06-19) On Fri, Jul 24, 2026 at 03:45:19AM +0900, Sang-Heon Jeon wrote: > Both branches of the check return the same value, so the check has > no effect. Remove it and return the value directly. > > In the lmk04832 driver, the hardware sequence comments are moved > above the final return by hand. > > This is the result of running the Coccinelle script from > scripts/coccinelle/misc/cond_return_no_effect.cocci. > > Signed-off-by: Sang-Heon Jeon Reviewed-by: Brian Masney