The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Matlack <dmatlack@google.com>
To: Josh Hilke <jrhilke@google.com>
Cc: Alex Williamson <alex@shazbot.org>, Shuah Khan <shuah@kernel.org>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	Vipin Sharma <vipinsh@google.com>,
	Alex Williamson <alex.williamson@nvidia.com>
Subject: Re: [PATCH v6 0/6] vfio: selftests: Add driver for Intel Ethernet Gigabit Controller (IGB)
Date: Fri, 24 Jul 2026 21:42:00 +0000	[thread overview]
Message-ID: <amPcKEBsrkTH1JqQ@google.com> (raw)
In-Reply-To: <20260722-igb_v3_b4-v6-0-0be1d29918d4@google.com>

On 2026-07-22 12:15 AM, Josh Hilke wrote:
> This v6 of a series which adds a VFIO selftest driver for the Intel
> Gigabit Ethernet controller (IGB), specifically targeting the 82576
> device. IGB is fully virtualized in QEMU, making it suitable for running
> VFIO selftests without specialized hardware.

> Testing
> =======
> - VFIO selftests builds clean at every commit
> - vfio_pci_driver_test passes using IGB driver + QEMU. Use the following
>   command to run the tests:
> 
>   vng \
>   --run arch/x86/boot/bzImage \
>   --user root \
>   --disable-microvm \
>   --memory 32G \
>   --cpus 8 \
>   --qemu-opts="-M q35,accel=kvm,kernel-irqchip=split" \
>   --qemu-opts="-device intel-iommu,intremap=on,caching-mode=on,device-iotlb=on" \
>   --qemu-opts="-netdev user,id=net0 -device igb,netdev=net0,addr=09.0" \
>   --append "console=ttyS0 earlyprintk=ttyS0 intel_iommu=on iommu=pt" \
>   --exec "modprobe vfio-pci && \
>           ./tools/testing/selftests/vfio/scripts/setup.sh 0000:00:09.0 && \
>           ./tools/testing/selftests/vfio/scripts/run.sh ./tools/testing/selftests/vfio/vfio_pci_driver_test"

Extending this, you can run all VFIO selftests like this:

make -C tools/testing/selftests TARGETS=vfio install
vng \
	...
	--append="hugepagesz=2M hugepages=1 hugepagesz=1G hugepages=1" \
	--exec "
		tools/testing/selftests/vfio/scripts/setup.sh 0000:00:09.0 &&
		export VFIO_SELFTESTS_BDF=0000:00:09.0 &&
		cd tools/testing/selftests/kselftest_install &&
		./run_kselftest.sh -o 360 -c vfio
	"

The --append flag makes sure there are HugeTLB pages allocated for
vfio_dma_mapping_test. The "-o 360" is needed because
vfio_pci_driver_test takes more than 45 seconds.

> Alex Williamson (4):
>       vfio: selftests: igb: Use PHY internal loopback on 82576
>       vfio: selftests: Add helpers to re-enable interrupts
>       vfio: selftests: igb: Factor hardware programming into igb_hw_init()
>       vfio: selftests: igb: Recover after DMA-read faults
> 
> Josh Hilke (2):
>       vfio: selftests: igb: Add driver for Intel 82576 device
>       vfio: selftests: Retry on EAGAIN during device reset

Reviewed-by: David Matlack <dmatlack@google.com>

Thanks!

      parent reply	other threads:[~2026-07-24 21:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  0:15 [PATCH v6 0/6] vfio: selftests: Add driver for Intel Ethernet Gigabit Controller (IGB) Josh Hilke
2026-07-22  0:15 ` [PATCH v6 1/6] vfio: selftests: igb: Add driver for Intel 82576 device Josh Hilke
2026-07-22  0:15 ` [PATCH v6 2/6] vfio: selftests: igb: Use PHY internal loopback on 82576 Josh Hilke
2026-07-22  0:15 ` [PATCH v6 3/6] vfio: selftests: Add helpers to re-enable interrupts Josh Hilke
2026-07-22  0:15 ` [PATCH v6 4/6] vfio: selftests: igb: Factor hardware programming into igb_hw_init() Josh Hilke
2026-07-22  0:15 ` [PATCH v6 5/6] vfio: selftests: Retry on EAGAIN during device reset Josh Hilke
2026-07-22  0:15 ` [PATCH v6 6/6] vfio: selftests: igb: Recover after DMA-read faults Josh Hilke
2026-07-24 21:42 ` David Matlack [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amPcKEBsrkTH1JqQ@google.com \
    --to=dmatlack@google.com \
    --cc=alex.williamson@nvidia.com \
    --cc=alex@shazbot.org \
    --cc=jrhilke@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=vipinsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox