From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C768D42049B for ; Fri, 24 Jul 2026 22:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784931754; cv=none; b=E3UqEV/sejOuTN6lSgpqzfmEAyLIiYw8iTcSZo10ztUZLpCEnNQ2NlcxKn1rAMLCuczIJK/MvA3+m7RSmEwMovmK/40TTjG8yPG1UTvbplfyzSQHSHx8I1rslZVrrwS96l73k4HCaYkvA9MN3ywImS6Obwc9c0rIDL4cptsUsWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784931754; c=relaxed/simple; bh=AdYfFyAgjIVO5XDodIBE9fbPfdcVANsXvv95CojMIRY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ihpZ9mXMo4sNmn9/rPwGBdN1vqcGR3xLD927PUhBOjJ0KnVwz88gygQ6qGQ5ssi6s18OtDc0LmQCnzI73tOKUt6hbotaRHZDEFX5pa19QIYtTLQRqbTZfavcYJjgqEj2z+bkxKfh6GtlzGVRueBvZ4h0km1n5P12yT8VQNVRyIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=klN+RSBN; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="klN+RSBN" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49557167508so8826655e9.1 for ; Fri, 24 Jul 2026 15:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784931751; x=1785536551; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=chE3xpVkIQFW5ArPDZ32cA7aJ2wqUwJA/I+4bx+PmKI=; b=klN+RSBNyssbPkYhi0NiYdxq3FRcunWSLZnKFGQDLXYmRKZkX2+6DavS5DxGaN4iYm Yo4fNximNXkbuzFziQRRza6QUCsqGJpUf38UfkoNqSGdOVHf/JeSW2EXvlehk2q7voOw 8DCfBkVNSbYwrTDqCh4ZNpLzz8eVpfesomLe8W9niG2okYJpK4LXDKjb2/eq87Cu9b+w k4fP4z5haE7ubq81FS5SGui+Q/fgzfmi004XsZmA4KyUlsqiiDkPmrUw4lFLwZqqy+bm +DpWNigaytQZpcSPuI13eWsX8XrWK9lMVNPN3NdGkiySaj9ORWKdt/HDoU5ZULxOKNnr //Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784931751; x=1785536551; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=chE3xpVkIQFW5ArPDZ32cA7aJ2wqUwJA/I+4bx+PmKI=; b=KjlgMrLQOuGJLrdcnz1TPnae5PB79T47WgudHOID3lMbC8SWjjc4nuhBOQLNGFnYPQ Xbp6KCq/roQUBcQf0Zm0uidruH0IlWO0GjyvInNhuUyr7emlcWhE7X2ZMtBqn7WimpEK 4o13xwxwLk/PvfSJlKQxNWDEv0xl5nztda9psNpWzynHj68SgyhZaKaRWxAm1yOK8d0i s3CvmuU+EByO5PY6cZSw+ISNOA3tEZYx2/MpB17NMfRI5SgHTsXD5NAs6VJERA/a0POW q9rjntVGAU8Ba633oulMjhVBgYu5gK3XdNHYTCltjDMJqGr511uTQIntSr/l5TypqdBI y8PA== X-Forwarded-Encrypted: i=1; AHgh+Ro1/bt8qxeBSc/FBdXnbiyUYSqBYY4qE126qT+1j7d8+xwBihu/1ckwe5x23bJkcKmB6BoXBXlGxqgjZMc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyv6uA7jNDNm7bxDbEXKP/5L/UW4SOnXEED6Q9bKrIL+zbBr3EN UTGbylrBmkl4sjZBNC3TeA0zOZ1UgES6zIXHbKeSbB1WwvM5XmcEen1j5Q8p3fgw X-Gm-Gg: AR+sD11yfCZ+ZSZCaChHAnxJqj3F02wbf4VM9hRq899R7DDHaEMzhuEs1ExtHKMmprm z9wQcMjg+Gh+4x/nieDr72aDSWibA4kZQ8RtS6xygOmmht3OwlqWnSgTtoihA1xjTsCmZRn3UFv 7NTELsOJuNdO4zI8E97dSsM2p2eTdlWlW/41eKVpNqRvoUu+9Y7STlcxueXzq8dv2m+v4enE50I zuEzCTvEXNC5M7VwZctbLZuXE2ZrF1/DzU1OShC5e0BTsgO2z1FMM9/ErmYiZxSwnZ1T4aKmhhF 7EIg0xf1EMD0UyAR8e0XwumwcZXM+kwW1AERGiDV8COOYeho9E2mPUtpgpHkZfGev0vdSCC/AbT UlIAX97m5qjfV4oGFPYHxOyI3O4PlChJgJ5P1KcnLFv5Q4NbQ6lWbOQHWZsEnipfW3N4n0AqcNh IEUUtVyxce88GUNq+EqJNPzSNmh1cxaBlbM7DfyL9X2CQ1VJ7sjSPnqyb7KxKp4o7VvQYtn9xpI fePyqy6KfQgJkFWQgfVI0j/BV7qx3IqSdAkUqgvFUORiwGDp8EFNY19o3EKH6+8dUcEsOgC28BI qFWrYUkGFtXcnqMN X-Received: by 2002:a05:600c:a00b:b0:493:c182:6b08 with SMTP id 5b1f17b1804b1-496b570f64cmr1640745e9.36.1784931750842; Fri, 24 Jul 2026 15:22:30 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-2a02-3100-ae93-f301-cdd9-d5ea-080d-9131.310.pool.telefonica.de. [2a02:3100:ae93:f301:cdd9:d5ea:80d:9131]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496b4866ddbsm25892745e9.7.2026.07.24.15.22.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 15:22:30 -0700 (PDT) Date: Sat, 25 Jul 2026 00:22:28 +0200 From: Karl Mehltretter To: sashiko-reviews@lists.linux.dev Cc: linux-rt-devel@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] serial: amba-pl011: unprepare console clock on unregister Message-ID: References: <20260724213348.77418-1-kmehltretter@gmail.com> <20260724213348.77418-2-kmehltretter@gmail.com> <20260724215548.54CAC1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260724215548.54CAC1F000E9@smtp.kernel.org> On Fri, Jul 24, 2026 at 09:55:47PM +0100, sashiko-bot@kernel.org wrote: > [Severity: High] > Is it possible for uap to be NULL here in pl011_console_exit() within > drivers/tty/serial/amba-pl011.c? > The root cause is in serial core: serial_core_add_one_port() registers the console (uart_configure_port()) before the fallible tty_groups allocation, so a failure there leaves the console registered after the driver has cleared amba_ports[]. A NULL check in exit() alone would hide one of several symptom sites and change nothing on the write path. This is fixed for all console UART drivers by a separate series [1], "serial: fix console lifetime bugs on failed bind and removal" (1/4 moves the fallible allocation before console registration); it reproduces this exact pl011_console_write_thread oops and an i.MX use-after-free. So I'd keep this series as-is. [1] https://lore.kernel.org/all/20260719221014.44354-1-kmehltretter@gmail.com/