From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2496B476053 for ; Fri, 24 Jul 2026 23:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784934023; cv=none; b=ruUOrbgBCSUSDTfRFyEdrL0LBgr5vC822bNmUwwSQyl6aQbTg3hLaRGXWSHzqBGFEhQLdwhU1RilbrjZA5gPeFTQbEpNy3TlkGIS9l/uhpc4cRrZTZ3/Qh/ApTREEdUgQ4wNzpkP6ZfwyHr6kPfOMlC2i/L+pQ67njmLb4fSD+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784934023; c=relaxed/simple; bh=vTPbPaUCfbvCDH8I0hFjGnBATGgT0m+Ap2wg81Wj+3s=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=sV/BZVY4CTmk2hX+RBbJ1ydGrCXpG2ie4+I7C+Iw/ohovLhKoH5oVE7o+M0WVq+zhqpn/0B0mJSAGzCBZobiLC5Ql9KoHq0NDXQwW+bgYxLAY+08ROuIjc96cFPUSHGL4d5PEvj6ouh9l8mIMKq+jRIfalRW0SNojp7MhR4mG8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LFpMgWMv; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFpMgWMv" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2cab973140bso14083405ad.3 for ; Fri, 24 Jul 2026 16:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784934019; x=1785538819; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OyqvMw4pNtuviAbPcMn+7IXNgSVNvvnPfbN1pURoWOA=; b=LFpMgWMvLUF1IEKIYu25Tezjsc0Z7OK7tZPoAIp0RckORgf0MeK1CnoZsdUxf9c2Oi Qg6AfJh47Ys5e8FKRFZ4DL0MVuu5maFYWWiXGp+1HzACKxJa3vlgkvBTZV9EDQmfgZ6a JvPX9ULJ9FoJY3ZyulXsx/bmCNvxh97/gDFNqNIp28jqJ7Ze+0DKjkmWkCdRVuuJM4pb F/Ev3xBtGqDyvSHI4f0q0dA7Rr5I5Alh92n/Hx32Oda9Z1vwMH9z6AuWfm08Jyg37Z2h PpWK3G+nWIvBaPvDHYbF2LFupJTpcQFzGmVIZwhs7oB2jKdrWXJEk90DBa0c/jTqRqON cmOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784934019; x=1785538819; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OyqvMw4pNtuviAbPcMn+7IXNgSVNvvnPfbN1pURoWOA=; b=Qq2o3NufDzQsdz3XhNfl7pCsvUdt6U9WmCI5TBYXedjFXyc8GMZ7TNWOmRrTglriNs TVWJ58PmL14KIUzP2XYNp7+PTSXEq55jzFQkmzn8IhxIDKHGLghBKlDmq6SgYCE7QHjJ NcdlSkDPbY6y3mgCoJybMbmxVz2CZc+fZZcbgb0EOlEMskTVqUnHTGRmLcyRtjyY6BGF gmgtbAj5MggVEo/JjU0G7SDbxFCeVpfE2koCVQYTQ1PBY8YglLLblWFzaMu3cZPbeKs1 gXiJqVA1i3s8KeSh+8uRXrSDHqmJuGMt5OySE/dMEpB7H/Hr2+8GV5/NHUsvcHlPKMBK OVxw== X-Forwarded-Encrypted: i=1; AHgh+RrfSwURwJkG/h9BZ8cgUCQuKEv6+M9gLH+r0KjC/AvkVISRw5XTS97XCZtKcWJOuKUo3UlO9ZXhAFvnQ2w=@vger.kernel.org X-Gm-Message-State: AOJu0YyAS4a8dFpymYfj+6iO0EdVfVbfnbQfwmPnODEtXKoaAQaXCNL7 FIuqs5V8eGM1hspK+fRNZDWgkHBqHvB2cPe/z/bK3Dz1AJvOS6w15BEw X-Gm-Gg: AR+sD12/Y5K9KTYPQ0IzClIYYNmvOCNQSZcoUe5Xx6i4D8FfYM2jdkOAmwYDqRM8TcF NGTGpbMOloO9O3qLoxEfgpnN7tW/Y2TRB592mThgXA8z2PBjl5+/i3kVltHny/P2jLy/yKhfiCk c0Rm4JtOqaapHXfHmG/ZGBS/98UYhi/HbusOOVd2YhR1khE1MFAXgDFs2Kki6mBTzWx0qoCdzIx 5eXZVPJcnCfezbeNjmL1rLkiqVjIpTzaa0kt5pMohgtTaRfZGr0g4YKeNsQWs/2HUdFohOCaXNk UXgz3LOeihlxXXCgT32BQcjk2vFe5PKPoGghMgXLBQug1Sl9CBvOE9BwVPFZ5I0lnfvj1OaB9tE TV/L3jAsDfkmkJTIPP/+0ht2X8+bPHUNE6SSKs7WfUQbeuiB31yskPdJ5Kgo3cZvj3ctVwh05gB an/OojB/uREUr92x5Ge+zSyEENqg4QWe38NcXGEiwx8og= X-Received: by 2002:a17:903:1845:b0:2ca:e565:7b15 with SMTP id d9443c01a7336-2cfde78b647mr2978215ad.10.1784934019267; Fri, 24 Jul 2026 16:00:19 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:40e1:40e4:dabe:543e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde81dcc1sm1204655ad.84.2026.07.24.16.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 16:00:18 -0700 (PDT) Date: Fri, 24 Jul 2026 16:00:15 -0700 From: Dmitry Torokhov To: David Heidelberg Cc: oe-linux-nfc@lists.linux.dev, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Przemek Kitszel Subject: [PATCH v2] nfc: st95hf: switch to using sleeping variants of gpiod API Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The driver does not use gpiod API calls in an atomic context. Switch to gpiod_set_value_cansleep() calls to allow using the driver with GPIO controllers that might need process context to operate. Signed-off-by: Dmitry Torokhov --- v2: - dropped extra "not" from commit description (Przemek Kitszel) - link to v1: https://lore.kernel.org/r/9b77e25c-8942-42f7-b82e-42b492b437d8@intel.com FTR I am not using this driver but I'm helping clean up legacy gpio APIs and stumbled on this. Using "cansleep" where we can is simply a good practice. drivers/nfc/st95hf/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nfc/st95hf/core.c b/drivers/nfc/st95hf/core.c index 321fbe8aeca8..4d772a308bff 100644 --- a/drivers/nfc/st95hf/core.c +++ b/drivers/nfc/st95hf/core.c @@ -450,19 +450,19 @@ static int st95hf_select_protocol(struct st95hf_context *stcontext, int type) static void st95hf_send_st95enable_negativepulse(struct st95hf_context *st95con) { /* First make irq_in pin high */ - gpiod_set_value(st95con->enable_gpiod, HIGH); + gpiod_set_value_cansleep(st95con->enable_gpiod, HIGH); /* wait for 1 milisecond */ usleep_range(1000, 2000); /* Make irq_in pin low */ - gpiod_set_value(st95con->enable_gpiod, LOW); + gpiod_set_value_cansleep(st95con->enable_gpiod, LOW); /* wait for minimum interrupt pulse to make st95 active */ usleep_range(1000, 2000); /* At end make it high */ - gpiod_set_value(st95con->enable_gpiod, HIGH); + gpiod_set_value_cansleep(st95con->enable_gpiod, HIGH); } /* -- 2.55.0.229.g6434b31f56-goog -- Dmitry