From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB5E638E8A5 for ; Sat, 25 Jul 2026 03:56:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784951768; cv=none; b=YvpU04hbYIE7EfhptJY5qFs8nskjqkBW2DRdSGVQ1n1rOEDqGROsLHogGiYVXyGzwMson0rI4Xb68lqeno2X6kj7dbj5L/Yd0PwHMKZMBFvkAqJv0pitaTQLcQKqJnukq+32s6KWmn98c0m1AZCnjnnGyDNePdCJIKyrLUvznHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784951768; c=relaxed/simple; bh=AQOGbsaqY5CNDvfdu5iKS89QbveqN0mDmOoGk5FQDwY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fStprZZ+1o7F0EJQu3/rdeJM93gmF/xV5j3OvxWFGfBEd2jExzjpttHywQnRb4kiOzXQ2ghyBXZzL4ovVyxJrSKAtvbNrdBj2loPGFJbnQSSCuw/iKvm7ITyOQh7USJLNWx+/2KuRI8g8YgMCZONDslzUCp6mZZQL8+q592Z66Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GUfDKr6j; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GUfDKr6j" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2ceab75934dso13523805ad.2 for ; Fri, 24 Jul 2026 20:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784951766; x=1785556566; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=PSfNV1C0CZLC5Gyeq9chzpvr4Scx9eEK9usvYx4E4h8=; b=GUfDKr6jKsn+Od5jKs5k+VuoQLHQ/DNaZnrsvOpLl7O6bTA5WF2/1bupWSdc0U0gA+ ciKfRRCTAwvUwtg6PVzUl+KOuBkcu0014hsg3zqcIlEZt44xQx/ItYT7z14+S+JYBUD9 NU/W+LtjLf1pfLqwSvimfjg9Bc205/H62QaCbFMQ4xIvFPypHAp7qee+2vqRAUYAEYjC zFbhxIBfytdH6NbWGAUnCRz4bEN5jsUPJX7bj1B8JFOz8XBUfB7VSMP33d8B9/ghzKTa LE/qj+6Z/OXBmAbCR3iBzkDKjPGZ/NvyPafzi5GkSVgkS63yUDENItd01wTB3/Hnq2RV DMww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784951766; x=1785556566; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PSfNV1C0CZLC5Gyeq9chzpvr4Scx9eEK9usvYx4E4h8=; b=IwOOv5aHdmIyTHBm6Z7KPXqRKkelrnpS6o07MYb6eYRKS07x+Jgh5HsCEx48M5yjB2 hqHDe1ORpVqhpcsHBzigjRKfp5rumgu5cChMbrdkpCtyzwGWANRid3hNoC/u0QHu14L4 b/DTe8Die084pB68WUFVSfcjHWFTdUwydD8hC3fEvgHEecdSwW273A3vMOpdyb6YB6Yl 5g4kWy1JOjGejTMSFyHMhhD5LJP3J/HGrQRY0XyDbu9fdSSkHEhjJY70dEDKaV1wraYw 3BdjDx8KB4WcWb145IgtJQhszNTbt8eGdOWOb5qdgby26aG8E7hT9dEe6abhxyIc/4oX n5Ng== X-Forwarded-Encrypted: i=1; AHgh+RqdI6sZOkriwJBkbDpo6r9p+ChHM7jXzWCbBHw4dD1+xKDHCHrQzOROxDhm6pjCUC1BD8bI/kysliXVwUQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxRM5wvFla7/XBuyjMJL635DJaTId4Q1XqE/2sZM7XFC4fynDs+ 7aTHFgCEZRM/L0VAgxZcBS5MhW5NvPnw+Zp6hyKLQMXis2s47QpyuLVF X-Gm-Gg: AR+sD11EbhvPwxwIxuvW3iXcElvYEhaO60MAGNbWGI5zyV5terudspy2DeHbVwCHTQW GzhcCl9RxA+iTJZughzjJTVirTai3VBFYg3jS5AZGefC0IjPC2Cr/Q64kAXFlUT8mIVBOWrfT8U SK6Ex79QI3XqQVU1xle3GGet7xAnncEA9phF58RUHtN8qB7CLk/qt3Qh1/xm1cuJfQ3uzLj38BD pswC7J6QKEH1kNkphzssXbHxWEaw/i5OoDrZtXPcI5kFFd6oSo4aW7E/0eRJH7WocLnVrup5BZm w/iwTZ6uaQQH71SubSAdJDtB42v1FIEMoQiTqfc3U/NTorJjW4AX0dgylhEsRhZRKQMAAvgUw8Q Uxrw44HcMZ5WQ8rrnmQkrJk/aZGGfRUJHkDZi87oPlLTIsBmABYuScrDwIO98+P5olBBqSw2M4l G3IIN+U9crjs4tqT8soGyyxfRbxshunSJtcmie5aQDBMjX7iaQnGPbrQ== X-Received: by 2002:a17:902:ef0a:b0:2c9:feea:4e4c with SMTP id d9443c01a7336-2cfde7b3945mr10605345ad.15.1784951766109; Fri, 24 Jul 2026 20:56:06 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:40e1:40e4:dabe:543e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc5a67f3sm5158323eec.29.2026.07.24.20.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 20:56:05 -0700 (PDT) Date: Fri, 24 Jul 2026 20:56:02 -0700 From: Dmitry Torokhov To: Pengpeng Hou Cc: Bryam Vargas , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Input: iforce - validate input packet lengths Message-ID: References: <20260720115018.75045-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260720115018.75045-1-pengpeng@iscas.ac.cn> On Mon, Jul 20, 2026 at 07:50:18PM +0800, Pengpeng Hou wrote: > iforce_process_packet() reads fixed fields from joystick, wheel and status > packets without first checking their lengths. In particular, the shared > hats-and-buttons helper unconditionally reads data[6]. The status tail is > a sequence of 16-bit effect addresses, but an incomplete final address is > also consumed. A successful zero-length USB URB additionally reads the > packet ID before the common parser is called. > > Reject the zero-length USB transfer, require the seven-byte joystick and > wheel prefixes and the two-byte status prefix, and consume only complete > status-tail addresses. > > Signed-off-by: Pengpeng Hou Applied, thank you. -- Dmitry