From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA19B48989D for ; Sun, 2 Aug 2026 22:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785709051; cv=none; b=tiIvZCcAl9DHt53Jq1u4ZPDF/JCmmkWsRs9fVYNWjKIOK8cKcceFaijJI7s3/cQGbwpcUzT2nkVk7vi0suau7Tf3ml/sNhJzuIR48IEX2BDYSt7Chv4dA6vZRzOTrkP14r+Mw5zrm5G70GQ8PqtEe4oJBNQnljCfbiWDaGTZoTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785709051; c=relaxed/simple; bh=T8GIVGVx3IVGy3cz7RX/iIVlyqRH0fdXuqZLWkXg95I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y5qKK8cJBc9vnnvjF/w39yoqBm4VaEw9H63GCLJHn8FPALNvJ8DG0m/BrEwH2NB33IEgKpftc9SWLPXEzGJUjvASpVuooUk967n/f8t1vjBUf0yFvtWLy7LYQ/RcUbEaV32t/tdnObQVdIJZ6vJ5K9tWFIpU+OeBBA4mkJ3X91I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=l30D97X0; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="l30D97X0" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47f7027ca11so1682613f8f.3 for ; Sun, 02 Aug 2026 15:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785709048; x=1786313848; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6bsPGvzNC3Iop4WsfghniduLra8GHqGeExlE9Ii45fI=; b=l30D97X0haxplDJA1LQczHII77xXxIut2oUbt5aPYMTZ+cNYgj5AD3f6h+CjF2kS9M ME5VilM82USaF0Kc7kgaPRVwy+IhJgbLylvhiBu3k7s5SQss20MZqTGXwIcsKNrtfe9r tOfESoOpFErqibVvLhQZQi+5gWmFpA3roEh1D4kCxlk38fvV5zXevDQiPI+i4dCxTCRh +s97HbuKcFi3JLXCeVDWyNsYtLc8Y1kS6IBOX2ucWxzuvw0Bi5YYR+yYf2hYvOXZXjqn LfMe0R3KlIVeilGv2nFVxr3JF4IOapSkEL4VuIt2vAeo0WDpjEAKKQ0SAb9hqpf899bx uiJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785709048; x=1786313848; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6bsPGvzNC3Iop4WsfghniduLra8GHqGeExlE9Ii45fI=; b=a9AeDFv77p0cIJYK8QUzIHbS8YxpX/RNjDv7f88uWw2vH25OJS/F/OfPzPM8/pHd1Z wldCHQWqewOhCXvgw5AIAoRZYm9KA2+c0QbaoyYej7QNrgbqrg4FgWbIdzqpob2X0XVq Oh/z+9N/1H4hm2CXIjCv+gB88CakhUCLkWYtA2TtQzjMmi+rSkBPwFUOhHrwz8Uw+fSz wqr5FHradIRuzpiVOa1xrXFFzoYBXGOLjbH1nThnwetwr/r3a58J6uVkA2nYDfjc5NPZ gmt9rRJgXNm4WTiUtQ9hYDT+gIPpyMoJMNkptj5LfiT+IdvSoihPuJk60tr8tzt8zC7Q dPhA== X-Forwarded-Encrypted: i=1; AHgh+RrQB7so52Ma4gdR7+4GBLK2CDsyeDWvI9Z55RoBkMRAu1IciNOpoiNSsFVkr/xPBU+B+AfFdPEBRvEWWkU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1Fz/P+gO2RrhDFBXmU3cxtNHYZEcXfZSYl6RdYaA7sDMAXoOI By3CL/KcJASBTuqcBNMONalGKP+Rng/lEGXB9oPuPParAqMmCxJKCjPAQz+KE2jcx7s= X-Gm-Gg: AR+sD107Ke8K2FzT25D7U7y6v8Kam+eA8NH5OmtdMDx6c3wefKUhYiJBxBME0daPk55 jHJ4dxceuX/r6Rs5sVeUvy+yxvgqXfa84ONtszii+sdhh6sZw0PsbziMxN2Bv4Qei0ol9ZWyp9X 5Kv3MBrhmKU4YwgJESKbHatDFzqlzt/KFR0ygI1FtwDmjJIzW1UX1qRDEXC5YhaqspLr9znNUu/ HtrcwNVzfvPUhlS7WU+XARuqSUa/gHTq44xYur6+aplf6krZco2F6+s6KPRq8BMwDK97KgfLkTb ft59ZfO4GCLSNRFq+HNv9NEYWT78AZk6Se+e0PiwFhBg8S23tRcRgcjj2jjzBsDgg8IUDOdIBti m55AaQ8Ny2SHXrDrq2/v8YBEFvKaHPkWkNvJczz+gpqvDoy1AEMkDG3C3ONQfs0Ay3ipYFYFBdh A3zYE4mLyJeE3XlKOzMcUQlWBrXt5hPzKx5B3p/UUjyavNNwGJ6UKxKK+98PiX9ImGBA== X-Received: by 2002:a7b:cd93:0:b0:495:3de8:33a6 with SMTP id 5b1f17b1804b1-4980c65ed1bmr126447945e9.16.1785709047703; Sun, 02 Aug 2026 15:17:27 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-49807b5f0c3sm155072855e9.5.2026.08.02.15.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 15:17:26 -0700 (PDT) Date: Mon, 3 Aug 2026 00:17:24 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: David Heidelberg Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Bjorn Andersson , Konrad Dybcio , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH RFC 2/3] ASoC: codecs: tfa98xx: add driver for TFA2 amplifiers Message-ID: References: <20260802-tfa98xx-upstream-v1-0-4dd55cdd658a@ixit.cz> <20260802-tfa98xx-upstream-v1-2-4dd55cdd658a@ixit.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eissgc2t76naakqg" Content-Disposition: inline In-Reply-To: <20260802-tfa98xx-upstream-v1-2-4dd55cdd658a@ixit.cz> --eissgc2t76naakqg Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH RFC 2/3] ASoC: codecs: tfa98xx: add driver for TFA2 amplifiers MIME-Version: 1.0 Hello, On Sun, Aug 02, 2026 at 02:42:41PM +0200, David Heidelberg wrote: > +#include > +#include Please don't include , that is going away soon. Also already provides i2c_device_id and of_device_id (ie. the two structures that used to be defined in that you're using), so just drop the #include for . > [...] > +static const struct i2c_device_id tfa98xx_i2c_id[] = { > + { "tfa9894", (kernel_ulong_t)&tfa9894_chip }, Please make this { .name = "tfa9894", .driver_data = (kernel_ulong_t)&tfa9894_chip }, Best regards Uwe --eissgc2t76naakqg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpvwfEACgkQj4D7WH0S /k5ofAf/fcXOQAhsDuQI1vXZjfYD+Nu2PG5sMkw/QbLri499oQfMbAfRG0JWATEF QlWrFmVUB03381JLDXyXWtkO5evnjkldLr3bqGY7QevsfpxmOHDV9zLomJjfAqyL RmIcbr5btKIh2FZJRZslqHYoKiG7SeNZJLyxeYU4lW8vZcohMMRHlPGSCEC7RoNI sJdx+JMXR+ZHBOuwOrObZDxREbyQwdSnxD1gEEwmXEcpb0rZUWVIEZKXNekbV2XN izdCJ/P/vwPVNl7yrZLjlzfD6t2AFmYBYIq4kLKM1vrAd8gxMcxwTQH+XKnFNaWC RZQ+MsjqlG8Lw4wj970ztO4ky/yXFQ== =/KIq -----END PGP SIGNATURE----- --eissgc2t76naakqg--