From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A928259498 for ; Sun, 2 Aug 2026 22:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785709430; cv=none; b=Tz8avJTahcXiRwsgY7v6DwXY8uSzYO65pHvN7jBUe/kOKwn5majLw/u12toai/DJw46KXdCBTORHt8X0KcTVzwg0XNWrxKVO3hAydxufz85ngLmSzH09FQHr25Mifsmzmz7o5w/WmDW8gn1x94HKL7AJpbleIhtJL5xNe4dhS+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785709430; c=relaxed/simple; bh=l1ZnHpxm2/LMNQiDhVhwSE0m9IpcWUrwKDgA+ZpNiFA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cdOfRGnp+NwbaZmDg6eaaU4b/Th++rY47ySsGxBd+q5m0pdtTq2O3/krLXWf/vxNvkJe5FTq5DMMI8kYjiy3kxq9c2VOJY0J9WW2MtqX1G5uiD5XaMQlAd9/b3dmY3zN785bDFgh2td3n00i7nIDbQup7SOIvX6DdtcFeFbHGxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=biKhHYEU; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="biKhHYEU" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso12069355e9.3 for ; Sun, 02 Aug 2026 15:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785709427; x=1786314227; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=l1ZnHpxm2/LMNQiDhVhwSE0m9IpcWUrwKDgA+ZpNiFA=; b=biKhHYEUBhRisKnxkGyEKIEDf803QjLlxC1C/l654mvzhuoyV2ocylZRdV4RFT5FeC xTDQy+dTgsct3jYVWZ0+/lPeLbpWCF+JGffDvKRRHT7fm6gaJbgVMeVD2ygc97j4oTj2 5DXbptSW6Hf9A/WjSur0gZVFZhBWR+k4pCkAEgUP4Ri7A/TWOf3nFAyVDqP3+1N8xB0I eRhZ6I8FYj8HDZZZFaj/r0UhhT6ZQY6GF7foTCWw1vP59wnZGeiCemOo6IGeq6+GUWtF gzwIfRJso5iWMHtBVkGGCZzwhlAjOJHcLH+PS4rXDeyCqIL7wItyShZSNSUPc24A0cLL zDPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785709427; x=1786314227; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l1ZnHpxm2/LMNQiDhVhwSE0m9IpcWUrwKDgA+ZpNiFA=; b=hb2vj5hzbk/yBzn8IlArGQIasA4Sp8twvFuAZmTpFuXjMK7kKFz9MX/fkATPiSWXCZ 228exjGwk0/w3sP54B7hGc2+s38ZXDdvtgOzOR6Qvr4IN+4iXQFQ7JbRvxBxAkQKBHZ/ Ff+qiGeEBwMJ6jGXSUzVDq6a5jp+XJSg/yo+Q1EVnRUdJ2HPTxpIx0BI/r0wBZHNrPEZ pQKRMkP9yyPoV2ArOmmDja7ZdZnop40d+vBEC40swfNCHN4uTWtX77gJZrGchMns+5BP IAlYHwvZQAq7BT5e6Ci+g/apqK1Jq+A6hy9mVnPr66FoTAJ+6oPDqcBNKA/JbN07AdqR xxMw== X-Forwarded-Encrypted: i=1; AHgh+RpWjJlb/cFN9VHrX5kpkY4jiNb8uhjZ7RM4sZPPo6/tXDnD4y6z4qi8IfTqGJD/xx5c0YOecO16VeOmepw=@vger.kernel.org X-Gm-Message-State: AOJu0YwBdokXh6xMsXMxCOTZvMG206N+bTfTWkrIRvSsvXPMy8kaR4MM RW1JHQANCCkfxIFiCw64w/LuNiRGsVq4bh5B/PorAXXwuaVmngG8w+kbc6PW52b231Y= X-Gm-Gg: AR+sD12+HGfrka4qP1Z8Nn767zH3LFK/gT7DFPSRkVE4EGKrjpLcRlLY0Akqfjoj1b/ J1K61DPMMhGfO7wxLepsSUdYD4fxemDor9IDECWsUW6Knnnh3jzhML0zHHlHFdJHybaYQTymJe+ /pVit8FRl31sz1//5W1IhBRO8h0jupARIj56MRVR1usrB17QW2Lge6wcot5TW8fO+eJB3NnA6iy p8LEWilM/itcyEVnLXpQamGUOhA+asT+3Zgb6W+bBJn+fHcUGNntBMZJ6M7lWazBcmvbgOmf3NL yJ/kG3haJ/GrrtKKc2/YgjMjBZvnAVOrIcSTAal7fqhPqhNZiwfOk95nOMQAWLeo1wg82kfg//v LE6jbV2zR9XHsdBQ/sPF93LY/qgYHxhhueArJj0Z3vB+zfQQibOe7C4cZj2IQE4TrvCX+it/BCq sGYJ8a7dPDpC1SM+CByuDsKLVcMahtnOAokeEUhlV9IO+089zmq2tvHcjwrdj2qNMZkg== X-Received: by 2002:a05:600c:8b08:b0:495:5b4a:53b7 with SMTP id 5b1f17b1804b1-4980c694e4amr194391165e9.19.1785709426561; Sun, 02 Aug 2026 15:23:46 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-49808691014sm168712505e9.11.2026.08.02.15.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 15:23:45 -0700 (PDT) Date: Mon, 3 Aug 2026 00:23:44 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Changhuang Liang Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Paul Walmsley , Albert Ou , Palmer Dabbelt , Alexandre Ghiti , Philipp Zabel , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Lianfeng Ouyang Subject: Re: [PATCH v4 04/21] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver Message-ID: References: <20260801072711.153217-1-changhuang.liang@starfivetech.com> <20260801072711.153217-5-changhuang.liang@starfivetech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gz2oumjekulxb57s" Content-Disposition: inline In-Reply-To: <20260801072711.153217-5-changhuang.liang@starfivetech.com> --gz2oumjekulxb57s Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v4 04/21] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver MIME-Version: 1.0 Hello, On Sat, Aug 01, 2026 at 12:26:54AM -0700, Changhuang Liang wrote: > +#include > +#include Please don't include , which will go away soon. already contains the necessary bits to have of_device_id defined, so you can just drop the #include for . This also affects several other patches in this series. Best regards Uwe --gz2oumjekulxb57s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpvw24ACgkQj4D7WH0S /k52FQgAnVpMoN8c7RMzlLeC4BZnq+Mr045A+Lyjzbeke6y6tbnrEC8YbXAvRo2N sNZXvZHsehjbmNqj46Yh6CxejtAye4h4IKeyjmmrOGc/+Q+bJ0g85G2hmalRb7oi CA+lzCUG1kR9AkM0WIATKYQ9xlDy/rxCqmIGxrfvfY/N/xxtC0JwBpuqmoq5BBaD 7VjgxCyAmBP3XRCgEJB6OEtCdz8Uu55RM2uFyy9Ep1/jGuW4EOAkgFzYOlv6XdDt 7/4pdjxlnZeXPQRqdYVo5atbFjSGaPkYijxj3ITmnD9eipiXu0elV7ONWEXCgejO v/cmCw7tsyRfKKvwR5+mjGtHhsRtuA== =Z5ww -----END PGP SIGNATURE----- --gz2oumjekulxb57s--