From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42C6D397920 for ; Sun, 2 Aug 2026 22:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785710692; cv=none; b=XDzjp2RqFLS4vEhQ9rtKyRnvKxhxDtpDtGxMA/xtlQ3wGkEa0ASGC1Lm7Ru3Eco8TJDtGe8RKiX2rtuSbrGqwU/Uas4W7Tz85mb3TUbMzUYPzw4iN2iDy+fO5mxbI1VxaORZzkSOHidvQ3zVIxQuAWFDAEQ5r6ZT+8ejcIh9x3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785710692; c=relaxed/simple; bh=1sVTYWJpMvOF+9w3s2e71H8B5OS3MATiOxgrCzaVnKc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fKeypIJG+mzbSgT2elQ8dTtgiVsRhnCCK7tYPIwIKKx6I+Yh14eBQxL8VAiUJq+tzNsNmm84hbq2HQVqClhyxOqIjsy1I0auRJsp82fpsMLtkPAghYNGmWedBqtMIJDYS5WCwahTCgMKZ2I3VSIZPaptFhZ1Iy2XYP/8RmIoLO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FKc4x0Aq; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FKc4x0Aq" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38e041ea211so2801135a91.0 for ; Sun, 02 Aug 2026 15:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785710690; x=1786315490; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bjiQvTX0l6Yp0x86rHCXVqD4HzzA4H7jhBK5W/WfYnA=; b=FKc4x0Aq/7kt+Fyvi50SB2zbRruICcW1YJRbAx0MZTZefpp6JTKWaRnFBC3DLSRcKD wAKrZAfS0gMZ6XqvlIKJGzq8AgPZoSTJoS+UiduVlfemvSW1zsZvyKCgiAcZy6iWWg9n 5a0eIypjZJzBm0+CVfycsprSQ8kEei3cXRsJDkHLaJCpvcBPsDoAUGgSNEWgSvo63Gm2 M0kgG/Z4lrG6Dwgy+A+SI/Enl82OY3MHQ3KPERWcqpsFzo3WTy/dLoZGccdW7MpoIqqb TtkJLYUCkNFwymxapwci/ncNsGyq0Wk+AM9B7R2DVzNTrZQZf3vrmxK6qwaeCKzSNdJ7 VzWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785710690; x=1786315490; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bjiQvTX0l6Yp0x86rHCXVqD4HzzA4H7jhBK5W/WfYnA=; b=pV4tBbqsHTaYGleyOBABoJlBwkFVn5VQwYC3JoDej8SzgfxSZdbHAun/XtceLgVSK5 4iJR8p92TSPRMivcwOs+fOM+9KY3KxU1tvSo59PqsOS5FWANjQGCD+5nYiWFSzW8kOkr LfgEQNVQcQ+VAQzw6RFKrpQ55w5IxDodOot/sUBR7XKpJATca54r7ihV3qqc7iFBfRrZ XCvi2xc+F1u169Re0qGNrA51IEuN3W0HETQcvheB/c46MlTp1Wpe8pydnNb6mTOuPwzv vdnMPMJmaDPXxaY/Kxcy6wTqeG5Xf5lIzg8UYkr+6VX1Y8P8VD2pOymWZahjXAv4rhHa xZ8A== X-Forwarded-Encrypted: i=1; AHgh+RrF246R1yD62s0EKJy2r+qWJdx4xcS9ih8xKtEb/+FRzBonLjI9TbbISWOSwIl9lQOql13Xm2x7zntrG3o=@vger.kernel.org X-Gm-Message-State: AOJu0YxSBa6CByr4msjwAH57m6/CUL6ZhjfC/yPWiO8F3Sm5CTYIAQSm Ev1L/7Tn3GUGPerp/iNA4xsMzt8eVc40vVwrDWVai0rf56kufm8LbO/W X-Gm-Gg: AR+sD11YQ8N4vB+ex7GrbwLgSuY9ymfp+yCBMJJeS6UaIL+aKVBrYUDwY51PKuW+/LP 7jgNjWqnj8ie02J4ELal/2ATmI6bUrgwo9Cxz67LV57G4/6HEEK0cN6oqbDpBxetm48KP8c7OyN c9+Vub4SL8TCs1OzD2sxsEWVsoLILYluZTwlYWjOEEjpikWt0D6sL//WljB+DOPtgEuzw5ekbc5 ZplVOUDXfblMEW+uAG/QfLab/gdbEhHL21Xyte5zCImutss606SNlDvLEPJr6bwkkF/gNCDyETI QTFltYkDjQYsMpRlui7NNDoWFK5Yip6ttBhTjkej7zaBraE8hNlrXhIhKrGaXLNE/BoRDfupIl/ 03yGKGXWCyHx2w2x+SDIXyAz0SRVl+40OGDY1VqCFDxGfEIUBx2fdXMmAE9MqGJkANLzhVE09KV si88xhkNRG3fZrdmKo2oACpwFuCJJKWlFY1hZx0NetWNWYbIVuZJsYvNlo5BpxCHbPFgVT/eedM dqX/YXXHwvpNaid3yDPXahKu1+EVQ== X-Received: by 2002:a17:90b:4b45:b0:36d:9e0b:3801 with SMTP id 98e67ed59e1d1-38fbc40905dmr7317019a91.8.1785710690303; Sun, 02 Aug 2026 15:44:50 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:4fff:876c:cdae:e53c]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab14475asm24000953c88.5.2026.08.02.15.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 15:44:49 -0700 (PDT) Date: Sun, 2 Aug 2026 15:44:46 -0700 From: Dmitry Torokhov To: Zhefu Zhang Cc: Andrew Zhou , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Input: atkbd - skip deactivate for Xiaomi Book Pro 14's internal keyboard Message-ID: References: <20260801101908.33838-1-a723356@gmail.com> <20260802031559.19701-1-a723356@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260802031559.19701-1-a723356@gmail.com> On Sun, Aug 02, 2026 at 03:15:59PM +1200, Zhefu Zhang wrote: > The internal keyboard of the Xiaomi Book Pro 14 does not work unless > atkbd skips deactivating it at the end of atkbd_probe(). > > Using 'i8042.dumbkbd=1' also makes the keyboard work, but then the driver > never writes to the keyboard at all, so the Caps Lock LED is lost. The > atkbd_deactivate_fixup quirk fixes both without a boot parameter. > > DMI: XIAOMI Xiaomi Book Pro 14/TM2424, BIOS XMAPT4B0P0909 05/06/2026 > > Signed-off-by: Zhefu Zhang > Reviewed-by: Andrew Zhou Applied, thank you. -- Dmitry