From: Thorsten Blum <thorsten.blum@linux.dev>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
"Pratyush Yadav (Google)" <pratyush@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] x86/kaslr: Remove two redundant if checks
Date: Mon, 3 Aug 2026 01:42:14 +0200 [thread overview]
Message-ID: <am_V1qH4EktlKYo4@linux.dev> (raw)
In-Reply-To: <20260802172402.GBam99MtgAHg3a6TeG@fat_crate.local>
On Sun, Aug 02, 2026 at 10:24:02AM -0700, Borislav Petkov wrote:
> On Sun, Aug 02, 2026 at 11:35:30AM +0200, Thorsten Blum wrote:
> > added the *output != random_addr check because add_identity_map() was
> > only needed when the physical address changed.
>
> The check is there to update *output in case a new random address has been
> generated.
>
> add_identity_map() was simply called to make sure that the new address is
> mapped in the page table.
>
> Are you sure you understand the code you're touching?
Are you objecting to the reasoning in the commit message, or to removing
the if check itself?
prev parent reply other threads:[~2026-08-02 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-02 9:35 [PATCH v3] x86/kaslr: Remove two redundant if checks Thorsten Blum
2026-08-02 17:24 ` Borislav Petkov
2026-08-02 23:42 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=am_V1qH4EktlKYo4@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox