From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C789340418 for ; Mon, 27 Jul 2026 01:37:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785116275; cv=none; b=aXK+WmVgTjzmitVqaHr6zt3gsWaIEif26d57nTKtfk2SNXga03sG+NUvisdDh8eHxqGlv0dTOb296Fkw6l+5vOTxZa/yILKHuXcRKPI5WD/dNiYeNDInfcfnFujqYE6PKiY7RV2+MG3woEvzgL3tT1O11fCHs9apnY82/Q8XPkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785116275; c=relaxed/simple; bh=4Du12IrYdFkkEnXL/yNSCK5B4x+jmIWWPczOqwUqqTY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UYsK/flMqHBwEQKdoHpL3tpZN4MktJYQTX+YmHZ+NmZOBaoV3t+vbPnB2GzmCvFZiWMeyFux7fEjdn6x+jLG9eWU6B35V/Gf9moxV4ukSrSo9+ig5/Oax7bzQa1cG/C1zE5UIr1WwN/5HmzoBkLzjyDtdSRybeSlIagTdOpljf8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UVb81v2Y; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UVb81v2Y" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-471eeac43bfso1843987f8f.3 for ; Sun, 26 Jul 2026 18:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785116269; x=1785721069; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=X5WxXKv3tM/juHDs7F+fi+T5krsvThiBbf/3eNS3EFY=; b=UVb81v2Y8FCOH/qo3DTSqFxRn4rsBbfjtSwcCH2VSvTiWYpIP/lASAWBpTGTrClXiJ gJgaIAlYBdLjUNixlrlM3Y33jSEsYRquVFMIt2nNBSyVDE4FS/R64uBKbq4mdWVql+H2 qcNUBaQ1nFHrP1pzLyUDuMQOHdljGC3CY3jUj6byItX3Hodx3wR+WgIWtQYUaFGF9ZMw we89yPBxdQk2VDKyDcQfQGuY45aJq2dg8DtFKuNLg51I8JcOorkCHHO60SGk8nNjLiSl XSzMCjECgkaQvaC5nEeBl+STbDnhNTHPTWUNLZyqRbKXUsMK3chUk+LijSmVhyazVgd9 W2ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785116269; x=1785721069; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=X5WxXKv3tM/juHDs7F+fi+T5krsvThiBbf/3eNS3EFY=; b=kNWl5IXe4SDDp8/PUk0zN1Zup+f31M7o11b4uOeHIDaQAmCcOWBG5nGLy/T2LvV+a9 Szjp81BS66RZfakIRG1EFy80yc1keEsNTbzmWJEVgQNfMJCglWxxdP99ZLYcqeF6D5OX 4HEBTq/xPLz0bT9zVtS9riSHuyYUJhqIXok0ALG2cM5/rvwon4bZr5IAN2eVYVmfxioa r76q1JRUqY5nimcsU83O/gY6IFNZWq2Jzk+ySOhzNg2vqVh4B02ht8b2UtH8h/5Vk0ct a83qwJ4rvgv3BB54Ty7R/2AR2+d6wQhngxcMwHECFQun13CwC2azOBN7UIprY/bfM9yO K1Lg== X-Forwarded-Encrypted: i=1; AHgh+RqU87xTk4hEutoQf3A3HNeSJqZylnlLZ0oShkISZK6yvpa6kbBu97pzJZMsAMUH6Pa08fQpCZAXNzRRgR0=@vger.kernel.org X-Gm-Message-State: AOJu0YyH2Hz8fUQpS/QJE2JUipjjfRwKr9NSAB8Jg4cb0/6h44m+pfp3 ROHTTBEcGPiMenPlB/IC0nBPdk+Pmf10V07MJU5mRYOhE8gdTH0EcHQG X-Gm-Gg: AR+sD13B8oiR5r613n0SKmmNgTqv4MJUUgzjVjkmb4fvJhKboluJLcQYZ8JMmDtdylN m/wsekjdc0fLwsI8N0zOyuWEwrHK1z8sa+6z2HPGps2h0mE4y2lv/QsKR0ELG2PwweSsYut3rxT hk+XAe15Afz42+KzVwYIlr+Dvqs0Kk6+myV+i3noxylHmoTs7riAMfoBbt25d86xzqG/DyPJpke mXdya5//JbAlDUUNMW9M/IN+3aZRU17LL7rMRVD8mTVistvJ54hLvI8CpAS7gfqGxv/1H+wKYde Xpn3Mn9JPyKeAUy3FpIVx4q9P6w602OkRBGPLc6+072JazTmjo+6pgHBqqLpsYyPBGyrQ0OF1qT c23/uG6XHyTMiBma9AyUeBz3vEkBVzIYMloeERXAGTO+OXp2t/J8F4Ws9EqI1Ik6Zotw+F1EFLW ZFoP9dbdRxo1VzRlyoqF80s8kkAFrpRwg4t2DeauVcKN/SHVUSk1SxNdNeUdZ207t7pudDNMVgk yjqp+cbZxxPpfcLNwdG46lvDZavlE8OZw1VW5oau5I= X-Received: by 2002:a05:6000:2512:b0:47f:4fa9:ae42 with SMTP id ffacd0b85a97d-47f9fc8c4dbmr8796069f8f.11.1785116268631; Sun, 26 Jul 2026 18:37:48 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-095-114-116-215.95.114.pool.telefonica.de. [95.114.116.215]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85bb57cfsm45492653f8f.11.2026.07.26.18.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2026 18:37:48 -0700 (PDT) Date: Mon, 27 Jul 2026 03:37:16 +0200 From: Karl Mehltretter To: Kees Cook Cc: "Russell King (Oracle)" , Linus Walleij , Nathan Chancellor , Sami Tolvanen , Zhen Lei , Arnd Bergmann , =?utf-8?Q?Micha=C5=82?= Pecio , Sebastian Andrzej Siewior , linux-arm-kernel@lists.infradead.org, Russell King , Will Deacon , Mark Rutland , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH v3] ARM: traps: Implement KCFI trap handler for ARM32 Message-ID: References: <20260715175223.make.153-kees@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260715175223.make.153-kees@kernel.org> On Wed, Jul 15, 2026 at 10:52:27AM +0100, Kees Cook wrote: > + /* Check for EOR/EORS immediate: cccc 0010 0x1n Rn Rd immediate */ > + if ((instr_prev & 0x0fe00000) == 0x02200000) { > + /* Extract EOR immediate value and XOR to reconstruct type */ > + u32 rotate = (instr_prev >> 8) & 0xf; > + u32 imm8 = instr_prev & 0xff; > + u32 imm32 = (imm8 >> (rotate * 2)) | (imm8 << (32 - rotate * 2)); With CONFIG_UBSAN_SHIFT=y, I reproduced the following in QEMU with GCC v14 KCFI and LKDTM CFI_FORWARD_PROTO: UBSAN: shift-out-of-bounds in arch/arm/kernel/traps.c:555:48 shift exponent 32 is too large for 32-bit type 'unsigned int' Could this use ror32() from instead? Thanks, Karl