From: Slawomir Stepien <sst@poczta.fm>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: syzkaller-bugs@googlegroups.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, syzbot@lists.linux.dev,
syzbot+9bdc0c5998ab45b05030@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] mac80211: reject station addition if AP or MLO link is inactive
Date: Mon, 27 Jul 2026 12:26:03 +0200 [thread overview]
Message-ID: <amcyO4e4bnBPinrP@nr200> (raw)
In-Reply-To: <741854f0b9774ce2da1e5c2fb551631aa4028122.camel@sipsolutions.net>
On lip 27, 2026 11:25, Johannes Berg wrote:
> On Mon, 2026-07-27 at 11:22 +0200, Slawomir Stepien wrote:
> >
> > I think we do not have. I'm looking at the struct wireless_dev fields and I see that there is just
> > info about what the configuration should be, not info about what is the current state of the device.
> > I also do not see any callback in struct cfg80211_ops that might help to get such info. If I'm wrong
> > then please correct my observation!
>
> I think we maintain wdev->links[].ap.beacon_interval?
Ah: https://elixir.bootlin.com/linux/v7.1.4/source/net/wireless/nl80211.c#L7188 and
https://elixir.bootlin.com/linux/v7.1.4/source/net/wireless/ap.c#L36. Ok! Let me try using that in
v3 then. Thanks!
> > Beside this, do we think that all devices would always need this rejection? What if firmware of
> > these devices would benefit from *lack* of such rejection? Just thinking aloud, not that I know such
> > devices.
>
> I don't think it should be legal in the userspace API, and even if they
> did, we'd have to add a flag to let hostapd know about it, and then when
> (probably never) we did that, we could change the checks along with the
> API.
Sure. If you think it should be like that I can agree, since I do not have any opinion here.
--
Slawomir Stepien
next prev parent reply other threads:[~2026-07-27 10:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 7:45 [PATCH v2] mac80211: reject station addition if AP or MLO link is inactive Slawomir Stepien
2026-07-27 8:19 ` Johannes Berg
2026-07-27 9:22 ` Slawomir Stepien
2026-07-27 9:25 ` Johannes Berg
2026-07-27 10:26 ` Slawomir Stepien [this message]
2026-07-27 13:26 ` Slawomir Stepien
2026-07-27 13:44 ` [syzbot ci] " syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amcyO4e4bnBPinrP@nr200 \
--to=sst@poczta.fm \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=syzbot+9bdc0c5998ab45b05030@syzkaller.appspotmail.com \
--cc=syzbot@lists.linux.dev \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox