From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 371D73AC0F5 for ; Mon, 27 Jul 2026 12:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785156515; cv=none; b=PRY5aYdnpTpZdsuZeoRhqejYA2cpMqrXX+O5O276okiVwOC1Y8jwNjs2yJ56uSCL3yEOzb9Jfdj5fKNwRrTTGUfd+sSIsGfnn7WQGySmAcPuhm2on57Tr8V7lWyd2DXrImcON62FKdJQmhuphdhBEFOPhSqrv29JihYkC4en1yU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785156515; c=relaxed/simple; bh=MgCxybrkKoLQuzWmyHCrET7izHx0wpC69vuu+M7Bi0A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fD5irUEhcEDU1LHGSk0hUVf+lVPqspnry378bHdqd+cnIoYOZqlSW7xbFX8BXmlWs2csvIkYPxlAMSTXFQjIzcDqvxfj2Ra7OQMn//TlXpwUuqAoHe/+xRck0jqlQW1O0sInw2tmWA15Rgew1L3A04NhjXYtVH9VUlsOKmIs4vo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UawdOdca; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UawdOdca" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4953e04ef16so29755405e9.2 for ; Mon, 27 Jul 2026 05:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785156512; x=1785761312; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=J6DdaVZ57Cvm8wo8IqS4pyHaIv3vcpLo2R5s1tMtqxI=; b=UawdOdcashMhty/fzdz1uXjDW/hb5iHJEcmL/GQ3ZxACEoLMvMO7rPgjLqhGk/D8re aYhtu8BDWXDDNW0ZvruCbpvl/Rx6tiNRgZT5hyLTyURJVj/NkQkmw/gYpJV9qMUxYcZA UIaOr7gTFSFm4sBPAHozm7vUkW5LldVZeLN5axnLVMbfbHP0wC1oD6t76LczWRBlcv10 yxgeCvbrEd5XY+TgcaYyr3M/7fv8VW2lmk26ibVD1I44uThTn5eDm7zSF2/NFpWrr5V8 T+7qEd5oq3fqXKv2wm5m/3tlofMlTSQIxEiPYZECkXwyrKN0EDBlmbsOcCjli2LvJFDC 01Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785156512; x=1785761312; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=J6DdaVZ57Cvm8wo8IqS4pyHaIv3vcpLo2R5s1tMtqxI=; b=QK6s2K7Ys7GOzJh1qhIJn3EUepsZff5iofV2Gxut/OOlqyYDybs9tPTf4RO/31MCl8 JMP/8Zo0hCqmEg3cyZGkCYe9ZI6ewphmJer948w36QmfyOIFvhSknUefVNx1eFTdniRq /D9R7tZjihNMb7g2QV1cJu+oJgWNMXx2GE/jnU5Wc7KBXdRBU5Wkqu67/iKNgTYWgcHL VZLM77+cjQqreyFB0lYvRPIZTkD82rGIOvTsb++jMyiTB89hvQ6MExw4M+oPAh2b/eKq aEA50o2GbCbhlPjacCaK4ZoOh9Bbv/kDVur5FnrfWYrz9dpZ/R12+GvTREKly5DZym7W 8C7A== X-Forwarded-Encrypted: i=1; AHgh+Rp+ERhrFaoOhXPBMfkuHQbbLS0UkT3qHyOPQKSDp6mGoB2LmHqsKDwhDZuGBy8Oy6nEIvpYgWaQUqY2lBs=@vger.kernel.org X-Gm-Message-State: AOJu0YxHlx3QZ+SObKOxtGj1SgFMtP52l+puDO1Wq0XWPy2MgGhB5k/c Ece+0uRVFeMntB1Tagje2EOMOu7QEQP/Se+SXH0NgcTuNY5Y7EOE+mzzM7+6AA+P X-Gm-Gg: AR+sD10uwi0/MpWJ9rdz+3mXltuGh+5xfPw+Kp1xEUGFnklwPgMS/Q3hkuQy8rYNVrG zcCwXZUjqXVa8dLjqcLwtJ6hrLrx7/F3m34RbJBlTN/MCsM4ZQQyijXwl5QLGos2YppMDBU5dHF bBRdMROi+nFRaYp6qg8+2gB5DMVCt3Pa6XtcO7GFOB2mjL2a5Oq0ZKNjgWCQaEN+lXKo9Hc2ldp RJrGrlopGCki4WvRBxYNyCGPIT39jUhIaGXQgOTUyL6hqdvGoubZXRxHDXHBbK6Jv6zFfDHSAbp i3Ov40BUnL19IcsdZqzxbFM7NdwwkSff8pIdYIGVSVSqa2rFeNghdMqE4+TTVEf29G+aTzkzRiz 4Izjsz/jzrSTqJceFPPTeD4SFC4nk+NlN2rUxlNHBzEAYgfloQsJfvBq+zE1O1ueN9rCyCf5uvQ == X-Received: by 2002:a05:600c:8b47:b0:493:f176:dc69 with SMTP id 5b1f17b1804b1-496b572e886mr119294425e9.37.1785156512062; Mon, 27 Jul 2026 05:48:32 -0700 (PDT) Received: from owl5 ([2001:861:3201:3d10:e302:2368:a20c:3848]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496b4858cfdsm238084945e9.3.2026.07.27.05.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 05:48:31 -0700 (PDT) Date: Mon, 27 Jul 2026 14:48:30 +0200 From: Gary Bisson To: Thorsten Leemhuis Cc: AngeloGioacchino Del Regno , Chun-Kuang Hu , Esben Haabendal , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Adam Thiede , Linux kernel regressions list Subject: Re: [PATCH] drm/mediatek: mtk_dsi: enable hs clock during pre-enable Message-ID: References: <20260120-mtkdsi-v1-1-b0f4094f3ac3@gmail.com> <8733xko1ms.fsf@geanix.com> <0f719c00-3cf5-4403-afbf-713b07255981@collabora.com> <65558ccc-4f2c-492d-8c74-627d27dce864@collabora.com> <87h5m0mkca.fsf@geanix.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Thorsten, On Mon, Jul 27, 2026 at 02:28:56PM +0200, Thorsten Leemhuis wrote: > [top-posting to facilitate] > > Gary, Angelo, what's the status here? It looks like this fell through > the cracks -- or was this issue fixed in between somehow? If yes: great! > If not: Would be good to finally resolve this, as we are long past "fix > within a week" rule of thumb from Linus: > https://www.kernel.org/doc/html/latest/process/handling-regressions.html#on-how-quickly-regressions-should-be-fixed Not much happened I'm afraid. The status as I see is: - this patch is necessary to have TI SN65DSI83 working - this patch also follows the DRM guidelines saying that HS clock must be enabled during pre_enable (see previous answer / [1]) - this patch has been successfully tested against MIPI-DSI panels (by Angelo) and LVDS panels via TI bridge (by myself) - Adam reported an issue with another bridge (PS8640) where resume is broken - Esben offered a patch to the TI bridge that would fix the issue we were seeing in the first place. But for the last two points, I'm not sure this calls for a revert yet: - enabling HS clock in pre_enable still is what should be done [1] - maybe the issue Adam is facing is due to the bridge driver instead as it could not be reproduced with another setup - Esben patch would break the SN65DSI83 init sequence, suggesting that the culprit really is the MIPI bridge for not following the HS clock requirement in pre_enable instead [2] So if we agree on the fact that HS clock must be set during pre_enable then I don't see a reason to revert that commit. Regards, Gary [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/drm_bridge.c#n169 [2] https://patchwork.kernel.org/project/dri-devel/patch/20260711-ti-sn65dsi83-fixes-v1-2-d85eb5342b98@geanix.com/