The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Nicolas Schier <nsc@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Alexey Gladkov <legion@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Balbir Singh <bsingharora@gmail.com>,
	Yang Yang <yang.yang29@zte.com.cn>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Kees Cook <kees@kernel.org>,
	Joel Granados <joel.granados@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm v2 1/1] sysctl: remove CONFIG_PROC_SYSCTL, it just mirrors CONFIG_SYSCTL
Date: Mon, 27 Jul 2026 21:51:20 +0200	[thread overview]
Message-ID: <ame2uP4bveiMADo0@levanger> (raw)
In-Reply-To: <amdveg1m4E4uQlGv@redhat.com>

On Mon, Jul 27, 2026 at 04:47:22PM +0200, Oleg Nesterov wrote:
> CONFIG_SYSCTL used to make sense as a separate hidden bool before commit
> 61a47c1ad3a4 ("sysctl: Remove the sysctl system call"); it was selected
> by both CONFIG_SYSCTL_SYSCALL and CONFIG_PROC_SYSCTL.
> 
> Today CONFIG_PROC_SYSCTL is the only selector, so the two are always
> equal. Kill the hidden bool, rename the PROC_SYSCTL prompt to SYSCTL,
> and s/CONFIG_PROC_SYSCTL/CONFIG_SYSCTL/ tree-wide.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---

[...]
> diff --git a/fs/proc/Kconfig b/fs/proc/Kconfig
> index 6ae966c561e7..24f5a36f45df 100644
> --- a/fs/proc/Kconfig
> +++ b/fs/proc/Kconfig
> @@ -80,10 +80,9 @@ config PROC_VMCORE_DEVICE_RAM
>  
>  	  Relevant architectures should select NEED_PROC_VMCORE_DEVICE_RAM.
>  
> -config PROC_SYSCTL
> +config SYSCTL
>  	bool "Sysctl support (/proc/sys)" if EXPERT
>  	depends on PROC_FS
> -	select SYSCTL
>  	default y
>  	help
>  	  The sysctl interface provides a means of dynamically changing

Please be aware that renaming of Kconfig symbols may not be welcomed due
to unwanted effects for users and for bisecting, cp. last paragraph of

https://docs.kernel.org/process/handling-regressions.html#handling-regressions

and the original thread.

Personally, I do understand that it makes sense to clean this up, here.
As the default was and stays 'y' this should affect only "few" users,
but still I am feeling ambigious about it.

Sorry for missing to point to that at the RFC.

Kind regards,
Nicolas


  reply	other threads:[~2026-07-27 19:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 14:46 [PATCH -mm v2 0/1] sysctl: remove CONFIG_PROC_SYSCTL, it just mirrors CONFIG_SYSCTL Oleg Nesterov
2026-07-27 14:47 ` [PATCH -mm v2 1/1] " Oleg Nesterov
2026-07-27 19:51   ` Nicolas Schier [this message]
2026-07-27 17:00 ` [PATCH -mm v2 0/1] " Oleg Nesterov
2026-07-27 19:18   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ame2uP4bveiMADo0@levanger \
    --to=nsc@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=bp@alien8.de \
    --cc=bsingharora@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=edumazet@google.com \
    --cc=geert@linux-m68k.org \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=joel.granados@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=kees@kernel.org \
    --cc=kuba@kernel.org \
    --cc=legion@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=oleg@redhat.com \
    --cc=pabeni@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=tglx@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=yang.yang29@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox