From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1F1142D77D for ; Tue, 28 Jul 2026 11:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785239627; cv=none; b=pGSct+PJcl+Q0PIdvs1r/AQjrUX/zgQfZsicoT2hIPYgdoZaPxp1Tddie3YgM/46VsDjHPBJyKcRanPekh9dUGRl9YzzgDD/PKuKG3twvgU0MpTW3L8PpYgMn4svnEgfS3GMZE90gDaVeHI8HH2+9wnjnqw+VgkR1tV7ApY8KI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785239627; c=relaxed/simple; bh=qbT9co8zjTbgugtzsLSSEzdDXRF3N7PY5zCrFQIN3Dk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A3WNTQXw8EJEmpI0SJcABx/u+1VyvRIQNJtlTUjJi2qKNdPhE48SGBIMFdxXLC+RmGGmFLUwXetQF+y8lkfC7+j9lB7g1iNxuj7Elf4oxRKXlypeswTYkyXAwM59huFlPlKa7dDJw/Rr8sgGo0KmgXsxGw+1ffOIhGRSrv/VoNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=YvLcKJMK; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="YvLcKJMK" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49558ce01afso28289055e9.1 for ; Tue, 28 Jul 2026 04:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785239624; x=1785844424; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ZFp6N2zfH60/bgfMWrmPhFkOYqdLpff1TB0x3io2THk=; b=YvLcKJMKAqW+U1nOJ76JYGwEkn1h3vUWqdal3LgbDZonxl0OPsrnbaOwGYIueGLUOC 2LGO2QkQHnqlEh+JyxLkAQcBJ9W453l5fPyWu+IEiVqq+MCH7zlc1sGJvWpmX28CVZdX 7ccSSOYfRKKNXNha3Lze2gfeBHWpGF2ToO0GPpLwvSrbJ1Yu3iWD7vgxc9Ts0/8tos0N Ax9rOz11Ae2Kj7kOzqpfQfEHFBBs008xpNX6l9vuO86FY09vY8YZUH4sPe5oDxsfGhKN flKDIYlWqKAyjZ+x7Ayqxkfyg41LdFzPdf33OQzylYNrMWGFnDIN8tPrFC4FKopdWS8D R9sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785239624; x=1785844424; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZFp6N2zfH60/bgfMWrmPhFkOYqdLpff1TB0x3io2THk=; b=JBNe+WlmzkZDkc4Rml1kaq/3l0TioziOo3N/lozxEn8FdsmU8jSxIsMUFZBaUYoLPK FVU4/ArMlB8WAZ44MmHif9Ms/5LkzFvWcSnPLJkDwgPuvwzRdSPJoJAfgsRwN09hFbgI RZ0GMT46JAT6BgJti7DKGwMmVQeb6q4uPl2giOMA6kcH62QcMMupLZR7O1g7ktplbltl YzpRUHpa5kSTGePWZQgEWcEgtjN5JLQxhvA7opa0ggczxJN3V1yLtZaoJdtZkY1EV4wd X5akDK29k4tw0tIY2J/jdOtFd5szXUTNrUE/r3iO6NC9BQcy0220nqznZIR5itMKXve3 9LBQ== X-Forwarded-Encrypted: i=1; AHgh+RpYzLYUKZ+lTEN1WbeI6B77iQB0OMCliWfK/a1Tw5M6PwD3kZf4TW+q/wgH23fp1w5kex7eOYOWYvKmmnA=@vger.kernel.org X-Gm-Message-State: AOJu0YwxdF9wn7q5nd/fsPPja96IvTZ4x3msBA7GaB0pEh8gh/h++G1O ndnJk6Q9tx3tqWjjGtwWzYmLF2sw5UpVxHx9N9neTjcR9gqJZxPyI5I4UiU4QcHvsaw= X-Gm-Gg: AR+sD10xGqa9/xwhecnO5uQcZQ6scg0WIk+a4VRmVncCfE136kKErwFuso1QXZnrJlM pBNGu42+95DyWdJDJhPdLI5eaM1N1CXTNW2Zy3Vyttsefs6MkPUR6Kv1/vtJkkOf3boqd6lgjWS 7BTgh7o0rkeoF1+/hWqU5WrjPft8kEJGDe+CkDMMUz7aQimNvfJdrDZVyPvN/TWxfGgnefof1my JAlFhLe/Q0n+pCkMNUnrFocHnn2cUrvu6O4WRbu/U7H0Kmvyamh3xSNoS398TtoEmMjtkFmQO1N oq6YTuG+cJv29qt28bso4wup/IhhCJCOhjFn5i1kconnBDp+/ouHkuYHqKWilD3fWnmmNB0D1WA X4JlLe8HzMDy6Ij6AqOSnfUDI3QbqLe7JXuXe7kxUyGiKA+FW7SSklfMxfAYp4SximePXZUKmNj 4RPqqkmuaz2fCZey29c2nO X-Received: by 2002:a05:600c:6304:b0:493:cfe8:5b36 with SMTP id 5b1f17b1804b1-496c641069fmr26877345e9.8.1785239623866; Tue, 28 Jul 2026 04:53:43 -0700 (PDT) Received: from localhost (109-81-83-7.rct.o2.cz. [109.81.83.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496c44a873csm76207195e9.2.2026.07.28.04.53.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 04:53:42 -0700 (PDT) Date: Tue, 28 Jul 2026 13:53:41 +0200 From: Michal Hocko To: Barry Song Cc: Ridong , Andrew Morton , Johannes Weiner , David Hildenbrand , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Kairui Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Zhongkun He , Muchun Song , Davidlohr Bueso , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen Subject: Re: [PATCH -v4 1/4] mm/vmscan: fix anon-only reclaim evicting file pages when swappiness=max Message-ID: References: <20260724033435.2573323-1-ridong.chen@linux.dev> <20260724033435.2573323-2-ridong.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue 28-07-26 18:03:24, Barry Song wrote: [...] > I understand your point. I just find > > if (swappiness == SWAPPINESS_ANON_ONLY && sc->proactive) > > a bit odd, since `swappiness == SWAPPINESS_ANON_ONLY` > already implies `sc->proactive`. It does so very implicitely and you need to look around to learn about that. That is my biggest concen here. WARN on is just a very poor annotation to remind us about that assumption. I would much rather have get_scan_count more self explanatory as it is quite heavy already. -- Michal Hocko SUSE Labs