From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1E673C1403
	for <linux-kernel@vger.kernel.org>; Tue, 28 Jul 2026 17:45:44 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1785260745; cv=none; b=XI3zVKmFqy5End3LZQxV2KlVowtxg0NJxx7W1PSgn8iWfta3813OSz5SSYZiYzYtOA/+1om925DPgi1BqsCNpI9qGFujoZzxXRZPH+PLXyZIJuP0YfiguTKMWO3lp42sRDUOof+ivj2WtxC2y3UOpfRdkHUMDYSaOwyGO92FXzw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1785260745; c=relaxed/simple;
	bh=WdLu0UoLQRrDDwtZV+48EDkANHPPUSlqcoFaPxrMkJ4=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=ROR454SCu0OFtzzGWeZknCNrtApIZNd3U5SJCYXDyJteuKWZhnIBD7M/m2Vy/aEkc6i+4DrMP3rAoDBqwNstYHop/xkHNjTJcA7R8cfQNqc6bznyq+lqwn9yxUlQGvUt32rbZ4/oO/XD0wKvKoBGmv6TSNSKO8YtigQbslWo6GM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FVzER59y; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FVzER59y"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDF991F000E9;
	Tue, 28 Jul 2026 17:45:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1785260744;
	bh=YWcOuz2FCk2M/N4hPo/RfjZ4wgMZydAAPFWNhRgyIZk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=FVzER59y3LnsZPz15yo4AC8e7/M/vcFnKF3tIZSYNB1SZ0cQxWVt9kgUaV5bm+YDe
	 xyFScO5UJgXzpbR1FS0DHEMnp+HdxrqFY4odmatBbI5gGa9FVOTiTByo1GouzNQ5qD
	 ZfScDcSGGCtJsVBuGCFwOe7Fe/v1vp86pHMpGIccPMtGyoqhLeiKCoq+biPLHnVXoA
	 Xufi/amjsgf9qbEEhJK4b1mmdNpoSKtRZ5SrO7YDrlK+3b58eFCYpQFYsfoOmiRFzu
	 LHRNBpb3t94bHxyfavFNXfVD9d8/I7tjHkuve5VWRsEGyMT7vFvKiAZ1VebjyCJrsX
	 jR3LiTzNR9OWA==
Date: Tue, 28 Jul 2026 20:45:36 +0300
From: Mike Rapoport <rppt@kernel.org>
To: Pratyush Yadav <pratyush@kernel.org>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>,
	Alexander Graf <graf@amazon.com>,
	Muchun Song <muchun.song@linux.dev>,
	Oscar Salvador <osalvador@suse.de>,
	David Hildenbrand <david@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jason Miu <jasonmiu@google.com>,
	Jork Loeser <jloeser@linux.microsoft.com>,
	kexec@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 19/21] memblock: make HugeTLB bootmem allocation work
 with KHO
Message-ID: <amjqwKoF0XrvYw9N@kernel.org>
References: <20260725172133.4018491-1-pratyush@kernel.org>
 <20260725172133.4018491-20-pratyush@kernel.org>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260725172133.4018491-20-pratyush@kernel.org>

On Sat, Jul 25, 2026 at 07:21:19PM +0200, Pratyush Yadav wrote:
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 8b2e551435ae..ff470fd0fd10 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -19,11 +19,9 @@
>  #include <linux/mutex.h>
>  #include <linux/string_helpers.h>
>  
> -#ifdef CONFIG_KEXEC_HANDOVER
>  #include <linux/libfdt.h>
>  #include <linux/kexec_handover.h>
>  #include <linux/kho/abi/memblock.h>
> -#endif /* CONFIG_KEXEC_HANDOVER */

This breaks memblock tests, can you please add stubs for these in
tools/testing/memblock?
  
-- 
Sincerely yours,
Mike.