From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C15CF3B6370 for ; Tue, 28 Jul 2026 19:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785266572; cv=none; b=MgkqsbRcwansAa622njY0W2l1MR2yDhyKMUnCQbSyg8zakYP5iVVw51YaMMSCR2e+5Q09JRZyCTmpS+hinMX6Gf3YwCSGmkD8XMU9HC8fiec0G03eMQjDAlID4fH16Rvy63VlyLnwBYIHZ8HdK6RHHC46Iv6XCDXsye1G9LpdIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785266572; c=relaxed/simple; bh=2D/FRK6IKfH3OlCbpGXwXKTryIfvwjIoDuGgo/L1TQA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E42LKMPHlPHmVxol39EGf4K1LkUqqsa6gnlQtXmDA+HIoCkib8neG/44N68V0nJHr/JYhuNFtmxj7NSGlOqSzdRzMpomPHbJBP4GcaNL4lWZqi0BqgJT6qixK7yrHM/Yalw/D68FhScofypK0yhfN9luTxXg1aH4zrNl8z1Wub8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=lorJfZJ9; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="lorJfZJ9" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-84e04df8c46so225320b3a.2 for ; Tue, 28 Jul 2026 12:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1785266570; x=1785871370; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Nw6alsg9i/3zFCeIZXaBR9Fk17tbjbQpGkOg3KxSAGc=; b=lorJfZJ9XqDmSSPRNQ5W4qKbdGaYDgmBwEy+2VwWfu/X4oH7S9JFC9SNUmYAY6HZMy dmda4kTlbOmQP2LHG9Xhkh3EDnR8wvbMJQYBppwk0fkUiA9KhxnpP5/rVn3Iul+TQWSz LCiboeXFaDy2oXCQbjjk7FWP99UP65pl9SFP34W8sVJxBcRaM2hAu9yTPqS7kCEySCrN 1pRDjPHf3y6KGPUTVhjw50LP/UGDnX5G9PTBk1OTP7gSPrJh8gbQFscu4SXVNWUL+oB/ OhNv6QpH7IJDXhlb/P+sEpoIEPAjGcOrzv5K7ueEmoTaQnHLmjk8Vn5MbiUiGWeJMYKu ATOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785266570; x=1785871370; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Nw6alsg9i/3zFCeIZXaBR9Fk17tbjbQpGkOg3KxSAGc=; b=nx+r13bsUUHyQeOFDgod9sV0xOoRd+AZNbArUbwHlAWcZlqWj4BpSqhedkVYE77Kl4 xeBCi8MZdzqU2YeNVvPwm76wEBtTFU9xUuZqC8uDERUkSpGZA0inKV7/GoyNPxdQVUKM Bn6/LyH66HYy+Y2ab+IjnnTklWBV9tWAepGhhKdP+wZ4tpXuRSNKl8lFu9iS9oI/4YHj UC02p33ED0p5oyWcbXKSv2tZxU2eza5Rb+5kUi1IymMwEtr3Wavy+sdenNpaBWl+A/1p zBzWhzloUD/XUqWCE+ogbDFL7qOR9nk+rSoNcg62XvbpanSiCQCLW7X00HvUaWF2njpW umsQ== X-Forwarded-Encrypted: i=1; AHgh+RoHytmjc/n/+qAfP9vcII0eyNHcryCM6jTQ7HPNEQ5cIl3oqGzdJJP0BNB1UGCCH/r8ZRLnKe6RAUAhDLk=@vger.kernel.org X-Gm-Message-State: AOJu0YzyMieioobgXMmNaRpehpvMaOJJjEOfV51+KHhjUp+0hVEYJTIB 0jfMvuR4YQHm1FNm4LqgrSUhH5ZEG+oG0vK/BAt5ds4ZHQzmVfWVFC7F48+ZecsX03A= X-Gm-Gg: AR+sD107EmWlkwwevLRUnhBLKOafew3MIUxpcZjyBLo5XqEjYoqDOh5x1+BS36HYgC5 oZbZAISeT+W/KRGXVOmPwc2VauWQ92i+D1Ktp65DnyGWt8Rq+sWVGYouJZ9L5bGy7UXj+fPBTCw hv3PebkXyvi2qu6ocVlOPDIdemqX9SeSq0z1Od3XBuK3Jw2elTORtHm7NBTWcuNL/yYMoDU64oR Zyhaorke7TRAumEHHspaHwL/hDXTT6/AuX0szAhfUB45cuMytHaLWV6fls3bNhAnQhoEv+B2ktu pcRFxazK+NA1zNK+euQDRkoz5cbHQN89ee0OxbDqvJqX9vroA3x/Z1JGFVTWRTV3XzyEGGjgY1N i1zFTjUAkA2pMukosgOH4yuWVYz/bxg3ZVWhIWYPc8jJKXg8O1BIMMb3QKUL2rKYxJ/Akdg== X-Received: by 2002:a05:6a00:1f05:b0:848:2f77:e2e5 with SMTP id d2e1a72fcca58-84e933abfa9mr4241034b3a.78.1785266570052; Tue, 28 Jul 2026 12:22:50 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:4b::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84ea02fa474sm344039b3a.30.2026.07.28.12.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 12:22:49 -0700 (PDT) Date: Tue, 28 Jul 2026 12:22:48 -0700 From: Joe Damato To: Will Chen Cc: Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Wei , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] bnxt: fix memory leak in bnxt_queue_mem_alloc error cases Message-ID: Mail-Followup-To: Joe Damato , Will Chen , Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Wei , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260728191146.1744825-1-will.chen.tty@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260728191146.1744825-1-will.chen.tty@gmail.com> On Tue, Jul 28, 2026 at 12:11:45PM -0700, Will Chen wrote: > There is a small memory leak in bnxt_queue_mem_alloc: > when bnxt_alloc_rx_agg_bmap() succeeds > but bnxt_alloc_one_tpa_info() later fails, > the rx_agg_bmap allocated by bnxt_alloc_rx_agg_bmap() > is not freed in the fallthrough cleanup cases. > > Simply free the rx_agg_bmap in theerr_free_tpa_info case, > as this is the only remaining error path where > rx_agg_bmap is allocated and needs to be freed. > > Fixes: bd649c5cc958 ("bnxt_en: handle tpa_info in queue API implementation") > Signed-off-by: Will Chen > --- > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Joe Damato