From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 110F4382F1A for ; Tue, 28 Jul 2026 19:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268489; cv=none; b=WA8m5FcPyoGvLr3heK61DEsOkj8aOlx3XYfI/FVSheokfG8mWhj9g7SbddzMUGi5Ute0x+MxAvt+WiIxvzeFz7nK4ucLoA/Q8AX5V7ItDVp26T4zgJ437Sa1PPpiVl7tQ2Ju7Uz6mDmFYQOh51iB9W9FsJtiQQNeuN/g9TCAgKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268489; c=relaxed/simple; bh=Mnb5jQDMmmDKcsAgTmtSwwQpbHnknHyuvUA6EP5VPUg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TvoPpg+pcHAGIhe717zozkdbMeDPb6e23V4Vp4xDIJ3zZ32N151P8vft7xeBLgCxGcCJ5D86J1tqD92JJ6hBEZclEOFgeYtgGc+L/Hc0LUZH1SXJy/x6mXsFU3CcyxigJgdlP9UTB5mABjU7JfdNp9t8WbFjR+/xkN0D8ZSM09k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aVtqBVaD; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=uDgZYt13; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aVtqBVaD"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="uDgZYt13" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785268487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V+jyHiNy79/J/hkBXzj6oSKA3bKerUWbLvWU40tpTYY=; b=aVtqBVaDn3aMHNB/TuLkgRe3zMi8p7M+yYpu/9JxwE3hpGTjLL1cHSHH8fmJqL/47lIArK g6GptcW+3YGYPPQo3qAsZdUXh3S7BH9phTNbor2PBqCj95vH5Lyjdz3O7q2p0dpwr+S2kB XxxVmlY25RZc26RVtai2lYQWaHN9H9o= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-xBN8jQmQOxqSQDzuQVk0CA-1; Tue, 28 Jul 2026 15:54:45 -0400 X-MC-Unique: xBN8jQmQOxqSQDzuQVk0CA-1 X-Mimecast-MFC-AGG-ID: xBN8jQmQOxqSQDzuQVk0CA_1785268485 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-904ee4473a8so2038946d6.2 for ; Tue, 28 Jul 2026 12:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785268485; x=1785873285; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=V+jyHiNy79/J/hkBXzj6oSKA3bKerUWbLvWU40tpTYY=; b=uDgZYt13rIRVIF/Qq2nNnfF3SpK8zlpy/QvBikOdFUjvvZUH0bc3G6dAjpxrxUhrjp LNkPdCmAzlYHj2+pycoKPC5Q7lOBmUVrhS2v0OYfwO+NFfA0xMQ3PQ0plgnhaRpCRbqG 8mEJLl+VSMOx51IFHqCTqVqO51wJDqs4Tx9v6Mhobf3C8NAgG0kVeAmIXtdiJb9/nfjE 8IR3w0ySl/hcF+o1GPjsXpFFl9ZdMjMYM3AGQQxpRRqSvICFh73vq9KfPep9GXL7eyol vDnomelqzLBtAMzfrHtX2XMyKH9EBNCx5LXLPjV55ZWnB9+udJsxUOpaMoC/E/VVqIPJ aXFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785268485; x=1785873285; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=V+jyHiNy79/J/hkBXzj6oSKA3bKerUWbLvWU40tpTYY=; b=mWjpmGkyNkPrDADh3HlyVIEdJ8+cdAeB/OW/iEaStUguoNTXCMH1mlJlcN2DWMJeLd SojJ+ZFdBZ9xFBSkWW2FBhWStq6uWcEbaloHrzB3GdmSFS6B7fagISpEe1cBQUW1tlfd BSvyU3rgDIR/NjYGKc9EF+WkWI+QbPoKVEWFBZ2zLUOYV8PiGXg0PifT23dKpV2EH7B6 778J3JDh3RIurD3+Ha0UJUYh7aMiqpl5nl/UqU+VRy7HeyZw3gjHNRxG8CUTRkDNAWuS hK6iNrK7V6Sfm3SlCEwLpIy5G7Agx/V4g5HPDGTVpCBE8tIIMQcWRFrim6eNfmNZ/qlT MI6g== X-Forwarded-Encrypted: i=1; AHgh+RrtS3rUwwbw3j09JbkXl0OVBbVLszBNDGOlRzGSLJQw1jK1mr1bnwxYNHyEWNwTlFMp7XNMn8g1z/1kxwk=@vger.kernel.org X-Gm-Message-State: AOJu0YxlFzs5FtryW4l3M2OZ2d3naYZJl99RKvKPrMvqQQl3HedGcGOh eEdeoG8x+ecB79uK7CcQN3zNacytGN8ogGPeIEUpRW7VVnvfbqvUhP7Yp5xFPZ1vh0+27zfVHjm 6ueAb9IoUFajiEWk5g0zlBxPlfWtbaw/O5V8n+eWPkhgCd18lZg/mVnJFsLlLd90utg== X-Gm-Gg: AR+sD12QlpDnwMZYSsU/tCJkr9nYi21v8gRv7HLxfaPqy6OUNsq7V3lQ9yBdU9WIilX vbLEJQTXDfCkLvg+2VqAp5RtLdQFsOXPYIuxC4BhJ0V2IgoHfzBeKsw1pCe7YgM6n1PP4wMpeHa TUzzlauuytWoJhX1Xhiyv2nUOqXYTIS9ZkRK//4pZnDUC3HXQn0av66tPSv76trbvX6G8tbDtUm jQLUrukdAXd12QT4NC9SRjto45J23GCUUfaSSWUtwhi6ylOltvv1nRUQ9kZfF2K7rLfUprIhNXB zOjOJu7fAu/5pmIdC0TuYSo9UKvwxU2JqWmGEv30DLQpW6LTyljqGQnW3Nioqb0cim1OeMc3bX6 jj9X8njYyGG0t23c+smQAJWwZ/HRIpQA01IE= X-Received: by 2002:a05:6214:458c:b0:8ff:60cd:817b with SMTP id 6a1803df08f44-90817341bb7mr46431816d6.64.1785268485037; Tue, 28 Jul 2026 12:54:45 -0700 (PDT) X-Received: by 2002:a05:6214:458c:b0:8ff:60cd:817b with SMTP id 6a1803df08f44-90817341bb7mr46431536d6.64.1785268484643; Tue, 28 Jul 2026 12:54:44 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9081dc498f1sm6828116d6.9.2026.07.28.12.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 12:54:43 -0700 (PDT) Date: Tue, 28 Jul 2026 15:54:41 -0400 From: Brian Masney To: Sang-Heon Jeon Cc: Jonathan Cameron , Andy Shevchenko , Brian Masney , David Lechner , Geert Uytterhoeven , Linus Walleij , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Magnus Damm , Marek Vasut , Nuno =?iso-8859-1?Q?S=E1?= Subject: Re: [PATCH 1/9] iio: light: isl29028: return zero in write_raw() on success Message-ID: References: <20260727184755.2055414-1-ekffu200098@gmail.com> <20260727184755.2055414-2-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260727184755.2055414-2-ekffu200098@gmail.com> User-Agent: Mutt/2.4.0 (2026-06-19) On Tue, Jul 28, 2026 at 03:47:38AM +0900, Sang-Heon Jeon wrote: > isl29028_write_raw() returns the value of pm_runtime_put_autosuspend(), > which is 1 if the device is already runtime suspended. > > In that case write() on the sysfs attribute returns 1 instead of the > number of bytes written. Make isl29028_write_raw() always return zero > on success. > > Fixes: 2db5054ac28d ("staging: iio: isl29028: add runtime power management support") > Signed-off-by: Sang-Heon Jeon Reviewed-by: Brian Masney