From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B75F619046E for ; Wed, 29 Jul 2026 02:20:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785291627; cv=none; b=uM9n056Zg9taHucFOu1ygZRmVpUG4bz1x7hVpc90AYoLuyG36GCoSxYMReVks38jJam4RSCflRC7n96UmEvrcmOesJaOhdhq5DnJ97IqwxvQinNm2HJUFHl5bDWNaeLDN7G8GiRja5+V8c915vloL+E+N6cvl2i3pHUfeA6JJGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785291627; c=relaxed/simple; bh=r9x8Fysim5hVjtPUDGKxdgGClLYIvPD9SrYuzWgfCPs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RffvXUYdxAYiuEyy16qXWLa+pmG1fA1CQeAv6ep8fZiFfgyfHreb7DfQ+VTJbyWqp7EQVM2kki5W5kWVNO8bmUbNiroFEisxN3tSO+HOBuTzdguFWO8223DWKy9po0zivb8azm9QRp1wkcjlLq4Dxm4l9N6N3PxTNmN0on7VLOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ZfmeS8zH; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZfmeS8zH" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8487214ad2bso687174b3a.1 for ; Tue, 28 Jul 2026 19:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1785291625; x=1785896425; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=HHcwyINt33m7baaducLDDGQsoqsndwm8e5Uygv0qJdA=; b=ZfmeS8zHt1eXlUMs8oO+sPBGFqdW/uFUjWjxxYRZlrfcVIbEjdKPjeiJ1kOkRXKOC5 XIJC5Nqi82BwZG5AttcG+5LG9F1SMOGKLtnngs3gCn/iNCcng/GZZqwZehxWimb0VO8T sSaU5GzEpNEysMKfheSO30H/sS5YcE5sXV7Ec= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785291625; x=1785896425; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HHcwyINt33m7baaducLDDGQsoqsndwm8e5Uygv0qJdA=; b=mI0FDSvzxfpdGyKK1TCS3ORT/L0zkkOImgO2We6ld3eEbfhX0dT2d7Eep14vd+IKQt gX2b4D4O+UQj42BDF8Yp5FJTrowNHePVoJMygL9K9QQP1FyiQqTet38uQxB/Tyb3/YKO bKnyJLCsK+9E08yPwbDvDpmVXqrAJ4g4loKwjrnpJA/UDC0HLDlBuDjP04e5XXKMcciu nB6bZpzIHwFYXjzea+fX6roIzz9bXGGT4n+R+ssb9pjwv50Cmz92ASPSszwWqskBnndm rf1908QAKjRrLx45n3Ku67jpoCEo+0f7mfBGU2iT7ldwlGP5Eu9KBgGEmwnXU8yn4zal GvpQ== X-Forwarded-Encrypted: i=1; AHgh+RrYeQQqiOeXz4pqnjR2RvQCnT/AN/J3xwHN0Ln5Ws57+kvSKl1F/w3q37aVpmN/gaIprGC94fbKTz2Gr/o=@vger.kernel.org X-Gm-Message-State: AOJu0YwSBe/SRgnk9/OvzHQA1N2yDuc1MOjNtNLKOKzwynD64LOrx/Po tZLqmOff0AAjzfk2P4gYWdTC3ooiE+jk/Pkofc2EI2Pf3Mn2oV3HhHHIumuOaTJ9Pg== X-Gm-Gg: AR+sD13slKOzFLvn5sQ5R5PblpchCAt2NEKd1plR62lbdVCI/pNRHd1cOhAs/vrP3SI XV1IzdY3B8d3SYECsv4EZ6UfuG871m8pwe39OSQZBEBlVkFcGgSPboRt8dFzmLvIS15kIPZ5cmb YPQ4SNSnMPrpq6vIdJ9Rf6N9w0IpeZBwDa3h+5DpqUN+Z43ui77GTAhwEpjhtrJF0Ir3b1k9YIe 1CXFeSO/T6BFm6M6gSHlzim1HP8B1zQvxWpZWSzIg+QV3k5Pcr6PZK69/mfdhsuUpDIfGKJACYy EUJo71b6ODjE2LuiVF8t1tq/aCPFKV0BKgObxjL1E/3a8urkion0p5bbNHadjgaaFlrIATCpdzi roId916YIA4e9vjv6AThEbOUe8usv91BWHvbxNLXewhx58thmSxeQFAPXa2B+3TNs12H7zREMQG 1JuFuUcNynWsGNqvkwcDsdd0k1uYVM4DAoss7PfdG2byLesQqkdiGnfaB7qaR7XaawpVOEfak8j jjDKvfFmHn4QyXAZGLCxP+wE4aT X-Received: by 2002:a05:6a00:94d3:b0:848:77b2:20a with SMTP id d2e1a72fcca58-84e933203d0mr5000504b3a.39.1785291625053; Tue, 28 Jul 2026 19:20:25 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:65c1:52a3:f6d3:37dc]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84ea0052e04sm612552b3a.22.2026.07.28.19.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 19:20:24 -0700 (PDT) Date: Wed, 29 Jul 2026 11:20:20 +0900 From: Sergey Senozhatsky To: Haoqin Huang Cc: Minchan Kim , Sergey Senozhatsky , Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: Re: [PATCH v2 1/5] zram: fix early release of global cdict/ddict in per-CPU error path Message-ID: References: <20260627070216.13511-1-haoqinhuang7@gmail.com> <20260728092935.31139-1-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260728092935.31139-1-haoqinhuang7@gmail.com> On (26/07/28 17:29), Haoqin Huang wrote: > zstd_setup_params() creates global cdict and ddict stored in > params->drv_data, shared across all per-CPU contexts. The per-CPU > zstd_create() error path called zstd_release_params(), which freed > those globally-shared objects. While the drv_data=NULL guard in > zstd_release_params() prevents a double-free on the init failure > path, this is still a layering violation: a per-CPU callback should > only clean up its own context, not release resources owned by the > compression lifecycle (zcomp_init / zcomp_destroy). > > Fix by removing zstd_release_params() from the per-CPU error path > and replacing it with only zstd_destroy(), which properly cleans > up the per-CPU context without touching the global params->drv_data. > > Fixes: 6a559ecd6e7e ("zram: add dictionary support to zstd backend") As we agreed earlier, this patch doesn't fix any known issues per se. Let's not send a false signal to stable folks that this patch is fixing a bug, let's not add Fixes: where they don't belong.