From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83CC044C675 for ; Wed, 29 Jul 2026 10:07:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785319626; cv=none; b=OHWyfs8aHluHQTITbtM+YxgZEz/8bwcgvqROBJPVDltR1E/4Ee0PqJj38xWbr+zb4YP4bp91eKCltTN3klUGie96WRvX4rKnNDILCDMnsZTE4CAO6M1zahB6A9UBalTAkFHNSEXiWUaeC/7LomGxlhQsbXCl+hSSAkjfIVvifNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785319626; c=relaxed/simple; bh=GgCcrNbHdCBD7xXFMVJvPxLFI+c7q21jZNU5tbMpJXI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PhazLsGzZ1HRTvRy13HFAl3U8igwazoR4wMxUFpTg9PwTYf9nRG82UwT/fXA32pMbbcs0QFwzqm1Vgx9bPw5ecsOk/X2KyiB7uWrr2v5YdVmiHA3f1v5BNpSr0Hc2JBu2KuBp/Gn/NZQHbiM94lJxzk3YJbgnwIoRokX05N6opQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bcCVhctK; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bcCVhctK" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2cce6a0c9c3so10594555ad.1 for ; Wed, 29 Jul 2026 03:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785319625; x=1785924425; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ltiyfcpncL+fK7rWL3LABJqprUpnAddinkICIJvoFBQ=; b=bcCVhctK4iY2i3r5xMupaHJdZLhzrTcFXx0ymw2rCVvB7CTlmoFXpJo8NtQkhSzdih VH51RIQF2ZugeuVJbKx1+8igUyb8OZZTtp5aysUPeDaV8/6x+XixrIdMGOi0H9DimtgR G33QU4AmuGjDg0tYhXQq03EC/eZWtMMYXYyD7CjDB4MYXWxEYZT3h4yF29f/7km523I7 LueOQqyMZ2UqCtwaJ/5iWoDwFgTVXeKA0jZpFMKKJRfeJ3b7jzdkbaXwBKwfChBQ52+X /V8aRvH9+tkXzqt4JkuxyPS039sPZIgTz+Bfr+XRTlmJ7xX6cDw5PHTGPViNUjxiNZmI GnzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785319625; x=1785924425; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ltiyfcpncL+fK7rWL3LABJqprUpnAddinkICIJvoFBQ=; b=RCPQSkcuYa6b530UWgEP6pJMiZ/8X2Fm+SQXhgEBm1epvBnxoxFW2fRR6BdIZq5QIK iyqTJ/RcSsIpbZ2lansiT32xFiEGVflZyLPuzb/L+JfE9ispxKvA6g3YQBkigubF36oJ tJQh3Db/23jRDTKpkf2xFKivQqUo9lNRCrMkTeKliI2Si0RZU63i1iBRpKVchPOCMeV7 o2ajIr7IRYhX+OFXZD1oAI0PH1oztqDkwW+ms0vJTTe6ItZAE2KYMcEAPnwHVPzEF6QL HN2jokieW3bbqEbTj+HlGNN000rxl1kgK3p4euSJpWdzAco968g1HQ1zdS4oVEtkT613 EBgw== X-Forwarded-Encrypted: i=1; AHgh+RoK6c1khB4SWmMli5maEF9ENu1esUK4lmEjwMQ6WYEqxsFMbK4d/+ghFkJzbOQcMffA8WDt8aCXmVYSEC8=@vger.kernel.org X-Gm-Message-State: AOJu0YyQxM0jSiVQ/yNjyIHKre4yDie1FefFlVjotqLTPjZruwTbpHat Y366AR5p3tBpUikd0Gx+Bz5ek3Dhhn0St2lVAyIZuX2k3ITw5B70wTyO X-Gm-Gg: AR+sD12RYWCP7p4J4PCVa+RQko3YEHrp9ckrlO0tJCUiEjgVUDymt1x0Scus5sNfIyl M23Em9fBmiGVfMrCnhsKGzDXSpgHWEsvkyOAdj/onRL2TbU9Z4Pl0LYfu9tVsF0URXURUacA18w jBSokA2Gp6rcieFIRdohTQ5o4hJ2wkIfZOheyXIrFtLeYG1xW5TKXZs1kl2xjDc7xLUjUXdWUwp k79GKkKXLiEnzxTNWnwQvscqZRtoYCS5WjtuVE73glKgKMDm+Me8dEaa1qR5/Uu2NLrSColf3yO XYaVVIZdbGRcmrks5PMraZmzx43+ch/i6bcAjIaCdni4tWG0QpZiiTMceSMJHmC970XkSJ1p1eo gsJqpubL33vAn402EgkV8+FyraIWk9iYbPUehI8Ef98jpL3+hoAwVxU4RKFtCwBhn6jK+UihVmf PrZp6dSu7WiVyvAFQJUpgbewjmrqX/t2cO9NIDGxWDY5OoxG465S1CKR8= X-Received: by 2002:a17:902:f54f:b0:2ca:f40a:be76 with SMTP id d9443c01a7336-2d015d94cb0mr62989015ad.36.1785319624787; Wed, 29 Jul 2026 03:07:04 -0700 (PDT) Received: from localhost ([172.216.252.23]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022bf39b5sm8827915ad.57.2026.07.29.03.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 03:07:04 -0700 (PDT) Date: Wed, 29 Jul 2026 13:06:58 +0300 From: Dan Carpenter To: "Holalu Yogendra, Niranjan" Cc: "lkp@intel.com" , "oe-kbuild-all@lists.linux.dev" , "linux-kernel@vger.kernel.org" , Mark Brown , Pierre-Louis Bossart , "oe-kbuild@lists.linux.dev" Subject: Re: sound/soc/codecs/tac5xx2-sdw.c:984 tac5xx2_jack_init() warn: missing error code 'ret' Message-ID: References: <202607291308.8OeeiyIv-lkp@intel.com> <8a416f4caf9d41168a38e04140486aef@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a416f4caf9d41168a38e04140486aef@ti.com> On Wed, Jul 29, 2026 at 09:56:57AM +0000, Holalu Yogendra, Niranjan wrote: > > On 11:16-20260729, Dan Carpenter wrote: > > Subject: sound/soc/codecs/tac5xx2-sdw.c:984 tac5xx2_jack_init() warn: missing error code 'ret's > > > > smatch warnings: > > sound/soc/codecs/tac5xx2-sdw.c:984 tac5xx2_jack_init() warn: missing error > > code 'ret' > > > > vim +/ret +984 sound/soc/codecs/tac5xx2-sdw.c > > > > 38c89fededd5a9 Niranjan H Y 2026-05-05 979 static int tac5xx2_jack_init(struct tac5xx2_prv *tac_dev) > > 38c89fededd5a9 Niranjan H Y 2026-05-05 980 { > > 38c89fededd5a9 Niranjan H Y 2026-05-05 981 int ret = 0; > > 38c89fededd5a9 Niranjan H Y 2026-05-05 982 > > 38c89fededd5a9 Niranjan H Y 2026-05-05 983 if (!tac_dev->hs_jack) > > 38c89fededd5a9 Niranjan H Y 2026-05-05 @984 goto disable_interrupts; > > > > Is this supposed to be an error path? tac_dev->hs_jack can't be NULL > > in real life. > > We added this as defensive strategy in case someone calls like this > snd_soc_component_set_jack(component, NULL, NULL); Should it return zero or an error code? I feel like it should return an error code since it disables interrupts which pretty much stops the driver. regards, dan carpenter