The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Lai, Yi" <yi1.lai@intel.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 0/3] perf/x86/intel/pt: Fix stop/start with no update
Date: Wed, 29 Jul 2026 21:36:18 +0800	[thread overview]
Message-ID: <amoB0v9X349e7YY0@ly-workstation> (raw)
In-Reply-To: <20260721070254.13557-1-adrian.hunter@intel.com>

On Tue, Jul 21, 2026 at 10:02:51AM +0300, Adrian Hunter wrote:
> Hi
> 
> Here is a fix for Intel PT.
> 
> There are 2 preparatory patches with no functional change intended.
> 
> The fix is to prevent nesting of perf_aux_output_begin() which
> triggers the WARNING in perf_aux_output_begin():
> 
> 	nest = READ_ONCE(rb->aux_nest);
> 	/*
> 	 * Nesting is not supported for AUX area, make sure nested
> 	 * writers are caught early
> 	 */
> 	if (WARN_ON_ONCE(nest))
> 		goto err_put;
> 
> The nesting happens when Intel PT gets throttled.  See the patch for more
> details.
> 
> 
> Adrian Hunter (3):
>       perf/x86/intel/pt: Factor out pt_config_enable()
>       perf/x86/intel/pt: Use bitwise access for PERF_HES_STOPPED
>       perf/x86/intel/pt: Fix stop/start with no update
> 
>  arch/x86/events/intel/pt.c | 96 +++++++++++++++++++++++++++++++---------------
>  1 file changed, 65 insertions(+), 31 deletions(-)
> 
>

Applied this series on top of v7.2-rc5. After forcing perf throttling,
the WARNING in perf_aux_output_begin no longer appears.

Tested-by: Yi Lai <yi1.lai@intel.com>

 
> Regards
> Adrian

      parent reply	other threads:[~2026-07-29 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21  7:02 [PATCH 0/3] perf/x86/intel/pt: Fix stop/start with no update Adrian Hunter
2026-07-21  7:02 ` [PATCH 1/3] perf/x86/intel/pt: Factor out pt_config_enable() Adrian Hunter
2026-07-21  7:02 ` [PATCH 2/3] perf/x86/intel/pt: Use bitwise access for PERF_HES_STOPPED Adrian Hunter
2026-07-21  7:02 ` [PATCH 3/3] perf/x86/intel/pt: Fix stop/start with no update Adrian Hunter
2026-07-29 13:36 ` Lai, Yi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amoB0v9X349e7YY0@ly-workstation \
    --to=yi1.lai@intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox