From: Keir Fraser <keirf@google.com>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: rostedt@goodmis.org, mhiramat@kernel.org,
linux-trace-kernel@vger.kernel.org,
mathieu.desnoyers@efficios.com, kernel-team@android.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ring-buffer: Fix reader page read offset for remote buffers
Date: Wed, 29 Jul 2026 13:43:03 +0000 [thread overview]
Message-ID: <amoDZyrT_Y8PGSO6@google.com> (raw)
In-Reply-To: <20260729133609.4022734-1-vdonnefort@google.com>
On Wed, Jul 29, 2026 at 02:36:09PM +0100, Vincent Donnefort wrote:
> A page swapped in by __rb_get_reader_page_from_remote() retains its
> stale read offset, causing subsequent reads to skip events or read
> past valid data. Fix it.
>
> Fixes: fbd1743ecba1 ("ring-buffer: Add non-consuming read for ring-buffer remotes")
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
Reviewed-by: Keir Fraser <keirf@google.com>
Tested-by: Keir Fraser <keirf@google.com>
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 804ccae694d2..78d3875a47a5 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -5783,6 +5783,7 @@ __rb_get_reader_page_from_remote(struct ring_buffer_per_cpu *cpu_buffer)
>
> cpu_buffer->head_page = new_head;
> cpu_buffer->reader_page = new_reader;
> + cpu_buffer->reader_page->read = 0;
> cpu_buffer->pages = &new_head->list;
> cpu_buffer->read_stamp = new_reader->page->time_stamp;
> cpu_buffer->lost_events = cpu_buffer->meta_page->reader.lost_events;
>
> base-commit: f5098b6bae761e346ebcd9da7f95622c04733cff
> --
> 2.55.0.487.gaf234c4eb3-goog
>
prev parent reply other threads:[~2026-07-29 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 13:36 [PATCH] ring-buffer: Fix reader page read offset for remote buffers Vincent Donnefort
2026-07-29 13:43 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amoDZyrT_Y8PGSO6@google.com \
--to=keirf@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox