From: Frank Li <Frank.li@oss.nxp.com>
To: Koichiro Den <den@valinux.co.jp>
Cc: "Vinod Koul" <vkoul@kernel.org>, "Frank Li" <Frank.Li@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Gustavo Pimentel" <Gustavo.Pimentel@synopsys.com>,
"Kees Cook" <kees@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Christoph Hellwig" <hch@lst.de>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Cai Huoqing" <cai.huoqing@linux.dev>,
"Niklas Cassel" <cassel@kernel.org>,
"Devendra K Verma" <devendra.verma@amd.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 08/24] dmaengine: dw-edma: Prepare LL progress event handling
Date: Wed, 29 Jul 2026 11:04:00 -0500 [thread overview]
Message-ID: <amokcCsQpiHQdOR9@SMW015318> (raw)
In-Reply-To: <20260729143036.3087722-9-den@valinux.co.jp>
On Wed, Jul 29, 2026 at 11:30:20PM +0900, Koichiro Den wrote:
> A later patch records each observed LL event (STOP or PROGRESS) together
> with the LLP sample taken in the same interrupt-handler pass. Serializing
> that capture with a channel restart needs to know whether interrupt status
> is shared per channel or per direction. It also needs a provider operation
> to clear stale LL interrupt status before a channel restart. Add both.
>
> Centralize runtime request updates in dw_edma_set_request(). A later
> patch uses it to cancel a pending LL recheck when STOP or PAUSE changes
> the channel policy. Rename the existing workqueue event bits to
> distinguish them from provider IRQ events.
>
> No functional change.
>
> Signed-off-by: Koichiro Den <den@valinux.co.jp>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Changes in v4:
> - Explain that the LL event and LLP sample are recorded in the same
> interrupt-handler pass. (Frank)
>
> drivers/dma/dw-edma/dw-edma-core.c | 35 ++++++++++++++++-----------
> drivers/dma/dw-edma/dw-edma-core.h | 12 +++++++++
> drivers/dma/dw-edma/dw-edma-v0-core.c | 2 ++
> drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 ++
> 4 files changed, 37 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index c036510dabcb..b84aed59bf77 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
> @@ -30,9 +30,9 @@ struct dw_edma_desc *vd2dw_edma_desc(struct virt_dma_desc *vd)
> return container_of(vd, struct dw_edma_desc, vd);
> }
>
> -enum dw_edma_irq_event {
> - DW_EDMA_IRQ_DONE = BIT(0),
> - DW_EDMA_IRQ_ABORT = BIT(1),
> +enum dw_edma_deferred_event {
> + DW_EDMA_DEFERRED_DONE = BIT(0),
> + DW_EDMA_DEFERRED_ABORT = BIT(1),
> };
>
> static inline
> @@ -73,6 +73,13 @@ static void vchan_free_desc(struct virt_dma_desc *vdesc)
> kfree(vd2dw_edma_desc(vdesc));
> }
>
> +/* Must be called with vc.lock held. */
> +static void
> +dw_edma_set_request(struct dw_edma_chan *chan, enum dw_edma_request request)
> +{
> + chan->request = request;
> +}
> +
> static void dw_hdma_set_callback_result(struct virt_dma_desc *vd,
> enum dmaengine_tx_result result)
> {
> @@ -243,7 +250,7 @@ static void dw_edma_finish_termination(struct dw_edma_chan *chan)
> if (!chan->non_ll && dw_edma_ll_pending(chan))
> dw_edma_core_reset_ll(chan);
>
> - chan->request = EDMA_REQ_NONE;
> + dw_edma_set_request(chan, EDMA_REQ_NONE);
> chan->status = EDMA_ST_IDLE;
> }
>
> @@ -360,7 +367,7 @@ static int dw_edma_device_pause(struct dma_chan *dchan)
> else if (chan->request != EDMA_REQ_NONE)
> err = -EPERM;
> else
> - chan->request = EDMA_REQ_PAUSE;
> + dw_edma_set_request(chan, EDMA_REQ_PAUSE);
>
> return err;
> }
> @@ -410,10 +417,10 @@ static int dw_edma_device_terminate_all(struct dma_chan *dchan)
> } else if (chan->request > EDMA_REQ_PAUSE) {
> err = -EPERM;
> } else {
> - chan->request = EDMA_REQ_STOP;
> + dw_edma_set_request(chan, EDMA_REQ_STOP);
> }
> if (chan->status == EDMA_ST_IDLE)
> - chan->request = EDMA_REQ_NONE;
> + dw_edma_set_request(chan, EDMA_REQ_NONE);
>
> return err;
> }
> @@ -724,7 +731,7 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
> }
>
> if (chan->request == EDMA_REQ_PAUSE) {
> - chan->request = EDMA_REQ_NONE;
> + dw_edma_set_request(chan, EDMA_REQ_NONE);
> chan->status = EDMA_ST_PAUSE;
> break;
> }
> @@ -764,7 +771,7 @@ static void dw_edma_abort_interrupt(struct dw_edma_chan *chan)
> }
> if (!chan->non_ll)
> dw_edma_core_reset_ll(chan);
> - chan->request = EDMA_REQ_NONE;
> + dw_edma_set_request(chan, EDMA_REQ_NONE);
> chan->status = EDMA_ST_IDLE;
> spin_unlock_irqrestore(&chan->vc.lock, flags);
> }
> @@ -778,15 +785,15 @@ static void dw_edma_irq_work(struct work_struct *work)
> do {
> events = atomic_xchg(&chan->irq_pending, 0);
>
> - if (events & DW_EDMA_IRQ_DONE)
> + if (events & DW_EDMA_DEFERRED_DONE)
> dw_edma_done_interrupt(chan);
> - if (events & DW_EDMA_IRQ_ABORT)
> + if (events & DW_EDMA_DEFERRED_ABORT)
> dw_edma_abort_interrupt(chan);
> } while (atomic_read(&chan->irq_pending));
> }
>
> static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
> - enum dw_edma_irq_event event)
> + enum dw_edma_deferred_event event)
> {
> atomic_or(event, &chan->irq_pending);
> queue_work(chan->dw->wq, &chan->irq_work);
> @@ -794,12 +801,12 @@ static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
>
> static void dw_edma_done_interrupt_deferred(struct dw_edma_chan *chan)
> {
> - dw_edma_queue_irq_work(chan, DW_EDMA_IRQ_DONE);
> + dw_edma_queue_irq_work(chan, DW_EDMA_DEFERRED_DONE);
> }
>
> static void dw_edma_abort_interrupt_deferred(struct dw_edma_chan *chan)
> {
> - dw_edma_queue_irq_work(chan, DW_EDMA_IRQ_ABORT);
> + dw_edma_queue_irq_work(chan, DW_EDMA_DEFERRED_ABORT);
> }
>
> static void dw_edma_emul_irq_ack(struct irq_data *d)
> diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
> index 761a5ab4bbb5..95bd4bf47ea2 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.h
> +++ b/drivers/dma/dw-edma/dw-edma-core.h
> @@ -41,6 +41,11 @@ enum dw_edma_xfer_type {
> EDMA_XFER_INTERLEAVED
> };
>
> +enum dw_edma_event_scope {
> + DW_EDMA_EVENT_PER_CHAN,
> + DW_EDMA_EVENT_PER_DIR,
> +};
> +
> struct dw_edma_chan;
> struct dw_edma_chunk;
>
> @@ -155,6 +160,7 @@ struct dw_edma_core_ops {
> int (*ch_quiesce)(struct dw_edma_chan *chan);
> u16 (*ch_count)(struct dw_edma *dw, enum dw_edma_dir dir);
> enum dma_status (*ch_status)(struct dw_edma_chan *chan);
> + enum dw_edma_event_scope event_scope;
> irqreturn_t (*handle_int)(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
> dw_edma_handler_t done, dw_edma_handler_t abort);
> void (*non_ll_start)(struct dw_edma_chan *chan, struct dw_edma_burst *child);
> @@ -163,6 +169,7 @@ struct dw_edma_core_ops {
> void (*ll_link)(struct dw_edma_chan *chan, u32 idx, bool cb, u64 addr);
> void (*ll_clear)(struct dw_edma_chan *chan, u32 idx);
> int (*ll_cur_idx)(struct dw_edma_chan *chan);
> + void (*ll_irq_clear)(struct dw_edma_chan *chan);
> void (*ch_doorbell)(struct dw_edma_chan *chan);
> void (*ch_enable)(struct dw_edma_chan *chan);
> void (*ch_config)(struct dw_edma_chan *chan);
> @@ -284,6 +291,11 @@ static inline void dw_edma_core_ll_clear(struct dw_edma_chan *chan, u32 idx)
> chan->dw->core->ll_clear(chan, idx);
> }
>
> +static inline void dw_edma_core_ll_irq_clear(struct dw_edma_chan *chan)
> +{
> + chan->dw->core->ll_irq_clear(chan);
> +}
> +
> static inline void dw_edma_core_ch_doorbell(struct dw_edma_chan *chan)
> {
> chan->dw->core->ch_doorbell(chan);
> diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
> index 7ca4b6823ece..27c57f755d83 100644
> --- a/drivers/dma/dw-edma/dw-edma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
> @@ -680,11 +680,13 @@ static const struct dw_edma_core_ops dw_edma_v0_core = {
> .ch_quiesce = dw_edma_v0_core_ch_quiesce,
> .ch_count = dw_edma_v0_core_ch_count,
> .ch_status = dw_edma_v0_core_ch_status,
> + .event_scope = DW_EDMA_EVENT_PER_DIR,
> .handle_int = dw_edma_v0_core_handle_int,
> .ll_data = dw_edma_v0_core_ll_data,
> .ll_link = dw_edma_v0_core_ll_link,
> .ll_clear = dw_edma_v0_core_ll_clear,
> .ll_cur_idx = dw_edma_v0_core_ll_cur_idx,
> + .ll_irq_clear = dw_edma_v0_core_clear_done_int,
> .ch_doorbell = dw_edma_v0_core_ch_doorbell,
> .ch_enable = dw_edma_v0_core_ch_enable,
> .ch_config = dw_edma_v0_core_ch_config,
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> index 67a3a7778280..c8b9f6c42494 100644
> --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> @@ -435,12 +435,14 @@ static const struct dw_edma_core_ops dw_hdma_v0_core = {
> .ch_quiesce = dw_hdma_v0_core_ch_quiesce,
> .ch_count = dw_hdma_v0_core_ch_count,
> .ch_status = dw_hdma_v0_core_ch_status,
> + .event_scope = DW_EDMA_EVENT_PER_CHAN,
> .handle_int = dw_hdma_v0_core_handle_int,
> .non_ll_start = dw_hdma_v0_core_non_ll_start,
> .ll_data = dw_hdma_v0_core_ll_data,
> .ll_link = dw_hdma_v0_core_ll_link,
> .ll_clear = dw_hdma_v0_core_ll_clear,
> .ll_cur_idx = dw_hdma_v0_core_ll_cur_idx,
> + .ll_irq_clear = dw_hdma_v0_core_clear_done_int,
> .ch_doorbell = dw_hdma_v0_core_ch_doorbell,
> .ch_enable = dw_hdma_v0_core_ch_enable,
> .ch_config = dw_hdma_v0_core_ch_config,
> --
> 2.51.0
>
next prev parent reply other threads:[~2026-07-29 16:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 14:30 [PATCH v4 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
2026-07-29 14:30 ` [PATCH v4 01/24] dmaengine: dw-edma: Add dw_edma_core_ll_cur_idx() to get current LL entry index Koichiro Den
2026-07-29 14:30 ` [PATCH v4 02/24] dmaengine: dw-edma: Add dw_edma_core_ll_clear() to clear LL control-word Koichiro Den
2026-07-29 14:30 ` [PATCH v4 03/24] dmaengine: dw-edma: Factor out linked-list transfer start Koichiro Den
2026-07-29 14:30 ` [PATCH v4 04/24] dmaengine: dw-edma: Make DMA link list work as a circular buffer Koichiro Den
2026-07-29 14:30 ` [PATCH v4 05/24] dmaengine: dw-edma: Move callback result helper before LL helpers Koichiro Den
2026-07-29 14:30 ` [PATCH v4 06/24] dmaengine: dw-edma: Dispatch DONE interrupts by channel request Koichiro Den
2026-07-29 14:30 ` [PATCH v4 07/24] dmaengine: dw-edma: Centralize LL doorbell decisions Koichiro Den
2026-07-29 16:01 ` Frank Li
2026-07-29 14:30 ` [PATCH v4 08/24] dmaengine: dw-edma: Prepare LL progress event handling Koichiro Den
2026-07-29 16:04 ` Frank Li [this message]
2026-07-29 16:47 ` Frank Li
2026-07-29 14:30 ` [PATCH v4 09/24] dmaengine: dw-edma: Prepare deferred IRQ reporting for LL events Koichiro Den
2026-07-29 14:30 ` [PATCH v4 10/24] dmaengine: dw-edma: Prepare LL kicks for event serialization Koichiro Den
2026-07-29 16:13 ` Frank Li
2026-07-29 14:30 ` [PATCH v4 11/24] dmaengine: dw-edma: Serialize LL event capture with channel kicks Koichiro Den
2026-07-29 14:30 ` [PATCH v4 12/24] dmaengine: dw-edma: Keep channels stopped while ABORT is pending Koichiro Den
2026-07-29 14:30 ` [PATCH v4 13/24] dmaengine: dw-edma: Reclaim issued descriptors from IRQ-paired LL progress Koichiro Den
2026-07-29 14:30 ` [PATCH v4 14/24] dmaengine: dw-edma: Add LL interrupt placement policy Koichiro Den
2026-07-29 14:30 ` [PATCH v4 15/24] dmaengine: dw-edma: Recheck stopped LL channels before restart Koichiro Den
2026-07-29 14:30 ` [PATCH v4 16/24] dmaengine: dw-edma: Use HDMA watermarks as progress events Koichiro Den
2026-07-29 14:30 ` [PATCH v4 17/24] dmaengine: dw-edma: Recover stopped channels from tx_status() Koichiro Den
2026-07-29 14:30 ` [PATCH v4 18/24] dmaengine: dw-edma: Make the LL ring reset a full channel resync Koichiro Den
2026-07-29 14:30 ` [PATCH v4 19/24] dmaengine: dw-edma: Drain LL entries for STOP and PAUSE Koichiro Den
2026-07-29 14:30 ` [PATCH v4 20/24] dmaengine: dw-edma: Dynamically append requests while running Koichiro Den
2026-07-29 14:30 ` [PATCH v4 21/24] dmaengine: dw-edma: Add engine reset and enable operations Koichiro Den
2026-07-29 14:30 ` [PATCH v4 22/24] dmaengine: dw-edma: Add engine recovery infrastructure Koichiro Den
2026-07-29 14:30 ` [PATCH v4 23/24] dmaengine: dw-edma: Detect and recover a stalled eDMA engine Koichiro Den
2026-07-29 14:30 ` [PATCH v4 24/24] dmaengine: dw-edma: Add trace support Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amokcCsQpiHQdOR9@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=bhelgaas@google.com \
--cc=cai.huoqing@linux.dev \
--cc=cassel@kernel.org \
--cc=den@valinux.co.jp \
--cc=devendra.verma@amd.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=hch@lst.de \
--cc=kees@kernel.org \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox