From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92C8F39DBCB for ; Thu, 30 Jul 2026 07:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785396914; cv=none; b=Q2ky+fEr6/aW5O7H2v6pARBc+w33VrZtmAMWKF++htgjaDdi3+cHAdt3qKvDS8BO68niFsJyv+uBGaAco8A1hqOOJlXUzxSrsTb8ENwJsO/TQzgYN8WhOYXUPe77Jpd83Db9BXSi/trjexxmgR+Ph00jFvGDVw/5pYsFFDF2ooc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785396914; c=relaxed/simple; bh=wLc4k1j1fXxZ0smM+8WIf1wx40c+WnorH2aWDTqpEfI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M/9RChaQWiPTllHxjaWnVvXTGoIf5XB26Vfn8VXQOQhdo0CIftu2CdXfQRqjDWvSkVBm4cQKB8FWc3hRrGpJ+l5gKBMqOawrOWUsHpdwWRUQ7szBd8NzyxMicQL4lmD/JYmHTtlDrXEu6lWHm5JHJmGHeUoA+F4c0C1x/vTepac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jxEyzfN7; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jxEyzfN7" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-382ef647e20so1839869a91.1 for ; Thu, 30 Jul 2026 00:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1785396911; x=1786001711; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=vSElZmcx3GZLBTKn99h/682uKRLjwH085BtIe9qww84=; b=jxEyzfN7LPB2vOdGGOuNzeNZy+wWnOGS2FLMiJ/MW359YQJC7h9/jE+8nHbnMfxnq1 OrmspWbG3o0j3sZDfiqp7LbAzjB38k8dhEiAxCp1/fl7oWwNM4Ub5n+LcA0B9bwnNckN aTDMpIufMofh/C07vC9xEhS6N/Id+DU/0ro7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785396911; x=1786001711; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vSElZmcx3GZLBTKn99h/682uKRLjwH085BtIe9qww84=; b=io26akRtzb4A4/Rvlh4wASimf/t3AzhQnJZE133D4YugA+cvsr88piN01K3G/7y5tQ rdtepnEijlf75agW+JW7jxeuqL7mEtRu21hlLngGBrlXb1/BSJpAH0sVGpnI34RVbf9X 5FsnSvifCRsOHQZdWTyNiOtIgUKBlDfedZlQEOb6KsuKTqbS0mEOFyNw5mGJ646AeTOd XgdPthErPDbRnxmcroRTSofO6y+K7VlgRPFLPPSMDPF5dY/BWZxJRq0qPyEmmGFfFCpw skNw/oGMBvif+DvbVhToB2nztQc2gf2pG+k2dDezBxai+gTEA2zGkDSQ3SP//QoVrs4z IcOQ== X-Forwarded-Encrypted: i=1; AHgh+RoOiTIDOx1bn5+TVVyVPA8oHo2QjuNKGU4S09X66pyfyehfpiQFSaGDo8tFU1LPIi4QtjWwFu3I9A2lnro=@vger.kernel.org X-Gm-Message-State: AOJu0YybpbML0YqHCOxmdsdDsLXTZ89Fka8tcck6caaNGz3FE4TRqCwv wC5wmkslWkYGo84W14UmkERSfvUhPJmEUtqYRUPgEuIixYO6pmvC/RESDEW7eOkb6g== X-Gm-Gg: AR+sD11Cf3Y+ugMtv11u9WoOR37feBBeo00q4bdoZuQTsZNuEhpfvzJbMDI9OpPwIwf FH6KAKipGRDkoXkajiM96dYP4JpH6RZhU0+AdZ4gU04NYiJw2ecLFreeDUT8gp3ccX9jQSScMDX T05akzRHSDx4kJA2R3MX/04Fpwp9jeT2k9YECJ2P2Au5HGTJyuYOF0SXKFNgAWnCwrxwxBJH2gw 8FkUi8vJ0SfovNJshgzbCSqMirMau0jq1eQCaiGAarY0znItpfCpCEyRdTcAmDLA96kTFrbxIvf 0BMEJ66Zhlybwwe+sYt6AHCxVT9D6pVN/rWTaASQlhfo/rG4GE9FwPyMG0WohcMdsyoLnzMgwGc tG0bdNzpv0pqaOYnTmAfxgbDRWcKUjYKwr24ByNUb/PoG0JKuEeHdR8D1yXG1+V14M31D5+0LU0 keePSwvW6AFPj8R04OuvgSSLwBsjTuc1qZg+RfgS6yijTJB/V/QYACXnfPQ9fNdlBxnIhGaA8dI fypqR6TUHZdHPW3pbp9NGtpUc66 X-Received: by 2002:a17:90b:17c4:b0:381:9028:5945 with SMTP id 98e67ed59e1d1-38f9bd86f5emr1327560a91.14.1785396910872; Thu, 30 Jul 2026 00:35:10 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:fd2f:da94:c3be:e16c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f9b770e33sm589659a91.15.2026.07.30.00.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 00:35:09 -0700 (PDT) Date: Thu, 30 Jul 2026 16:35:05 +0900 From: Sergey Senozhatsky To: Haoqin Huang Cc: Minchan Kim , Sergey Senozhatsky , Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: Re: [PATCH v4 3/4] zram: validate parameters in each backend's setup_params Message-ID: References: <20260730025240.17724-1-haoqinhuang7@gmail.com> <20260730060133.80233-1-haoqinhuang7@gmail.com> <20260730060133.80233-4-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260730060133.80233-4-haoqinhuang7@gmail.com> On (26/07/30 14:01), Haoqin Huang wrote: > --- a/drivers/block/zram/backend_lz4.c > +++ b/drivers/block/zram/backend_lz4.c > @@ -30,6 +30,11 @@ static int lz4_setup_params(struct zcomp_params *params) > > if (params->level == ZCOMP_PARAM_NOT_SET) > params->level = LZ4_ACCELERATION_DEFAULT; > + else if (params->level < LZ4_ACCELERATION_DEFAULT || > + params->level > U16_MAX) { Maybe there should be no upper bound check? It kind of seems to me that lz4 doesn't define any clear upper bound. Or am I missing something?