From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 634623BE174 for ; Thu, 30 Jul 2026 07:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785394848; cv=none; b=UI6eEGgVhbkqv5IZ9/G6J11i6ESVnfUjTCumLEWFqAeXPoCL2SbYgngJWfazeLYzFCFzelcKzztHGwHpNQdpXj3Ps7m0DefoW0gGm6rzpT7F9nR0ibnVzRgDNlaMdA3iG/gbqCoYp4tahVyVi+U0pGEvcZ1CF8SECtUpOU4vtoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785394848; c=relaxed/simple; bh=FLpkfaJDuEeqIwYpqo/shd11sSgL8uzmgI+MKV7dKIA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tpTsId5unisueUyfYYG/SGexSS9Z8YeiFURP1Ig6gSafYaiB4P974SZ/V7EUZoVrYcJOU9XA/daamhmu7TjlmLTqr6ILOM1UE4wkzrg8HhkMvD9nseF2YbEO25Py5kVSkKx9N+O56g+t6bgKAWPjhmrAomtKgJsIjV8gbKzmwB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=HTntrq2J; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HTntrq2J" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ce98cb8165so4789635ad.1 for ; Thu, 30 Jul 2026 00:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1785394827; x=1785999627; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kmQwbnowmxojZsKZZE98MtKAi+i/Wx/9r/LQ4dTILJQ=; b=HTntrq2Ju/DAQm5QLIyXzjHAgUG6qobvPDuBurDl59qz2QiEgqeT9Mxv+ETZuy5j1E mzBSO+ExSbaphM7cveeqeScweHcSJDPtfx/F3z2lugc7yJts3E6ldmzxFPA4YhrcZiFz HuiHp/1++5ZG6dKtZDQBRBNNbPuu1A1AWBLw4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785394827; x=1785999627; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kmQwbnowmxojZsKZZE98MtKAi+i/Wx/9r/LQ4dTILJQ=; b=hXbeEUVhwYteRpo1c6/DM3lqW3YzI/uhuN7YS1g+kN1BnNi4DFSHfaPV/Q81hTvj6d hRVliiO9X3ji1X4RWLc6Pa+jGbh3VH6Mm3UN5UBVKHWBP/AkaK3DaZc1i8+MPsn1BPVv Js4L1kidY8oyWWIWwdSU/XcZClfHH8SkSkJE0x75rB3kjBqNA5G7rgKd003T673pAJqy vsGWZXMVWzOqCSE3vJZWi/p5dDL6K0DK7h/URZMFo9awoWIT0rmXhtVbdl4jRnq0hWHT K/ss6oJkBC5SoBuySlifM97AyAqs77HBSWY1VhHW71fiaL/SsCcrUjK8oo1KUO42/YG1 7Sdg== X-Forwarded-Encrypted: i=1; AHgh+Rr8F8+MIiJOsH8s71Byn8WzyvoC+xUiFo0wPbeuvUCRgJhC2jJetWWj9nXfDs2jk40sHJ6kbA6amGvGBfk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5Dl3rCh+la+lPaXcDB5JwXMFq9BslaJbNSp8MP8RoWZ8gW8sF n5OYrYEfKs2O+31NZUxDXsigc17GH6ncSZ2dKUUhCCkA+ccN+KePcHs3+4DiZESyxg== X-Gm-Gg: AR+sD13UGG96V0x5+hrGfLt5Gn8hHi8lcH2B2lNLykcLsLvwnT0bvNFjb6eCEJ16WDH UONtcTGXJ6lfpeqPiefkp9mq9M1PNXbdCmI3Y/QEUgCMBKh7ObQ1Ryzif+5aMTlgRs24emZkUF9 vcExXn/JatpXuQqn9w27mbrzb5XBxYNG4CjhbH0r+H4UmfUyKpdUAlip390C+aH5DvqThhiQRxS Oi5Q5cpTnwULTPhaTlzooNMP68tmofZcC/RP/h+VbL3SD+QNu1BVK08gKm0q2ygi23uFK6WqPLb 7NFVexMYF8Sw9TsAqLDSddxkuUKA+Xo+DDZyPlcQFsdfg3uZaiBjOGuxWdxndCF6LRqSsXaxP9+ IaeOjF49x6SteQQwo85UM3J9yrW2VAzwJ1bzlpz/y3A5f79S40J1Ds+SRJjsCCAFB3FWN9cDR5r kY/YWTChDn9xHoUTsT04E93rOXCTGkrkczABwYaKuxZ+8NHofbMYmLWQNy+Z9xx1VuK2BMdcVDe whaD6zq1pPXSND77XzzxS8X5y1blQ== X-Received: by 2002:a17:902:e94d:b0:2ca:53f7:3c69 with SMTP id d9443c01a7336-2d036eaeeaemr11751295ad.9.1785394827512; Thu, 30 Jul 2026 00:00:27 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:fd2f:da94:c3be:e16c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022c1b529sm21411665ad.69.2026.07.30.00.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 00:00:27 -0700 (PDT) Date: Thu, 30 Jul 2026 16:00:18 +0900 From: Sergey Senozhatsky To: Haoqin Huang Cc: Minchan Kim , Sergey Senozhatsky , Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: Re: [PATCH v4 2/4] zram: reject zero-size dictionary Message-ID: References: <20260730025240.17724-1-haoqinhuang7@gmail.com> <20260730060133.80233-1-haoqinhuang7@gmail.com> <20260730060133.80233-3-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260730060133.80233-3-haoqinhuang7@gmail.com> On (26/07/30 14:01), Haoqin Huang wrote: > kernel_read_file_from_path() already rejects empty files (i_size <= 0) > and returns -EINVAL, but the current implementation only checks for > sz < 0 without logging any information. Use sz <= 0 to cover the > zero-size case and print an error message if dictionary loading fails. > > Signed-off-by: Haoqin Huang > Signed-off-by: Rongwei Wang > --- > drivers/block/zram/zram_drv.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index ace65c586072..0223fd83bbba 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -1709,8 +1709,11 @@ static int comp_params_store(struct zram *zram, u32 prio, s32 level, > INT_MAX, > NULL, > READING_POLICY); > - if (sz < 0) > + if (sz <= 0) { > + pr_err("zram: failed to load dictionary %s (err=%zd)\n", This leads to a double-prefixed line "zram: zram: " as zram already defines pr_fmt().