From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linkmauve.fr (82-65-109-163.subs.proxad.net [82.65.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2BEE328267 for ; Thu, 30 Jul 2026 06:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.65.109.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391482; cv=none; b=kRr0y/bX6gEI5zy27YiEafJwYXIU/h6zONVlA1/dHL7vlNhS4PmZF3QZPpKtCCfxaS/hvDgxaMNdA1ZEZnqFJjs5p10zLD6tGrzJhKAGW/Ps7J7JTjX8VLhO7A1Cmv2AgH31Z4x1M88hsbdSb4+kaA7xoqI7rO6WvQwX5q0tQWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391482; c=relaxed/simple; bh=QbIl9A2e5Z7OtCvS/91KDRwrds4sgaDrYJ55fCoZnE0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OtHK1Uvf0V+yLMRxahyXAHMMVdsc6I2FmjPXelqKdcIL9GBOUa6jO9J+oPwb5VFu0ergAZnCeZPoOy2brXeXinDHqhhfePjEPP2Q3vq/Hqk0+mVmOrdnCT8IbMDngFj9+fopXvkp2lulkmp+IDTJsog/GGKaCahWvo55nxL8nlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr; spf=pass smtp.mailfrom=linkmauve.fr; arc=none smtp.client-ip=82.65.109.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linkmauve.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linkmauve.fr Received: by linkmauve.fr (Postfix, from userid 1000) id 2546870992C0; Thu, 30 Jul 2026 08:04:38 +0200 (CEST) Date: Thu, 30 Jul 2026 08:04:38 +0200 From: Link Mauve To: "Christophe Leroy (CS GROUP)" Cc: Link Mauve , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Madhavan Srinivasan , techflashYT , Ash Logan , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Michael Ellerman , Nicholas Piggin Subject: Re: [PATCH 0/2] powerpc/sstep: Fix compilation on 32-bit PowerPC Message-ID: References: <20260729204958.755143-1-linkmauve@linkmauve.fr> <5c140099-4448-4091-979a-6f6fe7d92ce8@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5c140099-4448-4091-979a-6f6fe7d92ce8@kernel.org> Jabber-ID: linkmauve@linkmauve.fr On Thu, Jul 30, 2026 at 07:51:40AM +0200, Christophe Leroy (CS GROUP) wrote: > > > Le 29/07/2026 à 22:49, Link Mauve a écrit : > > Two local variables were only set but never read on 32-bit PowerPC, > > which causes an error during compilation. > > Are those errors new ? This series and the one from yesterday on ppc64, I > have the feeling that the code is not new. Has anything changed in the > building flags or does this pops up with recent versions of GCC ? If it is > the case it is worth saying it in the commit messages in order to clarify > the reason for the fix. I think they started happening when I enabled Rust support, but I’ve been doing that for quite a while and I don’t know if the two are linked, and when I disable CONFIG_RUST it’s still erroring without this series. I’m pretty sure someone has built the kernel on 32-bit PowerPC since 650b55b707fdfa764e9f2b81314d3eb4216fb962 or 930d6288a26787d2e7f633705434171a506db9c5, both commits introducing the two variables which are then never used. I couldn’t follow the maze of Makefile enough to determine where -Werror=unused-but-set-variable is set, if this is specific to recent versions of gcc or not, if this is enabled by a different CONFIG_ option, if this could be disabled already. But I believe fixing this issue is good anyway, the compiler is right that without __powerpc64__ these two variables are never used. > > > > > This series first makes the 64-bit guards consistent by converting all > > uses of CONFIG_PPC64 to use __powerpc64__ instead, and then guard the > > two variables rc and suffix behind __powerpc64__ checks. > > > > Link Mauve (2): > > powerpc/sstep: Consistently use one define to check arch bit width > > powerpc/sstep: Don’t define variables we won’t be using > > > > arch/powerpc/lib/sstep.c | 26 ++++++++++++++++---------- > > 1 file changed, 16 insertions(+), 10 deletions(-) > > > > > > base-commit: 78bc8af4affb9a732504eb22eeac7d1e50883853 > -- Link Mauve