From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 379F73ACEE3 for ; Thu, 30 Jul 2026 08:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785400833; cv=none; b=ULoijjkXXgybgQN93UvPBAF6vWWGXNQGltkaGbqrJZsgFBq+LIQRP0BEkWzTf93KQfmB8XInFTCsmemeAl6XhGXp+nHWWp2aDeBnHgfWEK0lQkVe6ZSqKfvzhm0IztbKXbzVj69P7EO9fOzYHVxQDcFNYy27Xp7cSefq1bQXEkM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785400833; c=relaxed/simple; bh=KgwJ16h6MigNlTpxpNbRrE+4Cg72XgyuKKOqp2PMaeY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wz8i/9FXlF4DQckqCfwYXz6ZVgLkIgcozRbXO4tY3gLMtVDixiDI8CQh7tH/ol7XiStvUh+LLuJoQ9PAXjjTZ4WtbnE7zec0MUFWihfCFK5WqFLNVC4hUjB6sfqseqgWi7Se1Vy5lFujzUHawOTXt06QfTWd9sNmGHGrHEJfalo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Am3w9iBb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Am3w9iBb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 499731F000E9; Thu, 30 Jul 2026 08:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785400831; bh=55G67AD+bUlnQtHL1MJavniTLpGKt7vPc4y+cPkS8Qo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Am3w9iBbksLZSYkGW+BC2SXWaPrsXS+3w0PfbAUiFLEio7Ojf0Mp6S5i+8TfgZJQ7 P0oEDWw3vSLdXYio4+t/tv5rqP3m3i6YA0+nbhUwJCvoZ2Aag+k6zPehyBKcXT7ir5 l7Egai/6QWPr4er0MIKnLmzK/p7t/cVDFc5YJWjzgGfGK6Tpuzmfkyug6zxOkJatZ6 nyjomqeZ/UizlLOFCXdwnG+WkTF7Wn8jaz4YvGRtw2fU+vEEjVRZ97lQiQn8+BcND8 W1BuAwvX2mVAHr5hud0roY3B9Tm1f2aipjudB63eKi0xt+KNbdCbNwjboFOq/scBOu rkkhhxo0776pA== Date: Thu, 30 Jul 2026 11:40:23 +0300 From: Mike Rapoport To: Pratyush Yadav Cc: Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , Jork Loeser , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 01/22] kho: generalize radix tree APIs Message-ID: References: <20260729145610.2827231-1-pratyush@kernel.org> <20260729145610.2827231-2-pratyush@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729145610.2827231-2-pratyush@kernel.org> On Wed, Jul 29, 2026 at 04:55:46PM +0200, Pratyush Yadav wrote: > From: "Pratyush Yadav (Google)" > > Generalize the APIs by taking the key directly and doing the encoding at > the callers. Rename the functions to kho_radix_add_key() and > kho_radix_del_key(). In practice, this removes a line each from the > functions and moves the encoding function call to the callers. > Similarly, update kho_radix_tree_walk_callback_t to take the key > directly. > > diff --git a/include/linux/kho_radix_tree.h b/include/linux/kho_radix_tree.h > index 84e918b96e53..f368f3b9f923 100644 > --- a/include/linux/kho_radix_tree.h > +++ b/include/linux/kho_radix_tree.h > @@ -34,30 +34,24 @@ struct kho_radix_tree { > struct mutex lock; /* protects the tree's structure and root pointer */ > }; sashiko: This isn't a bug, but did you miss updating the kerneldoc for struct kho_radix_tree? And indeed "DOC: Kexec Handover Radix Tree" talks about addresses and orders. -- Sincerely yours, Mike.