From: Aurelien Jarno <aurelien@aurel32.net>
To: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>,
Paul Walmsley <pjw@kernel.org>
Cc: linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
"open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v2 1/4] riscv: defconfig: enable RFKILL and RFKILL_GPIO
Date: Thu, 30 Jul 2026 12:29:45 +0200 [thread overview]
Message-ID: <amsnmUMKXDWLFJio@aurel32.net> (raw)
In-Reply-To: <CAEev2e-_jW8OYoJofrT3VATyZg87DHUEM1qHNpdnPAJ-SwOjcw@mail.gmail.com>
Hi, Anirudh,
On 2026-07-29 12:30, Anirudh Srinivasan wrote:
> Hi Aurelien,
>
> On Wed, Jul 29, 2026 at 12:24 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
> >
> > The SpacemiT K3 Pico-ITX requires RFKILL_GPIO to enable bluetooth and
> > wlan.
> >
> > Tested-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> > arch/riscv/configs/defconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> > index 74ba5acc12a40..8668aa31e79aa 100644
> > --- a/arch/riscv/configs/defconfig
> > +++ b/arch/riscv/configs/defconfig
> > @@ -99,6 +99,8 @@ CONFIG_NET_CLS_CGROUP=m
> > CONFIG_NETLINK_DIAG=y
> > CONFIG_CGROUP_NET_PRIO=y
> > CONFIG_CAN=m
> > +CONFIG_RFKILL=m
> > +CONFIG_RFKILL_GPIO=m
> > CONFIG_NET_9P=y
> > CONFIG_NET_9P_VIRTIO=y
> > CONFIG_PCI=y
>
> The riscv defconfig doesn't have CONFIG_RTW89=m and
> CONFIG_RTW89_8852BE in it. Do we need to add it?
That's a good point, not sure to which level we need to enable all
modules of supported hardware. I added RFKILL and RFKILL_GPIO as it was
not obvious to me that those need to be enabled to get proper WiFi
support. Also those are tiny drivers compared to the RTW89 driver.
OTOH, I see that this driver is enabled for the loongarch architecture,
so maybe we can do the same for riscv..
Paul, any idea about that, any policy?
> I was testing with a distro defconfig, so didn't need to add it
> manually. I should have realized this sooner.
Yes same, so I also didn't notice.
Regards
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://aurel32.net
next prev parent reply other threads:[~2026-07-30 10:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 17:20 [PATCH v2 0/4] Enable Bluetooth and WiFi rfkill on K3 Pico ITX Aurelien Jarno
2026-07-29 17:20 ` [PATCH v2 1/4] riscv: defconfig: enable RFKILL and RFKILL_GPIO Aurelien Jarno
2026-07-29 17:30 ` Anirudh Srinivasan
2026-07-30 10:29 ` Aurelien Jarno [this message]
2026-07-29 17:20 ` [PATCH v2 2/4] riscv: dts: spacemit: k3: add rfkill node for Bluetooth on Pico-ITX board Aurelien Jarno
2026-07-29 17:20 ` [PATCH v2 3/4] riscv: dts: spacemit: k3: add USB3 B and C controllers for " Aurelien Jarno
[not found] ` <20260729173332.51D661F000E9@smtp.kernel.org>
2026-07-30 10:20 ` Aurelien Jarno
2026-07-29 17:20 ` [PATCH v2 4/4] riscv: dts: spacemit: k3: add rfkill node for WLAN Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amsnmUMKXDWLFJio@aurel32.net \
--to=aurelien@aurel32.net \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=asrinivasan@oss.tenstorrent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox