From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2B844162B for ; Thu, 30 Jul 2026 15:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785424265; cv=none; b=JNrAlvkCDz+sHbHPr2XgY02m1ggJ91eMgjg4ROeWxbZs0IS+LI4c0tiKU0Wwq54UYRN/vIawxvE+vlGCIMtOIajL4XrTrDh6VPjiOy+UZQO4FsZNdz2BU6IOM3fIUxXBH52/dIjv93/IMPNbeAhW8YZn75ngKjAW42uzY9bzVt8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785424265; c=relaxed/simple; bh=xirIpBqCCyBoBBoy/v0IT6Q9Vbwmez8qL3yBMeT7334=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I5wOd7bpF1LL5rF/JX72cma6YHM5WkeOarZ8JUOKOhgHcNFnmPlF6D3l8zEurKCsj779hQwVyE1c/b6/RAk9eDqBLGQ/kwOSJiAm4+WByPgIgkxbjwjX/9eerHMLId2HrvWjYap1s929oIyN8U06qtSSkLFH8bxxFaDPmlS+Fg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gGId40OR; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gGId40OR" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-47c2b362ee2so1868949f8f.1 for ; Thu, 30 Jul 2026 08:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785424256; x=1786029056; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Ur1wZn3EllTmAAL8HehYvjqEjFBHKpODxClktTn6wPw=; b=gGId40OR18EBORvT5/DMAMueZ422PRp6xR4/YgANbgaMMfRZGE77J4uUiNMkw4QOP4 C5pqEcr6UyEIGX5D6FLNYyTO1VFdlTBWqRWTOsTzj2sGoZe4IHZXtfWJ43+JtSKMHdXr kP7MWeNs4G31bcRCajxkm5xNpYpW/flJ010obn6KEBxmsI1cAmHrfsbir20eEgjWYruU 1zg+FAVWJHVj3ZGGGaTYetcHmu8w5wOTcXiIbdhIzw1luKihE3B+UAGydbR9ImVz8yh/ Vf7F3XP+ZSnZ8eL4l2IxzHMY9SCfR0RZMyuELYTIdzPCAEml/FE1DxHWSYChwqDFsSMM Kcjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785424256; x=1786029056; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ur1wZn3EllTmAAL8HehYvjqEjFBHKpODxClktTn6wPw=; b=UZDjkQN79GCb5gcwyCly1RMhfqq9KKQGgej1mgfU4qkH3CF3OprEbXS5J08K+Y6mkP UptjYGiFisRoz6qA8L8b8TwKC0c1Grp1WXcnBrPCP1MQvNUG4gK8MqTuf4vLAK6TgN2t sKGG0+SOo83QD/tcObJWlk5w2WD7tOr1DH8eVfhen4h6OcznhhzLDCMqFf0mrC/MpxN2 smIUNtDhEmNc+YykjT/Aj6EPlkCC5oBY3lvD/3WBVr/LSRBjo/gzr9y5jYMfebXLD8jm JzhC7zDng7xrweztrkvDSbqTiImJt3tecYG+/A1J81AlEV/CHwK5QXwuwwXPfKo/LTRn XUew== X-Forwarded-Encrypted: i=1; AHgh+RoghrYRjeNXubIbaGzDEUCpEjAJBbMjS5Fe26PmPePnrdApmZ3gcy1/P9xCjqNXgZpVm2rYcQNwKrKRUzo=@vger.kernel.org X-Gm-Message-State: AOJu0YzP00sMEgP4K/0l+WX9rzhV9weyaz+vgCimiJzMmD7DT7mNXUEe gJ+KNIjNeQoHpLFmpxOmlSrc7ijJrO5Mbufq/zGvxPzl9YEGz8MvH6Os X-Gm-Gg: AR+sD133LY2zOlJXL9kxeOBkPgPui+kj9t6SQU8LNh5c/q4KsBPQ8/WwIxh9ZR4YIaZ W5EtlDn+FIJVcplQjceSnPY4CkKMZnQ11Efkp0keX/B3AcIZIwHBKFiW1kYsfdsXBw46yOKTCz2 kRqY5VbeM/Z0o008eWWbJWJ1nFympMQoVidjR+mhwxePVNMmOXRSeTerdtyaN5PGjyml8giIKLB 3tYpiJToJHiD8KWlPAIpYtindopZ3aKarn0px2YEl8tSmM4pHJJ7vhagVRaFNsh3vQQobbN/vhl oMZh0rA5jpYvWByG/KI9JEn8mfbXGdr2YRhPnQ0eTwMGJa9jXTxBG5OAz63uB9fsvX5TYnLu0H2 8wzwjpdDSJa11wUrNadIc5xO78nMZaQkSl0TKkNGA2S/MZQjWQnUndmYK/3tfFeFMKtraYPK2Uz w9+uu3Sr/4LbezZYrNQrhvRkRMNE8m0THXOkPx65flsGS93UQkaweJhiyyFeQw5sEBwH0uDJ5dJ bs7qMd2YQAR7/PAkgVuMDHolRcPbFRYLZePyFUo1YusYTjW/v1YX740gzhSaERvTsva X-Received: by 2002:a05:6000:41ce:b0:47f:8f8f:e494 with SMTP id ffacd0b85a97d-47fc80c3328mr4307244f8f.2.1785424255901; Thu, 30 Jul 2026 08:10:55 -0700 (PDT) Received: from fedora-laptop ([172.245.82.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fc892cc3asm7729052f8f.23.2026.07.30.08.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 08:10:55 -0700 (PDT) Date: Thu, 30 Jul 2026 10:10:37 -0500 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] ublk: initialize io_desc on daemon task Message-ID: References: <20260729012951.3744582-1-csander@purestorage.com> <20260729012951.3744582-5-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729012951.3744582-5-csander@purestorage.com> On Tue, Jul 28, 2026 at 07:29:49PM -0600, Caleb Sander Mateos wrote: > ublk_setup_iod() is currently called to populate struct ublksrv_io_desc > on the thread submitting I/O to a ublk device. However, only the ublk > server threads read the io_descs. This basically guarantees a cache miss > on both threads for each ublk I/O. There's really no need to initialize > the io_descs on the submitting thread. Move the ublk_setup_iod() call to > ublk_dispatch_req() (for non-UBLK_F_BATCH_IO) and > __ublk_batch_prep_dispatch() (for UBLK_F_BATCH_IO), which runs on the > ublk server daemon thread before dispatching the I/O to userspace. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Ming Lei Thanks, Ming