From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 886E7435A8F for ; Fri, 31 Jul 2026 15:02:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785510137; cv=none; b=bEiuqaGUlsxQkO/6QqlR6QSeUbY5neLcof7sjhfDd29Y7gMHzKDj3WgtMT15nzi7zYFhKtbneateG8RXLY+FCVj9PFpoYM9UDgM0GoHjucsjkztRLFLJh7tSkYBj+FejIGTVpBI6O9P+0ghy7/QV4+EVMAOWp/AU5jmtrN2OhHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785510137; c=relaxed/simple; bh=3J5ljbX6F8qfZ/q4Yho7WM5F7BpsbTZh0SmKlt8VwKg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h819GHYTAmNc/mxlT5G7RJX9BIp905TEB9mRvRbqDRmBZqM1zsdk+j/uH5VK6H3KsgjB0UwA2UG5uhWRIlguqj/wyktA3xs/ilrxmHBbLBde2i6A1mlGZv2JWg3Q6ZdezzaICj5eXxpoCmMgjCbprlAPKdgXVRf/31BjF66WR3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dxVjT8AY; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lMI/Mc1G; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dxVjT8AY"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lMI/Mc1G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785510135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VT4GMCV34NLKfagWcQH9V4qPrMyXYT4pruyMrAm0O/w=; b=dxVjT8AYWUogqCHzWskruCmgKW0NvKc8ZC3hQK/nd+SBGBzoaMofg2vWVoNTvUtmAJBmN1 nqWyxl4brh4hF2PceoZEBp2YEb+N5+OO+8e4kRMkXG7Q3Bc6XheSN4NpqaHZP+2koBExY4 09UDObjDBqTQ7ZLImAtZfCkAUSETboY= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-utRTv3gUODqkro0kq5mtUA-1; Fri, 31 Jul 2026 11:02:13 -0400 X-MC-Unique: utRTv3gUODqkro0kq5mtUA-1 X-Mimecast-MFC-AGG-ID: utRTv3gUODqkro0kq5mtUA_1785510133 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-81ebbbd60cbso16177427b3.1 for ; Fri, 31 Jul 2026 08:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785510133; x=1786114933; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VT4GMCV34NLKfagWcQH9V4qPrMyXYT4pruyMrAm0O/w=; b=lMI/Mc1Gcf8Ii+4wCoGzeVdYQkYBF/jsORPUd16T8aVb3A50R0jOzVEFBjS/iYrX6N WuZOs3v34qpUioeQl6sGXRY8krsRe/DWrLvlEQwExsrsjsYQU+EXDZ/KLSH+7EdlRGZv UNAn/gF8Jkv7cUeaKPz00fV7u5OdkvXIlq/Re7bNyS7aKUTWWbs5sihnnM94pBp2qSwR u+sVdV60mmCLd3NsalHEKOMwF12CRidF25XKjrns8rrGysPMh1QMDsFakN5QbaedXug0 ll2m4a2CY/I+RBdcM1HOvmDt6VBh+6mUHNR23I4VG9YDNF5B7dQSq8/IWcIJNaZYNkd7 58Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785510133; x=1786114933; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=VT4GMCV34NLKfagWcQH9V4qPrMyXYT4pruyMrAm0O/w=; b=Ylp1aCRnI07GdhXZYRyZgLUKM4zU1GSgvI7FPy/zVPnByIxbvYUdSYkdQNt9IXJccN nncxZUXttIyt6dyRPF5giBn1jCNtiyd8vyN35vo1uXL1Ra4J7zNKEynYHWhDaHQz0p7q 4B9tUXw/gJUm7JQHqkyVGpu4/wScr1z0VdJQ7SS41DKVW9hEPyBvQGf8xxzBGdjs0Bg2 MAY62OXAqSpd+DVBH8VZC3ktHpTa80lGxo0kpIRykMdlimfQXRMHIuhIlf41x2ujcCvr 2fu9RzVHDTPU/WAFplUGa8GIenI9mktlqyvCY0os4lGK/hjvCWyTP+azFFfcWT7RJA3S g5mQ== X-Forwarded-Encrypted: i=1; AHgh+RqjXphk+cf7Wza+ye5oToQmzYI+I0JkGb10A26Pc16Ag1lENGHKU6VZICS7dDurgwuBXw+2/K3k9h7pl6I=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ5ampK4JvWaNtokFT9thQNE9YO79wrjidiujUukZEEA67nJfS w2fa2ds4CU2lgdbsDZkgRsJhoTC7K9MKpHiM3rYSQxV0zljUPi/1Up0/BAgAf5DlBYnTG6YZ9hk lqNw+V49qsOTkIAd+EBBKdjEc8e7M+HeFr4srVnHT4uTu4Jbonapvt3iEK5ZI5RSfKg== X-Gm-Gg: AR+sD11suTV/5ivQSfHl31cj9qxMQptMWuHXKu3gaZwiO7yb9aePLg1AmZXZfxdPBym Qct7IZLSSzr+CYO8XYKyplpBFoTsuX22tDlLpaXWc/1KOjd9+nhLfm/ORiu3Yoh0fMjNWEN/+0g slEFGuTKfFuBsEeQxsAn1F5wPoebhpRSTWLTU6g360+KzA/viCKiVkmThNdXvZ223TSjnNP/19W o4AvJMt/+tRIXGUVLg+HgpjqDDVb5zjvCaU/npujpljjwg5HeAjE54W+DlKDeK3Tr+m20QaOy0d 58ceAZZCMFGT7Y8tpk+dbZ+Sx2KMowTjdt8Eb+mq5ygeMTBCZBJ0wB28hvSCXlUV5hOfWXmnJc5 A97QFgNPWKXIPzTwu8iN8y5SeMx5fYT4CV04= X-Received: by 2002:a05:690c:3705:b0:7fd:e030:23db with SMTP id 00721157ae682-81fd4bc5fbamr1315797b3.31.1785510131734; Fri, 31 Jul 2026 08:02:11 -0700 (PDT) X-Received: by 2002:a05:690c:3705:b0:7fd:e030:23db with SMTP id 00721157ae682-81fd4bc5fbamr1313677b3.31.1785510130851; Fri, 31 Jul 2026 08:02:10 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fcd11d08esm7875547b3.37.2026.07.31.08.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 08:02:09 -0700 (PDT) Date: Fri, 31 Jul 2026 11:02:06 -0400 From: Brian Masney To: Yu-Chun Lin =?utf-8?B?W+ael+elkOWQm10=?= Cc: "mturquette@baylibre.com" , "sboyd@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , Edgar Lee =?utf-8?B?W+adjuaJv+irrV0=?= , Jyan Chou =?utf-8?B?W+WRqOiKt+WuiV0=?= , "afaerber@suse.com" , "devicetree@vger.kernel.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-realtek-soc@lists.infradead.org" , James Tai =?utf-8?B?W+aItOW/l+WzsF0=?= , =?utf-8?B?Q1lfSHVhbmdb6buD6Ymm5pmPXQ==?= , Stanley =?utf-8?B?Q2hhbmdb5piM6IKy5b63XQ==?= Subject: Re: [PATCH v11 09/11] clk: realtek: Add RTD1625-CRT clock controller driver Message-ID: References: <20260728142806.1954638-1-eleanor.lin@realtek.com> <20260728142806.1954638-10-eleanor.lin@realtek.com> <577a6882b25e457fa94fa199e66f3197@realtek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <577a6882b25e457fa94fa199e66f3197@realtek.com> User-Agent: Mutt/2.4.0 (2026-06-19) On Fri, Jul 31, 2026 at 08:17:44AM +0000, Yu-Chun Lin [林祐君] wrote: > > On Tue, Jul 28, 2026 at 10:28:04PM +0800, Yu-Chun Lin wrote: > > > From: Cheng-Yu Lee > > > > > (...) > > > > + > > > +static int rtd1625_crt_probe(struct platform_device *pdev) { > > > + const struct rtk_clk_desc *desc; > > > + > > > + desc = of_device_get_match_data(&pdev->dev); > > > > of_device_get_match_data() is deprecated. Use > > device_get_match_data(&pdev->dev) instead. You should be able to drop the > > linux/of_device.h include at the top. > > > > Ack. > > > > > > + if (!desc) > > > + return -EINVAL; > > > + > > > + return rtk_clk_probe(pdev, desc); } > > > + > > > +static const struct of_device_id rtd1625_crt_match[] = { > > > + {.compatible = "realtek,rtd1625-crt-clk", .data = > > > +&rtd1625_crt_desc,}, > > > > Add a space after the { and before the ending }. > > > > Ack. > > > > + { /* sentinel */ } > > > +}; > > > +MODULE_DEVICE_TABLE(of, rtd1625_crt_match); > > > + > > > +static struct platform_driver rtd1625_crt_driver = { > > > + .probe = rtd1625_crt_probe, > > > + .driver = { > > > + .name = "rtk-rtd1625-crt-clk", > > > + .of_match_table = rtd1625_crt_match, > > > + .suppress_bind_attrs = true, > > > > This driver is listed as a tristate in the Kconfig but then you have this. Is the > > intention of this driver to be built in only? > > > > I will change the Kconfig options for this driver, as well as the related > config, from tristate to bool. Keep it as a tristate if you are going to use module_platform_driver(). You can also drop suppress_bind_attrs unless you have a specific need why. Brian