From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22EEC3B8BA1 for ; Tue, 4 Aug 2026 12:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785845464; cv=none; b=UAeYpxQ3oYfUy4Frq16NZ7B3TdBqln/0SFHGwxbVE8uTExRPCpdVksYzAJiOYKV5YVHol+rH1i/p7uVDN6xIHZK/4PfE23JQSJL3KJUJtyGGYMAszj2e9YLK64U0vjK1wueQaNPE8j2p6+6z8wKaJqJYmLl4TL+1a3cWwX8+4GA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785845464; c=relaxed/simple; bh=s2ejx7F5QGA4/pfGRZ0mxACFQwkfGTp44+9CiqNsCjc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TKTk6Zb8dETxCWvGaKHuqEhXnNXjStR/g27DN53ox3fuJGI0dTa/f8pix4AmxZz/VgK0QBGAfpaVgzqyvKUExIm2qWgnGAS6hJQIjsFpII8fRnO0Vt5d03jkIMCP/NNRKvLonV3a2EXJwHG9/TzpYssxKnss7N9XLw8nxsBzkAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l1zCIxm3; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l1zCIxm3" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-384930ca5e2so3859907a91.3 for ; Tue, 04 Aug 2026 05:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785845462; x=1786450262; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2c2UzrU1lo5IxLJOBK6JuXRe5pbOxY4V1jiy5fHlbmI=; b=l1zCIxm3dD1kuEyhpGSqxadT2qcF1fpXSBxDR5syXfazU9ERYC9IQeoH+vqv3Y3atz AkbnQikWhCs+FgSauculZmSU9U8b4agorCURGj3St32RJq+4xQbbMxjI1XQ/XxsRD2kE MCg8qubILBonDxQJaPsSsO2peHR4O6ilwOKaIRvb9KVcTsgBCBKdtIHSnuxKpngEnOuL 4+PTM01WdE5htOarUQRN9jZog6dLcr9prmq8vDDkiCMV6la/B5RPGK/C2wpWv+cyweco MXviBs5bbI969g5E5XTJJFnOjVSAQZI+Vp8SgvdnIom54UXO94/YxfiWUzxuHq6Si5Aj AE+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785845462; x=1786450262; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2c2UzrU1lo5IxLJOBK6JuXRe5pbOxY4V1jiy5fHlbmI=; b=EmW8MhXcsnqi0/7ucdpMHtEf1MKyikVlRpBU/sgtR3DPA45kkZXIOoU+1W1NW/dudt t/tGRaQBkFUf7VCBrPyUgan2QmyWwkhYd5GvqGYXDke90nl+j9b70yv7whXBd8+CXLCi M5wyUuI8LjW+WNUJp1qGsjBqCkBv/Syk5q88FBOpJ/IOdMHeMBnP20AF4//X4ePwzeON od5y8VA9flRiR8DWoRbvKB3uDpuNhZQRHvu5b+9HRQWeao3FKfasUo9NE1Q9aiFXAgVZ bJ4sF0Y9JL1WO/8wM6y3MMI/S2MOMD1nk4Jy4nspNQQL8917SPeOWcEBSIjaFIA2Ko/b w5Kg== X-Forwarded-Encrypted: i=1; AHgh+RoFEzB4Qzr/rMOAIX6eJcOit7gtZjCysXDW0domkEe7OEa0XDGTlyiKimhvNI/Sz7ppO3s3NT8NuEzhR80=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4jhGFq7YPDOpwyZ9Bwd1j4mcjOo8O8T4fbQ4D/hWcvulVBh82 jKkJYvmXILdS75BFt4Qhdvk6nWTVEmDXDf1vcwhKPmVTXnnmR4xKDNRt X-Gm-Gg: AR+sD12isLW3DLx6Y1+27qR7/CEgJGoB3mXa3EHCOCpYgJ0oSuyXqYqfa+tk39BID/8 SZ1c2J+nsCrGNt4fGC+sbjvQguDfqeNWirIhk2v9KnxvjuRSo4FOO6Ox0TNY3Q9OAW+sXFxTtxv WVQmY3+sfz55MLz9AP/frlBVXgfOjyVIJkoU5uwS34TXQusQbgPmxBVCm8lIm5sKrTU+gQWZuxO KE+ZQfuh/W33mdBKUWtrneHwqt/7Rvb9C6c3ZDLbZoKyoXy7f2YkfqQtQJPr1/9f9jWlX4J4yDV otIMduOmTuQAHtQsWMGyQ/LENn/WoitGL8C0KmAHZZ9C9t830qi+gRP4LMDmcRNORgSQwG+FZqK zWFq9UhVRz+rGxLl+lqRArx9Id9/1X+Pd2l0u8mXQo5UUIz5ZTsmnHZVeXJ57CujjBbu/PCzOVx ous/sDYPoWho3Izib8g27xnc0QEZ5rrb2N+T4yJcvUM8PXdr3c3dxlcA== X-Received: by 2002:a17:90b:5746:b0:38e:67e1:15b with SMTP id 98e67ed59e1d1-38fbc40e2f2mr12500934a91.6.1785845462377; Tue, 04 Aug 2026 05:11:02 -0700 (PDT) Received: from localhost ([172.216.252.8]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fec15dc70sm1260042a91.13.2026.08.04.05.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 05:11:01 -0700 (PDT) Date: Fri, 31 Jul 2026 15:08:35 +0300 From: Dan Carpenter To: Ivy Lopez Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: use kfree_sensitive() for key material in rtw_set_key() Message-ID: References: <20260730231315.79688-1-skunkolee@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260730231315.79688-1-skunkolee@gmail.com> On Thu, Jul 30, 2026 at 05:13:15PM -0600, Ivy Lopez wrote: > psetkeyparm holds WEP/TKIP/AES key material copied in via memcpy > from psecuritypriv before being freed. Use kfree_sensitive() instead > of kfree() so the key bytes are zeroed before the memory is released, > consistent with how psetstakey_para is already handled elsewhere in > this driver. > > Signed-off-by: Ivy Lopez > --- This should have a Fixes tag. regards, dan carpenter