From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EF0D427A10; Fri, 31 Jul 2026 13:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785503435; cv=pass; b=Ik3Op+KvyHMsc6aU0svIgPbVMgf0iy28zpXqUq/ZokGfwu02ePpc4cEyNOSaBx3AcZxL9odAO3CE1Ra9gtXML1x8w0oCuQiuXXWUdcPEzJL3OPTr51IQjghu/GA53plq9oqQ8G8xhZDz+MA49RDjcod96qup6R4MU1H8jIXLWtk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785503435; c=relaxed/simple; bh=Zlqz4cL9Fdb1ZE0BE2QIsGlegmTlz7+NlX5WIZk8tIo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=imdXi/SzAZQvbsutO+U0S7/heYfRW8T+Z1BYAPvSTnKSJ+LAd9pr0iBBONa8j+DgDULXyUjSVldP7R1f5jURqGK/sn6JQEPSlVeP16+gPAdTcQF09o8SIa/iHC7/D9IFiM85xNbkMCAkqU5EJohouLg4WU3sOqMtRda72EoF5oM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=deborah.brouwer@collabora.com header.b=bFXbcDgd; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=deborah.brouwer@collabora.com header.b="bFXbcDgd" ARC-Seal: i=1; a=rsa-sha256; t=1785503398; cv=none; d=zohomail.com; s=zohoarc; b=Cq+zrzQoz00J2wlNPrXBe4dHSshzxf7DJsXSzdyM1dhrzXiOXivQ9GnF95OQuUyb6VSxXRzJ2QFWADOA3wb5XMjSjD6kZOx7xaK9lj/Yfgdw50yq1bLoZ+oPcRkpD+VfwRp+bQi35nM3q0NfeYJpm+ob2JqZWUUO8mCEGE87MUw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785503398; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=gGSgysdGBniHJR9h7AGR/IccbsptGQN5ulgBb8yos5g=; b=fVK/MdqbhBPuyKWj797w54MesVOIEs/S3U1uK5zwJCWBA89OZVsUkvE3WoVHfMbBWc3cyM//vQApFuo66puuxwHx7ufaNAqycTlo2VSYaFepASKn7+tFIX6L3NXA8yWTXxNvEbB56mNNn/sfyVygEFqPNkwl1zchdCQY2Dofmag= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=deborah.brouwer@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785503397; s=zohomail; d=collabora.com; i=deborah.brouwer@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:Message-Id:Reply-To; bh=gGSgysdGBniHJR9h7AGR/IccbsptGQN5ulgBb8yos5g=; b=bFXbcDgdz+ZI1krxPJZfO4Rt2IgTzmjuIGQwkE7gE3R8u//X5q5H/Oap3o+hx8J+ zgs5pXBl99TvR/Mx+Qs0Rgo1wM4yDBHEMXydCkxC/jpejI2yGP2kTCsTWIZ9c/Lmz5X CMWCAGghBmzri88XJ1WytKJkkBcO6gODE1w0OIaY= Received: by mx.zohomail.com with SMTPS id 1785503396790153.8585271194745; Fri, 31 Jul 2026 06:09:56 -0700 (PDT) Date: Fri, 31 Jul 2026 06:09:55 -0700 From: Deborah Brouwer To: Alice Ryhl Cc: Daniel Almeida , Danilo Krummrich , David Airlie , Simona Vetter , Benno Lossin , Gary Guo , Miguel Ojeda , Boqun Feng , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Andreas Hindborg , Trevor Gross , Tamir Duberstein , Alexandre Courbot , Onur =?iso-8859-1?Q?=D6zkan?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, laura.nao@collabora.com, samitolvanen@google.com, lyude@redhat.com, beata.michalska@arm.com, boris.brezillon@collabora.com, steven.price@arm.com, alvin.sun@linux.dev Subject: Re: [PATCH v10 4/7] drm/tyr: add GPU virtual memory (VM) support Message-ID: References: <20260728-fw-boot-b4-v10-0-9187aefa3f2f@collabora.com> <20260728-fw-boot-b4-v10-4-9187aefa3f2f@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.10.1.5.2/285.486.37 On Thu, Jul 30, 2026 at 04:40:36PM +0200, Alice Ryhl wrote: > On Tue, Jul 28, 2026 at 8:39 PM Deborah Brouwer > wrote: > > > > From: Boris Brezillon > > > > Add GPU virtual address space management using the DRM GPUVM framework. > > Each virtual memory (VM) space is backed by ARM64 LPAE Stage 1 page tables > > and can be mapped into hardware address space (AS) slots for GPU execution. > > > > The implementation provides memory isolation and virtual address > > allocation. VMs support mapping GEM buffer objects with configurable > > protection flags (readonly, noexec, uncached) and handle both 4KB and 2MB > > page sizes. A new_dummy_object() helper is provided to create a dummy GEM > > object for use as a GPUVM root. > > > > The vm module integrates with the MMU for address space activation and > > provides map/unmap/remap operations with page table synchronization. > > > > Signed-off-by: Boris Brezillon > > Co-developed-by: Daniel Almeida > > Signed-off-by: Daniel Almeida > > Co-developed-by: Deborah Brouwer > > Signed-off-by: Deborah Brouwer > > There's a 32-bit build failure :( > > error[E0308]: mismatched types > --> /home/runner/work/linux/linux/linux/drivers/gpu/drm/tyr/vm.rs:873:17 > | > 871 | pt.map_pages( > | --------- arguments to this method are incorrect > 872 | curr_iova, > 873 | curr_paddr, > | ^^^^^^^^^^ expected `u32`, found `u64` > | > note: method defined here > --> /home/runner/work/linux/linux/linux/rust/kernel/iommu/pgtable.rs:152:19 > | > 152 | pub unsafe fn map_pages( > | ^^^^^^^^^ > help: you can convert a `u64` to a `u32` and panic if the converted > value doesn't fit > | > 873 | curr_paddr.try_into().unwrap(), > | ++++++++++++++++++++ Alice, I see you fixed it in drm-rust-next by casting curr_paddr to PhysAddr, thank you. I must have added this 32 bit regression trying to double check all of the sizes.