From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D33D42C51D for ; Fri, 14 Aug 2026 09:04:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786698250; cv=none; b=OpiTe3Tc6ABDeb5Wc3aA6R8m2dVVmom65aNEl2oHsclwcSdJdRYxRVUAIlfin4pRMHXVOzxD7N+PfF1lGt3M8jITnFXLnKJJlTxPn9d6Umob6O8SiFoFLhn6/UpP4Z9NReo93eptFSPMT4K8UXWCPp361u1namGLWJBMV+0j6fk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786698250; c=relaxed/simple; bh=BJOf/NYSz5FG6Adem09lwkZwKWp2jY+TOiFmVjNC3eo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aWnhOFeVVnIzWFPGiXZPr85tA653lS2CPWQ0btzbIhLBY/D2U1rFe8qQaeB1aG3UMHKH2Kn+KVs1CqG02aBUbMVMsqKDZg5FOG8EQx/VO3X2tNxg7U53h2RzBfXWHfZkM5CSW3QAnGUgMk4JntynP6F9PeRt4W/LGkZrMLamT2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O+ECWrc7; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=idKzYNwC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O+ECWrc7"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="idKzYNwC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786698248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2zwZEotU4Mzq+YNLMdkEnsd0V5EVOvlW1UTGUzYHRYk=; b=O+ECWrc76ygSJnR+tAO95EmF/xwwbkMaAG1zZrUx+kzQtQGcMqe8VF0eoZwUTG7nkvzeQV WZ3Qva1Ox3RF+/N7rvZ4hl6ZXtllLjixb4mXRKDWraiVHu9tHMGdrKxgT/gl0PO6SWgo6K NysaURJmlTu6aL9n6PeQE7B4/mG6Bxg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-upWUb3SaMXujfg7oAi6kWQ-1; Fri, 14 Aug 2026 05:04:01 -0400 X-MC-Unique: upWUb3SaMXujfg7oAi6kWQ-1 X-Mimecast-MFC-AGG-ID: upWUb3SaMXujfg7oAi6kWQ_1786698240 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49561facb1dso5446495e9.3 for ; Fri, 14 Aug 2026 02:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786698240; x=1787303040; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2zwZEotU4Mzq+YNLMdkEnsd0V5EVOvlW1UTGUzYHRYk=; b=idKzYNwCrz1JKtKo7fjCX4irhU0xPLN0S/+bjaguGx563rAYYc7g3OmBkjFs37sxth yQzG3kENKvWRQp+BWtfRFNBr9HU2Rjsu0EGyB8bLR+mPHlLeHBPpfHdIkHUCU52hdED/ XjNkDly6lb9dYWZi1gKTsDItgmktVAPdu7GwWgHPWCSP7lLQcUD9oorgC0sp5JJhYd9Y vAqnrQMk/vHh1817h9YwFbaN05zvvBlWyYPelw5wlessN+cmiKvxiCc0Ru/BpPOr1jFX 1lM8h2HZZLsfJvY4Km7rfjBB92VdX0YFGFj3lF7YFMLGPwMR7eFWr81YvVAEw/HmwAqv 24/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786698240; x=1787303040; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2zwZEotU4Mzq+YNLMdkEnsd0V5EVOvlW1UTGUzYHRYk=; b=UpCvJm4QfCPdnMNEB4PrtZSP7DtsoYb16c2HSVhIoTeFMBcqhfJALzCYCWu0zNxx2n nIq368roTjmOPDXD/PGOwCjFeHlAWS6e9tBV6M1LPMNIt84zcQlKxGPiD3b4PP5PaF/S f0ReNjQqiv5mrLLhY5esOwi/kYR2yXXTY0KQ3MkgVQuaz3Ax4cIVi9HdSzKGsEod157O IHKV3c6CNI/wlWiC97pnFITp5W2Fw7WrPTZauSMp170N8dNXvsgAgYfxUr059L8WOSgP IzDoOH/FcC95n+GwVLGkFPiVpw8E4pqfC7pZ/TEnWdxLk2PLPiZx7p3X15+Q2kxyUfmE oNfQ== X-Forwarded-Encrypted: i=1; AHgh+RpNNEPdnqiJp4NaRWyWDnTzzb3DbVLtCvt/QAXVYqqxsEgHsOFgHNZxHmNMOT/iI6VsG+Lie6eTN4cN2R0=@vger.kernel.org X-Gm-Message-State: AOJu0YyI61GUNyY7sc+nNVWjev1iHkSkDPDjr64Jw1/x/ghnOmeNGerw AIJIKkOZZbKYhcnqdg4sEQvALA38eAJxi5NDOYW2PVNwV95atlElJnwaGRejpCjFYnSDTO5WWyW 4gu2CTdi7kChha2Ek6qL1WeEOs+GA+w0SgqYmOL/ZSp5Aj85gGScSjK4PpP2bpyy8Fw== X-Gm-Gg: AR+sD11xtbrV4NnxH0visJEcOxYVrRxTubD1qpc2gSy/atDg8O/a6/aYkOc0PweH+2W c1k+dbvBA+njWrIwRCl+kwFPmUhMsSLUXA18tpj7O19VEhLVRlvC4D5c9xKenxNalqIPp4LpIWf jObS6/EcZUO6f5lE1PTuZ+QT26MtlffffCb6al5TZp6gU/UldFC5SdxMRdiKStnYZmE7S/1ohqS SwkMkYGyePCDrwc7FlC/+n3FnWCdjbJ37UzhVFRa8lAwCrKgYgcyWB+lTvnJWQ2KeeYgsVXhN6v x++xlxOzsz8wNurYSLwdPLiKwPlJYy+yIV9UJSYF9WMGUDzu12cJrVwa2HfCHSnjgrmKvWOanvo +oY1IqwtnbRktxb1th2pel3LdVwdchYw7zacCN/ie2IhjtsiZmgkh X-Received: by 2002:a05:600c:4688:b0:499:8807:345f with SMTP id 5b1f17b1804b1-49988073627mr38667275e9.13.1786698240121; Fri, 14 Aug 2026 02:04:00 -0700 (PDT) X-Received: by 2002:a05:600c:4688:b0:499:8807:345f with SMTP id 5b1f17b1804b1-49988073627mr38665965e9.13.1786698239643; Fri, 14 Aug 2026 02:03:59 -0700 (PDT) Received: from sgarzare-redhat (host-82-53-135-154.retail.telecomitalia.it. [82.53.135.154]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49988b24746sm58416435e9.12.2026.08.14.02.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 02:03:58 -0700 (PDT) Date: Fri, 14 Aug 2026 11:03:53 +0200 From: Stefano Garzarella To: Nguyen Dinh Phi Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , George Zhang , Dmitry Torokhov , Andy King , syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com, Michal Luczaj , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/3] vsock: don't check the listener's sk_err in vsock_accept() Message-ID: References: <20260813173024.2362935-1-phind.uet@gmail.com> <20260813173024.2362935-2-phind.uet@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260813173024.2362935-2-phind.uet@gmail.com> On Fri, Aug 14, 2026 at 01:30:18AM +0800, Nguyen Dinh Phi wrote: >Syzbot reported an issue which can be reproduced with these steps: > r0 = socket(AF_VSOCK, SOCK_STREAM, 0) > bind(r0, {VMADDR_CID_ANY, PORT}) > connect(r0, {VMADDR_CID_LOCAL, PORT}) -> -1, EPROTO (self-connect) > listen(r0, backlog) -> 0 > r1 = socket(AF_VSOCK, SOCK_STREAM, 0) > connect(r1, {VMADDR_CID_LOCAL, PORT}) -> 0 > accept(r0) -> -1, EPROTO (stale sk_err) > >Basically, it creates a socket (r0) and triggers a self-connect after >binding it. This self-connect fails with EPROTO because it loops back >to r0 while the socket is still in the TCP_SYN_SENT state, causing it >to be incorrectly dispatched to the connecting-client path. The >unexpected packet type encountered there sets sk_err to EPROTO. > >After that, it invokes a listen() call on the same socket. This >listen() call succeeds because the kernel's listening path never >inspects or clears sk_err. Then, a new socket (r1) is created as a >normal client and connects to r0. However, vsock_accept() rejects this >incoming connection because the listener's sk_err still holds the >EPROTO error from the earlier failed self-connect. > >This rejection causes the child socket created for r1's connection to >never be freed on virtio or hyperv transports; only the VMCI transport >implements pending_work to revisit and clean up a rejected socket. > >For a non-blocking connect(), vsock_connect() may return -EINPROGRESS >immediately, and vsock_connect_timeout() can later set sk->sk_err >asynchronously. > >Since no vsock transport ever sets sk_err on a socket while it is in >TCP_LISTEN state, checking it in vsock_accept() serves no purpose and >only carries forward errors left behind by earlier, unrelated >connection attempts on the same socket. Remove the checks so accept() >no longer rejects valid incoming connections because of a stale >error, which also avoids the resource leak described above. > >Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") >Reported-by: syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com >Closes: https://syzkaller.appspot.com/bug?extid=1b2c9c4a0f8708082678 >Suggested-by: Michal Luczaj >Signed-off-by: Nguyen Dinh Phi >--- > net/vmw_vsock/af_vsock.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 622dbd046799..3cd5c3561be3 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1893,7 +1893,7 @@ static int vsock_accept(struct socket *sock, struct socket *newsock, > timeout = sock_rcvtimeo(listener, arg->flags & O_NONBLOCK); > > while ((connected = vsock_dequeue_accept(listener)) == NULL && >- listener->sk_err == 0 && timeout != 0) { >+ timeout != 0) { ^ nit: I think the alignment is wrong, maybe if you need to respin you can fix it Anyway, this LGTM Reviewed-by: Stefano Garzarella