From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C99684582E4 for ; Fri, 14 Aug 2026 09:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786698270; cv=none; b=FgOBYhqmMMlXaCGlyOuYuf1krskDEGjbxSeMpht8Mo26FpWZSXlyOSff6VoCsYzuuj6lpIlBze55FlG6dMmRY1G/rVnjbPhSBqkUGBCZWGMKiMilEbdOlCBh69hoWQjSx8j/KWHOxb0w0ZAwd7N0Jt7v6aX5rUoo+bXdUyAeyHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786698270; c=relaxed/simple; bh=TVKuU78In4WxRZQ7vl+bTB0idxpevDUhM2Pvt8vSg4c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TKh91hTlKSMA78EArawwKnep2eshnuUuiUI5k3qnKWkP31OvqFqDpZo37Iai83+q8ysGuv7xUAwHGFLUHVRKP2LbeJdKX5/IbKRZtaQr05WwiiLeKO/XKP2U2MgDlw9V3mr70m9gPge/0VN1RVf/svu/9M4+89WCNnTlcDJ1gK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WOx653Dv; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=pmHbEXj0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WOx653Dv"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="pmHbEXj0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786698267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=331Qtlk7U5woKtN1s72ENWMljrsHjQpeFCMNumZM9Pc=; b=WOx653Dv4CxbYaHkK/PwLPs0giyHoL0qAIm1pvOsE2kGCyAbZNJ6/+GurYLTkp962L/olB WtzvjQ28S/sPehzJVucAWQ88aj7A2AZR9ZbytO4vrtc8taHM8hQAlCPVcCrQD2gmPugz26 VO3u3VEnCUZlKMpBxIK46pXewAUW2Us= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-dHAoTPjKNRqPhL32EiVn_g-1; Fri, 14 Aug 2026 05:04:26 -0400 X-MC-Unique: dHAoTPjKNRqPhL32EiVn_g-1 X-Mimecast-MFC-AGG-ID: dHAoTPjKNRqPhL32EiVn_g_1786698265 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-47f4bff865cso459778f8f.0 for ; Fri, 14 Aug 2026 02:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786698265; x=1787303065; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=331Qtlk7U5woKtN1s72ENWMljrsHjQpeFCMNumZM9Pc=; b=pmHbEXj0rtNnhq3Uyon4atBLWSgsIhTI9OevS4iLiJ+VDtkqM2FIBK8h9JIB1oLwlr Em29m3yuM2FOg42GBLUbg1uVwTIuPa2oW6pTe1xZHXSzDQZQTsaYmrMDOHdDxT2Kl7Px dznd/nlY6bcNOUQurWaX8dsDHLQN1fL5WKj7/uWj6S2j4E/656v+2qiqHbrSs7lZtC90 MmHCMWpGvWcxNtMevAJ1NBTysVu1nBX3KzPYv2bdH2cUTGl61l17vz9IKW7PNEfcEysu KPVMcAAGhJlRK4Lu3/QNmD3PPkuWd3zo9t28C96E/FWwlte2/B8p/pYJBR5EGy62DfJd //Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786698265; x=1787303065; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=331Qtlk7U5woKtN1s72ENWMljrsHjQpeFCMNumZM9Pc=; b=lJVSFAmuCFpv0rfKvTjz/xfglrhHVLqmRcNMwaom4GIkRyUHbs6MBuqUdDbCKkB7JN qS4tJTiB/yyF3lDUv7KHElTH26KpL383fziFY5eMF+jaY+3NvEsdjDSu8XrEJ4A4uRKw 8jhXssvKSTCWaMf1C8kxy7WZ0NVJrmWeKyeclt8V062UjISRDNmUrYdPkqvgUXT0N9Ph oCGHtwV59t4m++HVOl5ziJnbZuw9zOYhID9vDvO6xca7pO35kuBTe98GfTbeudXkWCOI Izse6k1ySXJ+A+OuuCXcqbtPw/utZc1pOJyE6e+HXYZYUZO0dhG2xPgNrBWyD3Yk+9kB uZVA== X-Forwarded-Encrypted: i=1; AHgh+RqoBhKOBhL0a8pBJAu8kvzA0bfRMNech3VJlUrC9owHqiRQsBSAUR1ISpgMzXZFnBfK710TG/UwAOQ8f6w=@vger.kernel.org X-Gm-Message-State: AOJu0YxIVoyPTb8oqy/SCfYl0vSqILBuZcInileTegGWdupBCBL23Pjw kuWwYpUVZD4BPxY8Pl8uinIgWCSeHGy/VVV2Bder53Cte5mE8JPTaSyA3aJDdKKpgznaKwbd+g+ xVSZq34gqdhNYfi4TCnZ7sCxMP8ho3UaZP3wPWp1VnzPMWwoHWr5ZLrMevrQBg4PSDw== X-Gm-Gg: AR+sD10J49CHFHZ4i09ram0HHbzm4uEY7IEa6p7Svxuz/xStL6PZ5Q0c7bzewE8EJPK SJNaaWf4q/eimT+kk7ZmjzFBI7ZKNipohwhPsw3rtUacX/hG8bqxKAVBr0QUv0yB5cOs/ocnEr4 WOCuJUekWC9KR4w4/ma5qeYwJRNIrAAWSB6jpev4Ocg//RqOC3v89/w8yIrci/OtNS+DzFJI3UB Q+KbKJpTL8DJww46w3OEqe7YjVZ8RKcGQ8t3al+w7lTmq3vaNHPKWoZP8qvqKjgiMOKx8c/yQ74 A2sbjCz2Mlehp4zITSsfHlT1eVAHNHgZIxLdzy1+K3ZtBu2A/imqPwsUvCYKreWo9D4Km8MSdrR TuPrvZgmI1C3qG0qy74jmfypSxBk8Bq2TssxWuds5uwwElNkTvrPL X-Received: by 2002:a05:6000:250a:b0:47f:7e8f:d62d with SMTP id ffacd0b85a97d-48160732f09mr5564486f8f.10.1786698265190; Fri, 14 Aug 2026 02:04:25 -0700 (PDT) X-Received: by 2002:a05:6000:250a:b0:47f:7e8f:d62d with SMTP id ffacd0b85a97d-48160732f09mr5564376f8f.10.1786698264582; Fri, 14 Aug 2026 02:04:24 -0700 (PDT) Received: from sgarzare-redhat (host-82-53-135-154.retail.telecomitalia.it. [82.53.135.154]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f1fff25sm10217805f8f.3.2026.08.14.02.04.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 02:04:24 -0700 (PDT) Date: Fri, 14 Aug 2026 11:04:22 +0200 From: Stefano Garzarella To: Nguyen Dinh Phi Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/3] vsock: remove the now-unused rejected flag Message-ID: References: <20260813173024.2362935-1-phind.uet@gmail.com> <20260813173024.2362935-3-phind.uet@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260813173024.2362935-3-phind.uet@gmail.com> On Fri, Aug 14, 2026 at 01:30:19AM +0800, Nguyen Dinh Phi wrote: >After previous patch, the branch marking a socket rejected in >vsock_accept() is unreachable, and nothing ever sets vsk->rejected >elsewhere. > >In fact, since commit d021c344051a ("VSOCK: Introduce VM Sockets"), >where `rejected` was introduced, there has never been a path that sets >sk_err on a listening socket, so that branch has been dead code since >the beginning. > >Therefore, we can remove the `rejected` field from vsock_sock structure. > >Suggested-by: Stefano Garzarella >Signed-off-by: Nguyen Dinh Phi >--- > include/net/af_vsock.h | 5 +---- > net/vmw_vsock/af_vsock.c | 46 +++++++++++++--------------------------- > 2 files changed, 16 insertions(+), 35 deletions(-) Thanks for improving the commit description! Reviewed-by: Stefano Garzarella