The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Pranjal Shrivastava <praan@google.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Alexander Graf <graf@amazon.com>,
	Samiullah Khawaja <skhawaja@google.com>,
	David Matlack <dmatlack@google.com>,
	kexec@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] kho: support preserving high-order non-compound pages
Date: Fri, 14 Aug 2026 16:48:17 +0000	[thread overview]
Message-ID: <an9G0Y3ZNIA2NfjP@google.com> (raw)
In-Reply-To: <an2tArzOomSNpjV9@kernel.org>

On Thu, Aug 13, 2026 at 02:39:46PM +0300, Mike Rapoport wrote:
> On Wed, Aug 12, 2026 at 03:46:20PM +0200, Pratyush Yadav wrote:
> > On Wed, Aug 12 2026, Pranjal Shrivastava wrote:
> > 
> > > On Wed, Aug 12, 2026 at 12:32:25PM +0200, Pratyush Yadav wrote:
> > >> On Tue, Aug 11 2026, Mike Rapoport wrote:
> > >> 
> > >> > Hi Pranjal,
> > >> >
> > >> > On Mon, Aug 03, 2026 at 11:39:41AM +0000, Pranjal Shrivastava wrote:
> > >> >> Introduction
> > >> >> ============
> > >> >> This series is required for the ongoing effort to preserve DMA allocations
> > >> >> across KHO [1]. It addresses a fundamental mismatch between the current KHO
> > >> >> restoration logic and the physical reality of high-order buddy allocations.
> > >> >
> > >> > I skimmed through the patches, they look fine to me before the in-depth
> > >> > review :)
> > >> >
> > >> > But we are really close to the merge window, so we'll anyway need to
> > >> > reiterate after v7.3-rc1.
> > >> >  
> > >> >> The Problem
> > >> >> ===========
> > >> >> The current KHO restore implementation treats all multi-page blocks as
> > >> >> split pages during restoration. Specifically, kho_restore_pages()
> > >> >> initializes every 4KB sub-page with a refcount of 1.
> > >> >> 
> > >> >> However, many kernel subsystems, most notably the DMA allocator (via
> > >> >> dma_alloc_coherent), frequently return high-order non-compound pages.
> > >> >> In this state, only the head page carries a refcount of 1, while
> > >> >> all tail pages have a refcount of 0.
> > >> >
> > >> > This hints that these patches could be a part of the DMA preservation
> > >> > series, unless you expect other users of the new API.
> > >> >
> > >> > Generally, we don't merge new APIs without the users and if DMA
> > >> > preservation is the only user, it's better to fold these two patches there.
> > >> 
> > >> Makes sense I think. We can review the patches here, but then they can
> > >> go in with the DMA series.
> > >> 
> > >
> > > So.. IIUC, I'll post a v5 here as a standalone series till we get
> > > consensus, and finally the reviewed patches can be folded with the DMA
> > > series?
> > 
> > That sounds good to me at least.
> 
> Yes, although when the patches will be a part of the DMA series we might
> notices something else :)
>  

Ohh yes, definitely! Just asking to know what to follow for the next version :)

> > -- 
> > Regards,
> > Pratyush Yadav
> 
> -- 
> Sincerely yours,
> Mike.

Thanks,
Praan

      reply	other threads:[~2026-08-14 16:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 11:39 [PATCH v4 0/2] kho: support preserving high-order non-compound pages Pranjal Shrivastava
2026-08-03 11:39 ` [PATCH v4 1/2] kho: Introduce a helper to init high order pages Pranjal Shrivastava
2026-08-12 10:54   ` Pratyush Yadav
2026-08-12 12:33     ` Pranjal Shrivastava
2026-08-13 11:37     ` Mike Rapoport
2026-08-03 11:39 ` [PATCH v4 2/2] kho: Introduce preserve/restore APIs for high-order pages Pranjal Shrivastava
2026-08-12 11:10   ` Pratyush Yadav
2026-08-12 12:46     ` Pranjal Shrivastava
2026-08-12 13:49       ` Pratyush Yadav
2026-08-11 10:27 ` [PATCH v4 0/2] kho: support preserving high-order non-compound pages Mike Rapoport
2026-08-12 10:32   ` Pratyush Yadav
2026-08-12 12:49     ` Pranjal Shrivastava
2026-08-12 13:46       ` Pratyush Yadav
2026-08-13 11:39         ` Mike Rapoport
2026-08-14 16:48           ` Pranjal Shrivastava [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an9G0Y3ZNIA2NfjP@google.com \
    --to=praan@google.com \
    --cc=dmatlack@google.com \
    --cc=graf@amazon.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=pratyush@kernel.org \
    --cc=rppt@kernel.org \
    --cc=skhawaja@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox