From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64D2130D3E2 for ; Mon, 3 Aug 2026 06:30:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785738650; cv=none; b=GLybN+1xdwHjmIqQMScpokFJqAw06lPO2ypFKfv1oz6K7fyU/A68ZpKvuEiux/zfyfTcnijE4GSgr4Z/19jKskjOzUhtNpHroKUhT4uGVLz6pDCt3kILqiucE6LcA81I86VoJfwp0ePgXXp+fk0/r54q2C4iyAAkALcGqTCYMFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785738650; c=relaxed/simple; bh=rIH5b9KJzXXU4IoV1Vb1uLlvW1oeMVmU6PEAL8zmuEs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r89JtXwfDOWGdYq+QTkTtl5JbwW+F3asC3kA5tX9NjdLcd5/QnvwzaRUxAG+Yalh5B20iOrJwahnJXd6xrr89e+fJkYxcXHNUBgkAVbYYeB0oXhMIK/0mDsVWNIeUo7Nz1PCw4f2LWDkCENZc4rPM1/acdmuaunwZDotfsLHAuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=djZnJWSO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="djZnJWSO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C7C71F000E9; Mon, 3 Aug 2026 06:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785738649; bh=51TuCuVU9LAqwR7iEJCyZR77B8LyfuZygpXYD+/vQvU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=djZnJWSOAX5U8gOU7qILKy+E7YphUJTSGF7pZ2Yh0iY9K4v39TBW3yIoHjt+DuwTK D7H/NS09eds5wkkn3J+fy9Tt/XtAvsv2HesYwtqzWEhgrvgQmmli1QAu9x9gdnP+Nb Ltxnjz8IdxgrwxiNB567dSq2+2OjfAAsR8VWQPH8m3kwfkyYad6UCdhUBeE9J4nMTi DpVJDr4OI+z93ucELBvmfnV37BcocxL9gbPcYCY/TTQ1p/bhwk9bS83+7Wq+HNslux AB0GZHBiCoWmiWqhWn/N3Xhsr+dPANRHaY5Jm2Pe6sbhmQjGc+hMBMX+4pyX3kenGA 6gEbNxoVL9ZnA== Date: Mon, 3 Aug 2026 08:30:44 +0200 From: Ingo Molnar To: Chaohong Guo Cc: peterz@infradead.org, tim.c.chen@linux.intel.com, bp@alien8.de, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] x86/cpu/hygon: Introduce macros for hygon family numbers Message-ID: References: <20260803051248.3684453-1-guochaohong@open-hieco.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260803051248.3684453-1-guochaohong@open-hieco.net> * Chaohong Guo wrote: > Consolidate all magic numbers of hygon CPUs into a header file, > The macros describe the family/model numbers of hygon CPUs. > +#define HFM(_family, _model) VFM_MAKE(X86_VENDOR_HYGON, _family, _model) > + > +#define HYGON_F18_M04 HFM(0x18, 4) > +#define HYGON_F18_M06 HFM(0x18, 6) > +#define HYGON_F18_M07 HFM(0x18, 7) > + > + > +#define HYGON_7447V HYGON_F18_M07 So this is a bit misleading, AFAICT "7447V" is the enterprise server CPU variant - but there's a bunch of smaller server and desktop CPU variants as well that are named differently: Model Name Core / Thread Count Base Clock Target Segment ---------- ---------------------- ---------- ------------- 7447V 96 Cores / 192 Threads ~2.6 GHz Enterprise / Cloud Server 7490H 96 Cores / 192 Threads — High-Density Server 7490 64 Cores / 128 Threads 2.7 GHz Enterprise Server 7470 48 Cores / 96 Threads — Enterprise Server 3490 16 Cores / 32 Threads 2.8 GHz Desktop / Workstation 3450E 8 Cores / 16 Threads 3.6 GHz Workstation / Desktop 3450G 8 Cores / 16 Threads 2.7 GHz Workstation / Desktop Assuming that this patch does the right thing for all these smaller variants as well (does it?), shouldn't the name be something like HYGON_4G or so, given that the patch applies to the 4th generation Hygon microarchitecture, not a specific server CPU configuration such as 7447V? Thanks, Ingo