From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4BC63845D5 for ; Mon, 3 Aug 2026 06:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785737234; cv=none; b=ZGNq53vdAAiBSXHYDxdDLdAdH1XCUY33juCQUu7AYYDVn4P4C07/9Iuz9mFg6nNzYGP2GzTiB5hnXNJ5I0yXMWvtVmF3MHgc8UrbJEGPaPaIJn4jcLtWdeRZXzLIKoQpxnGHQFkCTnH+3xzvAxAWffkBmDXtHcrhhags5e4arI0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785737234; c=relaxed/simple; bh=VpuUzNZIeLkJLIkoXwftqmDNHRolrZYRf8l4gCk8KQE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r8ssw8tW1NqQ+0hFSK5d2+0mdDd+N79SGr7JydPy83qlQ7MUFHNwxxBhT89VyobZmjm1tOiZ+8mCydufNkzUjoSyGOfHaq0Igoc8e43a3fzONy5gv0qSLYeqsvD/Iay6aDiZohHmqKT6/a6xGHO6FseGE4AfS2sZe7pGKSgPgrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MGmmdb9s; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MGmmdb9s" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c9d1fff21edso1912694a12.1 for ; Sun, 02 Aug 2026 23:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785737233; x=1786342033; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=438aZJFh3TYGe28EMm9S/1fNbKwuwZnuyyU/vtthY80=; b=MGmmdb9sHhAiNEHrS3RB/K4nJjneUpGLrhBXysxIPEH/hIHQTwTjQt4Qmx40BKl9uW PFsojvHCNkxwVJoJB3/BNXz9Tmd9DVo+syMI+ZEKtkjtX0Dca6tMkL/eVIJ/0aPLKlid FDKFtxGMsDhKizTyZ+LeOhwnBxyv90x5ZoPjZQuFcCEaFIzXJ47d731GW2DObMc6GHE4 9Egknpi7lXso3YTlOnoMZFRnv8kgk488802wdG1hX7sBV/POhjaXAmbbxkIPBfu5jxs7 NIySeFnEh1j3QTv1KCdwMt8JDVy87h8fLVku5pzI798OweoUByCim2hBjfsBCxE9CH7A 7ceg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785737233; x=1786342033; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=438aZJFh3TYGe28EMm9S/1fNbKwuwZnuyyU/vtthY80=; b=FPsfpDOrI0dkmxX5rhjQTPDsqMvJssQhPscO8AapiHXR07I/+e57ADioYUZ5F7S/sB s/60KATZ7lJAT4ldm3D5uHWj9VLRnwnfs0NsBvNX7L9X8KPt7dyVCgVGi3D0yItMXO9Q G9OQwTfE0jsZghgahtyBk3nUcQ54oT/yN/vi22kuOgCyNYiTsrNxZgpQdslgnhDNen6T +fuVLHBQh4mTdGb97QDTXxUMYhzmigzQ/ofFTslVngMXIaRmbpQtcrQxgbuotpEBpj6y cG9eJbXGtbJXOZpZAfvGNFwGtnh6E+Odq49MMCk/wOgpbfqsWv46Mq0iiHPJhbsVUhGT pK7Q== X-Forwarded-Encrypted: i=1; AHgh+Rqhriu3KXJEJHvFwniYn2/JGeEg+3p/In5jcmMQB38YTVGT5RHf6acvKHRPGUCWan2Ie8eStFbkkryEmtg=@vger.kernel.org X-Gm-Message-State: AOJu0YyFkE/SkLWePPe2O9bULbXbBFL2hqOFGW4iDnm5GeuPxKMpt9yb 8cUjDAQnQqnUBlWUBMUpDtVQm9J2Nf8Xkk8WrajXS1p8IGxcOaRvXROSOdlzRQ== X-Gm-Gg: AR+sD11uStoCM/qi3hUK5e9zNp9FjrC6CIAsuGy1LFNxBBnQoGDKqPXOiFviKTLo2ai 7/lLRnaIfOUjbEbXa05FZ5CmMWzSE9rqC+QVuK/Yc9iMJMgnwPwOJui/W10/RTjZZ2VbZnyav3N rI32Gov42kWo2WAileSEEshJA7r7cheFwms5trH/VLFQSd+SVWbX0/V9jiPdhAql4UhKXPafReW dEXwLcWKs/vK12E+w2JFm1hWmmpkOgpWENt0zdQDzJj0uinIw1dPLaSDPP38EuqJ4smMllgatHj 5qwuT33SXkRhyx2uvEMFFyjQU36TbqxxrOvYOApxKuA2ywaoQhbCOhzsCFHwpbRgS6u+UIS7jjt HkepwtUZySt4L8dC/I370c6NaXE9bALwIHQpaHBDorlETLbbk3j/ami2lKvIuPxd2OVoMA9LynT aDJEAKGXFVFu6v0QYmRz7YcypcHIA4GYRB8ohhi7+UIitluOJ5YlPj2N2bw43OAgTY94FZ8aCyj R3gAMhrVQcAbOrYA2FbWEKYPnDRoA== X-Received: by 2002:a05:6a21:7a82:b0:3c3:652c:664e with SMTP id adf61e73a8af0-3c92a98f2camr9231223637.69.1785737233015; Sun, 02 Aug 2026 23:07:13 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:4fff:876c:cdae:e53c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153db2f911sm37519963eec.0.2026.08.02.23.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 23:07:12 -0700 (PDT) Date: Sun, 2 Aug 2026 23:07:09 -0700 From: Dmitry Torokhov To: John Paul Adrian Glaubitz Cc: Yoshinori Sato , Rich Felker , Linus Walleij , Bartosz Golaszewski , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] sh: mach-rsk: rsk7203: avoid using inline compound literals Message-ID: References: <20260802-sh-rsk7203-swnode-props-v1-1-7a790cbac9e6@gmail.com> <32a0d810bfc56029453aa72cefa49cb40466f64e.camel@physik.fu-berlin.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32a0d810bfc56029453aa72cefa49cb40466f64e.camel@physik.fu-berlin.de> On Mon, Aug 03, 2026 at 07:47:50AM +0200, John Paul Adrian Glaubitz wrote: > Hello Dmitry, > > On Sun, 2026-08-02 at 16:18 -0700, Dmitry Torokhov wrote: > > Using inline compound literals for property entries in software node > > initializers causes older compilers (GCC < 14) to fail with "initializer > > element is not constant". > > > > Under C11 (6.6/6.7.9), initializers for objects with static storage > > duration must be constant expressions. Taking the address of an unnamed > > compound literal nested inside an anonymous compound literal array is > > not guaranteed by standard C to be a compile-time constant address, > > causing older GCC versions to reject it. > > > > Fix this by declaring property entry arrays as named static const > > variables, ensuring their symbols evaluate to unambiguous compile-time > > address constants. > > > > Fixes: 6905cdac0e51 ("sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons") > > Isn't that the patch that was forced into the kernel, overriding me > as the maintainer of arch/sh because Linus Walleij got impatient and > merged the patch into an immutable tree? Yes, but incompatibility with older GCCs is not something that you'd recognize on the spot, would you? Also, you seem to be hung up on the notion of immutable branch. This is simply a branch that creator promises not to rewind/rebase so that it can be easily shared between different subsystems. While we are at this, there are a few more patch series for SH that I would like you to take a look at, pretty please... Thanks. -- Dmitry