The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Prabhakar <prabhakar.csengg+renesas@gmail.com>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v2 6/6] memory: renesas-rpc-if: Use runtime PM autosuspend after transfers
Date: Mon, 3 Aug 2026 09:33:20 +0200	[thread overview]
Message-ID: <anBEQJ4VAaZfsUTw@ninjato> (raw)
In-Reply-To: <20260727103449.3188105-7-prabhakar.mahadev-lad.rj@bp.renesas.com>

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

On Mon, Jul 27, 2026 at 11:34:49AM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Replace pm_runtime_put() with pm_runtime_put_autosuspend() after manual
> transfers and direct memory-mapped read/write operations.
> 
> Flash page programming may be performed as a sequence of closely spaced
> transfer operations. Calling pm_runtime_put() after each operation allows
> the runtime PM core to suspend the controller between successive
> transfers, introducing unnecessary suspend/resume cycles and potentially
> interrupting multi-step transfer sequences.
> 
> Use pm_runtime_put_autosuspend() instead so the controller remains
> active while transfers continue, allowing it to suspend only after an
> idle period.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

I tested this series with my SparrowHawk but it doesn't use the xSPI
code paths, so only this patch is only affected. No improvements, but
neither regressions.

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

> Note corresponding pm_runtime_set_autosuspend_delay()/pm_runtime_use_autosuspend()
> calls are already present in SPI driver.

Unless I am missing it, there is no pm_runtime_set_autosuspend_delay()
in the driver nor in this patchset?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-08-03  7:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 10:34 [PATCH v2 0/6] memory: renesas-rpc-if: Optimize transfer overhead and implement runtime PM autosuspend Prabhakar
2026-07-27 10:34 ` [PATCH v2 1/6] memory: renesas-rpc-if: Mark XSPI_CDD1BUF0 as volatile Prabhakar
2026-07-27 10:34 ` [PATCH v2 2/6] memory: renesas-rpc-if: Move static bridge configurations out of dirmap hot paths Prabhakar
2026-07-27 10:34 ` [PATCH v2 3/6] memory: renesas-rpc-if: Consolidate XSPI_CDTBUF0 updates in write path Prabhakar
2026-07-27 10:34 ` [PATCH v2 4/6] memory: renesas-rpc-if: Consolidate XSPI_CDTBUF0 updates in read path Prabhakar
2026-07-27 10:34 ` [PATCH v2 5/6] memory: renesas-rpc-if: Consolidate command setup register programming Prabhakar
2026-07-27 10:34 ` [PATCH v2 6/6] memory: renesas-rpc-if: Use runtime PM autosuspend after transfers Prabhakar
2026-08-03  7:33   ` Wolfram Sang [this message]
2026-08-03  9:07     ` Lad, Prabhakar
2026-07-27 15:51 ` [PATCH v2 0/6] memory: renesas-rpc-if: Optimize transfer overhead and implement runtime PM autosuspend Wolfram Sang
2026-07-27 17:58   ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anBEQJ4VAaZfsUTw@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=prabhakar.csengg+renesas@gmail.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox