From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C0E3339392 for ; Mon, 3 Aug 2026 10:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785753199; cv=none; b=jWZjYH2HMbNxNe6aIkSnVs44QrOcO59uxznE3NhOmeJ4batILV1Lbnvfmk3ahH64vm/JDNR7l6HDnXQHFAan3eM7X4WAjy5nr6Mr+vit6amxYbw9nSLDOGUDJGC4A13JKvI0Ja/DU/tB2VOKuAAiOopghNkaimLFxKhSgQoRO7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785753199; c=relaxed/simple; bh=mQbaH5tI+IruZWucS8AJeU4qoJiDpkOvFU79qqUCJGw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B2FYomL1eBAFuk/0m1yW70BDHbq2/XMtXu/1dswS+rpMRmtSmfMX6A8Xfs4FLt9dP48Bs08c61AdCzcMDgBSIjCwW3ZwoHVvNC9FdT/U1JqAWjJQElffacbYI5d+YrVM4TXboTPN1w4itPEl/ZsiZ+W+D4QcvBpPGIGpjTjE8lg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eUNLPHTy; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eUNLPHTy" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-496bb7cdf51so19647305e9.2 for ; Mon, 03 Aug 2026 03:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1785753196; x=1786357996; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kW6C1+4rNhE+0PMn+ucH4K3CUSEGpMH1odrzmczVGFM=; b=eUNLPHTyle+K1jy6YnXFv/hWDuBZ3SXmPt6m2LD0zF+9vQf64wwU4KPvn+O7IQ61Tl 8ed/F9ueqZM3OliXxw7Xefun2aPnjR3NpVXeapvFjrOHuclosOS9r7aQHAtrA/QMOig6 COyzHH50HolnbSSQbJT1eYT2Z8yOne6J/3fw97UoazsEQGxMbO6XJPI29SKR0EuCVyuq KDUN2ur/rla8J4DaxEyqleuycs9lBRYzACYrmVVLWHz1kZrmdxLBSHxXtE/AGXEtYiY5 ZMf0LFoWcep8X7t5FcNONuI/5wtak+Soox8Iy1300hM99iWSyndQyq56QnZAEnUHdeo1 bZFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785753196; x=1786357996; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kW6C1+4rNhE+0PMn+ucH4K3CUSEGpMH1odrzmczVGFM=; b=YDxe9eWp/OUYbNIHYmfuzZiHSGgMbT6BF6BLurcnLKXZcnHb2Pi5YLptCNvVlNM6Xo R+pKIoAprqF1/PbYVWbKIpy9rWWA1KX3ByPa21gsw9F6fNWHSHbmZKsELw1vHG28uUZe D2EqWq0vfEK5ykwR0pAsqNfa0QeeFWwxrwla5yqn/u0W0BvrtxDaOZZVTutsTEHm6+WK IBHrWGoizgXTbkZoaprnOP0/2s1ppUK6gBe6Yt4r85cbYffvuyoW74H2hfACArPlGE30 H7WGt73RTDjpRDiyi2WIp7UR6ccijxGQJEZbHZG5G62jS3/TxQB+VSwZfOsLjUh+O6cf dIjA== X-Forwarded-Encrypted: i=1; AHgh+RqjZ3KJTSIS1LHoNW2HsnxGtQa1GGBrUqASq8/Wfz7U9XKBlspOtCgeDIBaSOnRHMetvd1Xlp4zU8RgeNk=@vger.kernel.org X-Gm-Message-State: AOJu0YzPoZuo5RonDCVCMpY/sTOeavin+NjYWMyWI3QGRJgtOEg1uvNd vgPii0NOglK0gXc5h6SLDN5XO921DnaX3nTMaFdy8zuS+7wYk3ovufP4fXSftxnfLw== X-Gm-Gg: AR+sD13nNUHWQhbQCFtjAEHu//Oqkg75x3shxUEKKefc0vlCCG3b9uLT5FdOVkjU0Am GzG1Ry3OPxabiHs1S2thNJLGrtk3ds4kibXgA3dOtgxjsKUhfPjHxZX0uZ18slqTfZBBPXV1L4Y wZocnfsMzkf8PBOkbBi+ZQfCevdlPoV6VESyseD9CJzJ//0ODhCNvT6q3BL08OcaHZ4i46vlNBx cQoDsg2jUsWNBWD1VxNlvwUcYDI4dGKDZJpFYWMMOKjw/JmUO9d1RNOGYMcV7lVtzzZnD5OscFC QOBn/l+kB2VPJeL97BnJ6BgT7thfLAV8G78ay7nWJ8osHe8Wjpg+ipT29q1M5kpmUt4qiRBIdl8 fN31Vwe/hlaZ7lLBv/vAZrk2Gjy9mU1apgMwXpM7817pYH5SkE/jfYr4agTOypeUHZ/wvNz9LKM Fk7lFNc/ScnRTji7611i9I11i4v+qlhTsfg/YisScsMo+k+VBe5O6TllLhFTblloumQBjMItIDg u3gHbrru5NK0kwuA+nvV7nhZeHTV2Is4s0R/VvQ2SLX X-Received: by 2002:a05:600c:8711:b0:495:52a5:8829 with SMTP id 5b1f17b1804b1-4980c652515mr253557695e9.11.1785753195960; Mon, 03 Aug 2026 03:33:15 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b5f007sm209718545e9.6.2026.08.03.03.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 03:33:15 -0700 (PDT) Date: Mon, 3 Aug 2026 11:33:11 +0100 From: Vincent Donnefort To: Fuad Tabba Cc: maz@kernel.org, oupton@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, alexandru.elisei@arm.com, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, qperret@google.com, ardb@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, tabba@google.com Subject: Re: [PATCH v1 03/11] KVM: arm64: nVHE: Declare the hyp event IDs before defining them Message-ID: References: <20260720161343.1367007-1-fuad.tabba@linux.dev> <20260720161343.1367007-4-fuad.tabba@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260720161343.1367007-4-fuad.tabba@linux.dev> On Mon, Jul 20, 2026 at 05:13:35PM +0100, Fuad Tabba wrote: > The defining expansion of HYP_EVENT() in events.c is the first time > its translation unit meets hyp_event_id_, so sparse suggests > making the symbols static. Include kvm_hypevents.h ahead of > define_events.h so the extern declarations come first, as with the > tracepoint headers. > > No functional change intended. > > Signed-off-by: Fuad Tabba Reviewed-by: Vincent Donnefort Tested-by: Vincent Donnefort > --- > arch/arm64/kvm/hyp/nvhe/events.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/nvhe/events.c b/arch/arm64/kvm/hyp/nvhe/events.c > index add9383aadb5a..b845be0acd117 100644 > --- a/arch/arm64/kvm/hyp/nvhe/events.c > +++ b/arch/arm64/kvm/hyp/nvhe/events.c > @@ -7,6 +7,8 @@ > #include > #include > > +#include > + > #include > > int __tracing_enable_event(unsigned short id, bool enable) > -- > 2.39.5 > -- Vincent