From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58AA836997A for ; Mon, 3 Aug 2026 13:01:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785762065; cv=none; b=LGVNYm4KpV9zZedDn7xQ/dagfEr7yToDmhbUEMptIFjdXfsH5MSY0JfjAhMMshrryrWup0xw2uelJwClqxyM324XAIvGQloQFDuiYW90zlbm7zu/VO0Gc+KkGmsE0UQvxgjVduqh0US4xLvMBRukaN+FdCIWnwK5o2KZK9E9tVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785762065; c=relaxed/simple; bh=K1kDLS2yi/4AXDZ30Ng9gIKx0j7kkRu684p805bqleY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cVM3tWzX0974+S+3JgxMnlvlc3k3KhUPU3brJ4t9cewFmK943hBouwWg4XJlCrd8h/mCeLPvU3fg5IEoS27D4bwUy4Pd2ckKDaS9UA2GeRP3AzrL2H89zUmvbLJJuLGUyJH+fFxa8xl5gqA9v1/YGIRhCrx+ANl9dM1679iyZtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NMrZBhgo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gwigeLGh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NMrZBhgo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gwigeLGh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785762060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w6tFfl2k7VKoJYI6A9G9h/Yn4jzbGCJFQ1d/hM/wpXM=; b=NMrZBhgoKr30pNhlYXkD7zGnfKS2wns4KAVKtKIp6+vJqn5yXdKKuY1b20iIoO13AW4yLY cnNol8DXhF29XmPqnmofaR4h5umBgN6fCjh1OQ+KRIQGcMQkMQU4tQxARVLDho9HMnIYSd L0PLLSAF0SlXCO2C+EP2aA9caBjWhnQ= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-5Sivb7HhMpWSJHRjqi1ixg-1; Mon, 03 Aug 2026 09:00:59 -0400 X-MC-Unique: 5Sivb7HhMpWSJHRjqi1ixg-1 X-Mimecast-MFC-AGG-ID: 5Sivb7HhMpWSJHRjqi1ixg_1785762058 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-81f8ba7885eso115997727b3.2 for ; Mon, 03 Aug 2026 06:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785762058; x=1786366858; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=w6tFfl2k7VKoJYI6A9G9h/Yn4jzbGCJFQ1d/hM/wpXM=; b=gwigeLGhJ6fNSaZeDCVvNMZS/4pUzYBfc7fFkICS31T2MDP+u7ngrexY0dGl0S2und upO1vVP8WFwxuyd0bkPu4x0UCRXwkQEGXpHO2Q2cU98HkoC41oo7CgpMHazLUTA8ylu1 mg900FzKtjHrayHg9pe1a5iYxJAbJ5EIpZdSjkPAdeOQylActHqHm6XWmlMqipl+XLBc qSBt+5VQLjrWWiclq1Vgvkn/LjRzeM7SkdbMQ48AcbZFBtNx8Kc0fjlqSyRi3eLmqK/4 eOtjL9thWnpaq1L1vYytV8VprcDBEI/on4+OX2DGzs7czFlvTvL5B/QwHjqBhqyUZ4kT We1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785762058; x=1786366858; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=w6tFfl2k7VKoJYI6A9G9h/Yn4jzbGCJFQ1d/hM/wpXM=; b=hoXMLkxBL9jyQNLGwrBjdqmaWpzvoNCdcy+JLt+ycC43ZbDupJ8c8w/O+yZv5EwrZ1 +1SBW8HhmEZwATaeioXowul642+WrdFygD37vjZMEGrnweKpr87A3kPAMQEhSEItZmYx l3YYZ3CnaBBJyRmh9WBGnI6mjhe0ebehtyqQsgZ0IxvFtKmCPv/cSq/gN/nfaez1qMIg NUYLOifl1h8Bru1Qk4kNZ4c3x0RV8GbJSSmg+VNWu/FsSt2NiPWA51JA6ZfJF0hrqIyt VBPgsTgFbHsRuNyAMdDTd4oQJfzO+jmO8jbIQ13muD3d1tDR5lNZx/KUqJpCK6joLXMF ggkA== X-Forwarded-Encrypted: i=1; AHgh+Rp0hvT/TpC7lBGuPZ5M98tKqPPntwc95rHnA6r0LhCHitXehxl1vRmdBg8cHW7zCEESqXAvTjLHCnGKJlc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4XnIYwOcQVQNuf+MDfyUmEvVHvC2E3BhWTFzK78AnMy+a1JcB UChweRDLneQW3QYkJ5zZTYG+D1zNEb7f7fKAXoF5IC2htv1PKI5cB7mRtbJGwiEtYrRNeJwB9GF iEIqk/+INzILP46P19heyBxBfeGhHE6Uvfxiieicdf3PBqbe1GSheTOlz9YNX1iT87A== X-Gm-Gg: AR+sD13FMoKFLUZ/G4FJnGCVNsu2JE+u2JixX4DMGly/kYUH7v0ltyI9Pt6fgcD31B4 dk5hpHyL2y2m1Y82AVKeKT5YDXSqem17S6CgpzYApsVWnDFtUwIlbOD0UZgPwHHIoHhG0/nfKME GPdVc1CE84U78c7bc2+kPzLmyNNTi90D062Q9EQ3cP1kyhT26v6tIhPAxCzdlxvKRYnqUq3X3e1 Xv6LZeqhogAqpncOaoWdOGmPB7bAWnJrpnffzQfOun8IO6QtwgmGSDfTeIKA5jQlkXolV7Z26IH bx3UOD5WNF894ZcSc/orLxdseNoa9/wcGCMGkjm7ehcKMcmgbw7F3011Xp2bWC/Qjw8rqoeTjsV yLiSPrlBo6NmobeVhi/OL3DaqPKl92ifWU9g= X-Received: by 2002:a05:690c:6c08:b0:7d0:79f:339f with SMTP id 00721157ae682-81fd4c09889mr120972217b3.34.1785762057748; Mon, 03 Aug 2026 06:00:57 -0700 (PDT) X-Received: by 2002:a05:690c:6c08:b0:7d0:79f:339f with SMTP id 00721157ae682-81fd4c09889mr120971147b3.34.1785762057045; Mon, 03 Aug 2026 06:00:57 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fccf2e239sm54877467b3.5.2026.08.03.06.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 06:00:56 -0700 (PDT) Date: Mon, 3 Aug 2026 09:00:50 -0400 From: Brian Masney To: Yu-Chun Lin =?utf-8?B?W+ael+elkOWQm10=?= Cc: "mturquette@baylibre.com" , "sboyd@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , Edgar Lee =?utf-8?B?W+adjuaJv+irrV0=?= , Jyan Chou =?utf-8?B?W+WRqOiKt+WuiV0=?= , "afaerber@suse.com" , "devicetree@vger.kernel.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-realtek-soc@lists.infradead.org" , James Tai =?utf-8?B?W+aItOW/l+WzsF0=?= , =?utf-8?B?Q1lfSHVhbmdb6buD6Ymm5pmPXQ==?= , Stanley =?utf-8?B?Q2hhbmdb5piM6IKy5b63XQ==?= Subject: Re: [PATCH v11 09/11] clk: realtek: Add RTD1625-CRT clock controller driver Message-ID: References: <20260728142806.1954638-1-eleanor.lin@realtek.com> <20260728142806.1954638-10-eleanor.lin@realtek.com> <577a6882b25e457fa94fa199e66f3197@realtek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) On Mon, Aug 03, 2026 at 09:56:01AM +0000, Yu-Chun Lin [林祐君] wrote: > > On Fri, Jul 31, 2026 at 08:17:44AM +0000, Yu-Chun Lin [林祐君] wrote: > > > > On Tue, Jul 28, 2026 at 10:28:04PM +0800, Yu-Chun Lin wrote: > > > > > From: Cheng-Yu Lee > > > > > > > > > > > (...) > > > > > > > > + { /* sentinel */ } > > > > > +}; > > > > > +MODULE_DEVICE_TABLE(of, rtd1625_crt_match); > > > > > + > > > > > +static struct platform_driver rtd1625_crt_driver = { > > > > > + .probe = rtd1625_crt_probe, > > > > > + .driver = { > > > > > + .name = "rtk-rtd1625-crt-clk", > > > > > + .of_match_table = rtd1625_crt_match, > > > > > + .suppress_bind_attrs = true, > > > > > > > > This driver is listed as a tristate in the Kconfig but then you have > > > > this. Is the intention of this driver to be built in only? > > > > > > > > > > I will change the Kconfig options for this driver, as well as the > > > related config, from tristate to bool. > > > > Keep it as a tristate if you are going to use module_platform_driver(). > > You can also drop suppress_bind_attrs unless you have a specific need why. > > > > Brian > > You are right. Keeping it tristate is beneficial, especially for aligning > with the Android GKI design. > > To properly support module unloading and driver unbinding, I will add > the .remove callback and drop suppress_bind_attrs. If you are able to use all devm_*() APIs, then you shouldn't need a remove callback. Brian > > Thank you very much for the thorough review and suggestions! > > Best regards, > Yu Chun