From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0637740B0EC for ; Mon, 3 Aug 2026 13:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785763747; cv=none; b=omLT+q+tpawA3REwx+nNa+X2ljXY79KKW0cwoNvC7MRMW0Sg/asXvBssqwE8P66WPse5IZyMrPi+6DBoZ/0H8Jg+qhvQdvBuYvf2hZBC9XCDn4T8f1rFYiJDAyszRzkpIcIecC9h8hPSEhj+LYeABgG4hMvOZaGTJtL9e79BYNQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785763747; c=relaxed/simple; bh=rt6cpLyEfLztXWT5RtkrHWdxHGWl2vr2vrgJc6Px0Zo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DNxj4H2hlZobSt8bouMunZuU5ZHLz59PXnAcFW51VKen43A07/LVeQxTSujUg57IRk0d2KTQBeb1JIvpS2/kNmaRZkYH59hiPQxI+Hs+z2//L9pD73iQEdCmCOTte2H9dIzq6gZYWhmTcWTOlkY2tPinYbHKjU7rvyBgvJwOIYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SngWaJcG; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=r1vTWRoh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SngWaJcG"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="r1vTWRoh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785763742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cdgp9gIIOAfbXbEpWUgB8/qfQM0ZVMZfTtpI1Q0lJU4=; b=SngWaJcGQ67kwOc9aPLAD0qwRZoQMNQF7liq+Kx5PmO4D3GkN+hU5xbmi4uopBBQkuBpwI dJCQDrfC1OHJhTXzKJ7V2QcesFFpSt/bIHU7NZTQ+1XvjRKzkSu9xU1x4jRIUjFyOpFWr1 wYpe3Nyn7bSJvwrgSko1pe3hxPMJ8Y0= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-ijDLFb4mM8maYBiTc7qvXA-1; Mon, 03 Aug 2026 09:29:01 -0400 X-MC-Unique: ijDLFb4mM8maYBiTc7qvXA-1 X-Mimecast-MFC-AGG-ID: ijDLFb4mM8maYBiTc7qvXA_1785763739 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-81e8a76a273so113105677b3.1 for ; Mon, 03 Aug 2026 06:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785763739; x=1786368539; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cdgp9gIIOAfbXbEpWUgB8/qfQM0ZVMZfTtpI1Q0lJU4=; b=r1vTWRohjkAnSFYC9Bv90N/gg0Wqzm0YcBwvp7/4ECoux3OV5OJs2K2CXc1Bhnevdw YLlqMzYJK3IEUA2BtpNnwo5DHD3Gos0JHPyXgYGgEp8b6HrCQ2SU0SBD6CQkNFBWQnlC Vhb852GR9fazaixGCNunpiMU0YXOBHIuweA/5iTmD1YBMJbEbjVozOnWG3vbG90tslAy L5c0OMYZ3Xl15H2BOc2F5YCIFd/14w5IIqXvofaHt5Cz3kQxgKIC8bX4EfVIjVU1AVE4 f43nMtFZ8FcjxW69o7z/3P0/odfkoVqacQE0csVNPVqzRUxfKk6KW80hk0PezyUKxZRD woxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785763739; x=1786368539; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=cdgp9gIIOAfbXbEpWUgB8/qfQM0ZVMZfTtpI1Q0lJU4=; b=GWEwoDNpFx+nOLRww1JdW7JAk3FC86kbEGkSrCas8gltz2gH1KIw0IOP7rDG/lsdms Ys3vpTsv+sudot10N7Nd6htQnG9lW6EdE4EusFd5XFUh+a64Y2LkYeCPdPtCleHLb6l6 N6/WzVZ7iwwUv7+j8qbmMP/9te0NUIpNs4KtHJIUz2sVMzXVFJNQXnAuJRqwaAcSPL8n FVLObagFTaSUtMoRE3rv8g84HIXGmTPNkz5d+MFK1OmdPjpqTv/iHol1WRb3RKQo8Ci2 F/4UMzmYFiqdUzdGRIcKeoE3aaSebY0PWGpRdcOrf+C0U7trdZT90L3R3Yx/qtgEzT1y I6iw== X-Forwarded-Encrypted: i=1; AHgh+RpiRxrqsWBDaPMFIRNyE66wR2HJgmikBQlrXJm9yx2crdjFJz8h4qV6bFnWdrMxlFV1jH3K9h7q5gGBHJA=@vger.kernel.org X-Gm-Message-State: AOJu0YxtdJf8JN23K5JEcNpjrEaKAdP7ritI4yBhLPdToskKeEKu2j29 KDzAEYNHB+urv6LHPw0SK1/KD9cMN+kwxw+sKgxZurAv5ZM7hfUCy4LglDhsav7+qPtse9mlMyF 7H7f+oXv/7rUUff4yg4MecrRsqj/R8u2ld9NLITZlDO7nhjxdoEOVK1vymqhbLozNXg== X-Gm-Gg: AR+sD128/ayO5GN3nh0sXwNaaTsL9crB6JrOuwZIyB9RAeh6T9AGx5TSvDbEjncz4V7 Vg1hiU0RqX8QQFCyoC9t0Wx/4TSR2AQcpPaSlxOxIC19VMc5rBgb9mOPjaLrRD/ddl86qsGLrZ2 3RwrEHOR0IHRvqbtCm3WJPifP3gnjRSqfqdJuBYG4yohQM8FRiq7ezu4WoVOoHERp9rGNsFrayN Jw5hc6zsA16wZ7SYz6mCFB2Dv7DS0uN0/JLKxO+X9ZXyztoVweYX5B4OZ7ItYPEXZgGrIGneBUJ nZq0CYfu/63XyzuhIfV6WyIjhsyQPI5CXQiErQAmsO+7JMFUjpu+A1GxjU42JLwI5ZL8tEpBOXK c5akAS2ez80Fazt015IC6FLqJXkFJAc8d6SM= X-Received: by 2002:a05:690c:9981:b0:81e:8577:d044 with SMTP id 00721157ae682-81fd4c3a213mr122859547b3.35.1785763739386; Mon, 03 Aug 2026 06:28:59 -0700 (PDT) X-Received: by 2002:a05:690c:9981:b0:81e:8577:d044 with SMTP id 00721157ae682-81fd4c3a213mr122859327b3.35.1785763738931; Mon, 03 Aug 2026 06:28:58 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fcd164474sm55597127b3.48.2026.08.03.06.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 06:28:58 -0700 (PDT) Date: Mon, 3 Aug 2026 09:28:56 -0400 From: Brian Masney To: Onur =?iso-8859-1?Q?=D6zkan?= Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.almeida@collabora.com Subject: Re: [PATCH v1] clk: devres: fix cleanup in devm_clk_get_optional_enabled_with_rate() Message-ID: References: <20260801111637.304590-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260801111637.304590-1-work@onurozkan.dev> User-Agent: Mutt/2.4.0 (2026-06-19) On Sat, Aug 01, 2026 at 02:16:34PM +0300, Onur Özkan wrote: > devm_clk_get_optional_enabled_with_rate() registers its cleanup action > before setting the clock rate. If setting the rate fails, it attempts to > disable and unprepare a clock that was never enabled. This issue was > spotted while reviewing "rust: clk: add devres-managed clks" [1]. > > Register the cleanup action only after successfully preparing and enabling > the clock. > > [1]: https://lore.kernel.org/rust-for-linux/20260706-clk-type-state-v5-3-67c5f326a16c@collabora.com > > Fixes: 9934a1bd45b2 ("clk: provide devm_clk_get_optional_enabled_with_rate()") > Signed-off-by: Onur Özkan Reviewed-by: Brian Masney