From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3945C416852 for ; Mon, 3 Aug 2026 14:44:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785768264; cv=none; b=VEj5nYmbOonTNHTNK0nWWvy9zec0v0qooaBVlIVUUqHVOabYMKg3PHz2C2udeVvQB3CtV70b55C6noALfOUU4EyOv93YTLBQMyZ1oxNuJCJT2tiZWvBcg+gaK7knejwKKQ/QeJBvb/TlDdiBKGyE1dqtfrLJRDv09cz3P1BLOCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785768264; c=relaxed/simple; bh=SrHwXeHzS3IuNyK4hcQWKtA4jL92CI2GfdYLdeFKq7Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PE/0rOk5nmahyk32IfCF+eLS0ynEDLLbHxEjCZylzc2x+Pu0HBq7bDJ1aacOXrdw9f594IGyNvEHbL1JQXT+IbGDoQV4MomkuijfL03u2EUwQE2iFpaUpWQSujTA9IGjB/pfFhvvGWot2Wvp9VbrjRMKVY1IDaKeU3KYm8lYt+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=obSbc5rm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="obSbc5rm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 266BF1F00A3A; Mon, 3 Aug 2026 14:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785768262; bh=2SUYehOCR35MQolMkuC2vU/2PksZiE8FgZrQCvTUjUA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=obSbc5rmSMshpAxPQHkZdfm/Uilr9a4TZbJqrNfsXs85jGXw8T6SoPDRSevaKT3bz kR561dD5bwFhWH21PaxOsKHUEXx3lT+06NjTAcrOQP5pgEfHC/jnDHd0G5nO7vOKtl yQxQLoWPeASNSUUB+gcQyAXa7GUO0PqtYqnQ8Stf2kdhz8tFIoH9WGxkiplXPf5oVs kPxaL3RwmRPWHsa4MF7y1NTeULvApDZNqkAm8q3lp4cvmm8vMK3+TXl2RcvPwO/9oA dhhM5SIcr1inX24cLkSI7UkZzo5xU0/zDocYyrf08EaoMfiTCIhJm2IiGMVHm/36OU VjdYrPpVxALlg== Date: Mon, 3 Aug 2026 15:44:06 +0100 From: "Lorenzo Stoakes (ARM)" To: "David Hildenbrand (Arm)" Cc: Rik van Riel , Andrew Morton , Jason Gunthorpe , Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Aristeu Rozanski Subject: Re: [PATCH RFC] mm/gup: batch contiguous pages in follow_page_mask() and return them via a pages array Message-ID: References: <20260730035350.1fc95dd8@fangorn> <517bf6a8072a6e66f28f8ec08bec4b604f29491d.camel@surriel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Aug 03, 2026 at 02:33:35PM +0200, David Hildenbrand (Arm) wrote: > On 8/1/26 14:25, Rik van Riel wrote: > > On Sat, 2026-08-01 at 10:54 +0100, Lorenzo Stoakes (ARM) wrote: > >> > >> Thanks for doing a human pass but it LLM's habits really carried > >> through > >> here. In general: > >> > >> - No walls of text please - fewer words are better, clarity is king. > >> > >> - Don't write the code in English as a comment/commit msg - redudant > >> and > >>   distracting. > >> > >> - Sensible patch separation obviously please. > >> > >> - Write as elegant/reasonable code as possible. If the code you touch > >> was > >>   some horrible mega-function, take the time to refactor it. Pay down > >>   technical debt. > >> > >> These are all things LLMs are extremely bad at (even fable). So they > >> need > >> to be done by a human. > > > > LLMs can apply those rules, when expressed in a way > > that they get interpreted unambiguously by the LLM. > > > > I'm slowly building up a collection of such rules > > in the kernel-style repository. > > > > AI can write in any style you ask it to. > > > > /* > > * Long in the Halls of Rq the weary wait, > > * till __schedule, herald of the turning years, > > * calls forth the next to walk the road of fate > > * as prev fades west. > > */ > > > > AI can also flag such issues, once it knows to > > look for them. > > Just the important note that people can use LLMs to make themselves > more efficient (if they think so), but not by delegating the hard work > of sifting through slop (code and/or comments) to the poor souls that have > to review it. > > LLM exercises should be done behind closed curtains without us noticing. > > > > >> > >>> > >>> In order for them to produce code that is at least a > >>> good starting point for editing, they need to follow > >>> rules. > >>> > >>> Once you apply the rules, Opus and Sonnet do not > >>> produce results that are all that different from > >>> each other. > >>> > >>> I just added a few new rules, so the tooling won't > >>> even let me create too-large patches any more. > >> > >> I mean, sure, but what's needed here is human Rik :) > > > > The 80/20 rule comes into play here. > > > > If AI produces junk, the person starting with > > LLM-produced code can spend days cleaning it > > up, without getting things in a reasonable state. > > Right. But what happens instead is that people think it's okay to not do > that work and instead workslop us. > > That is simply not acceptable, and we'll have to start ignoring people > where this is a recurring theme. We simply don't have the time to do other > peoples work. Yes exactly, this is the problem and this patch was a prime example of it. The theme here is 'please don't add to the impossible review load' or you will receive a >/dev/null resolution to the problem :) > > -- > Cheers, > > David -- Cheers, Lorenzo