From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47F80414A34 for ; Mon, 3 Aug 2026 15:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785770249; cv=none; b=FZZgZe2q8rtcI4RmlLDL0+hDtButQKrMS6ONAeKkm3xABFgdEyYdgeOCW0MV3XYWKE/sHUiiIa+RvCiuYVsJMjZ6b8weHokbc61tGG10oNhCEGYnr0Hkg/ir6btTRMZYFBldJMF4DKItfL2V/hWk4a7JSjWLLwkdn+dGhl1QZ60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785770249; c=relaxed/simple; bh=Tg2c5hSCmf4R8GHhniWyNjrjuYL6rS8mvKvO0Rjnhuk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nnzRP59H5RAQS0m3KR4o7FY+dxOtHdRXYT+x62qhChMH39VRqQQHH0m1MTICxoeFRxsRA6wumHCiPHXyClBZ+xNacg4mBzGvjUBvUNGTcPWgolmqPcvw6HGadIV003V7KhSktpxRTJ86uFCHNT6IOqnlTnXoS7+JVYKAN4pQbIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HLtiiPFR; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=mXU3yDj8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HLtiiPFR"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="mXU3yDj8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785770247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CISqUyNrQHnuig4NG6zWObmoUM7qsn/M6rO8iF8GMa0=; b=HLtiiPFR7LFQsK91jVncU4S7oyF8hjVlwtspPu+FUtfKWwJu7e7Ttij7NjZGBaFjZwa2bx obtlWHSJIvEAdEXhEv04cnVDcK4s/W9CIOckuNu4cdOeTPdK6cyoYYCv9X63A7mtzIow0S osw2MQ++0FcpUdRR7eviyz3/UPJVMfE= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-toL08J3LNV-m55MpWJUilQ-1; Mon, 03 Aug 2026 11:17:19 -0400 X-MC-Unique: toL08J3LNV-m55MpWJUilQ-1 X-Mimecast-MFC-AGG-ID: toL08J3LNV-m55MpWJUilQ_1785770238 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-81eedabbefcso118012647b3.3 for ; Mon, 03 Aug 2026 08:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785770238; x=1786375038; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=CISqUyNrQHnuig4NG6zWObmoUM7qsn/M6rO8iF8GMa0=; b=mXU3yDj8sgvW1Lz2y0uH3xGhrctJRqqPSLaZfb+GkguOPtEFs6GQWVeKOOyxzcZqnt wsSSxVcw595yPKu/cwJNHNrLr/9aScc4zZDOoalXviSj/zq0U7yvUg2jXeuRF/weLKSD II3tFVp9zhZs8eKOw8Xm5zfTG5yJoqIfCJTrkBv6oVAMJcTDsTDxaGvYsEKsJVh8ixKa +GNiv1yKmGPTdnICLq+Wt4fwPb/NJA0uNt6ntqQYfU2v2b571lRE9hlNbuTPtkbjxiTr r34uvbKP1F9WitGVan/aCGoJwLgpYKxbaJ9FFJRlAa6c5SC/ciLtuFau26pLhH8x0R0c l0lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785770238; x=1786375038; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CISqUyNrQHnuig4NG6zWObmoUM7qsn/M6rO8iF8GMa0=; b=XwSSu616rwOTqaIxB13BMu8tJL5KPnAbjKfvEKw7peTQJtFUkPKNydJLyoKtEs/SxL K6afNFT/a8h5pEqSETPJJmZx+zJmh2GFJWOuBTneT8E3rJLAY8OLDhIEKc426w77EsBf A++epnax5c6pgFr1jJPMrb5CgFMfKGFEgtysAHXaFhks0KjJaHi7fn4ew0q+x2DUwk23 mzPjejuPUJrusZDX6QgMMv6bt38YK8K/uPW7LxebxTBRrVYQhMtOqUSpR6Tn1vzi1bxR N22VRSvwYHc5ckQdGbfaAcs1OCVgfq8HXfRVHN36Up9N33q6g9ERgkbgv4B1qhdTKxcj tdNQ== X-Forwarded-Encrypted: i=1; AHgh+RrQl4oor8IxxYOZ89pBhn0x5ew19vBDA/NJXOr7cC6KXnt55i7vz/fkzx1ZDUF6kQH/eZjP3oGmCZ2pUzE=@vger.kernel.org X-Gm-Message-State: AOJu0YyiJEDmUpH8hx+7NDPod9qjQE0AvdPDvpsbV7xBmOyYq8hfWm4h WLHVa073PEoHvn/bA9yBJRqPQyEyK17vwh2Q3CdLdfR8KylMmnZXJwKBtu8z5Gv/Jb6HXclH5cq 7VxPB+1l/GtmQjb5Sv5V+yQTRjxslRE64m26fKLeDKCnIXilAU52ps9JQpqpqKBiayw== X-Gm-Gg: AR+sD10K19ZA+AFu2YQ8sxYJYTtsrmEDzJBZWomXFkIYZBvSUqxq3S8OcR4pyMFn1HL hxE2EQe7les5RRcTeAEdw92AkWzRyjQf3zL85YBTH51YOD7Vsze2nelv63UnKJx6UG1uIlhWWbI +QeQShI8VXWAhQxppjgaGjYdDoonn2gI5xRuxjcHs1CBAbFj2XUsmPCnTQ1IOQJVp9+3XrAs7vD 6oIfzXA75soVd/BjP7deEouBnKNVLSviRUB9YczlXd/0I+gwDbJaHsUVcFOMOV2vMBs8vf4uSW0 dm9jKOdG8W6ZctJyuos7hmAKVCHP41OOrLj32PRmGGxcWHHrYcmNnBmTPeUvJDajtUH0UgGCJHx WnSVnSZK91lglxROWLpDRKJvK1QqXRmaLDng= X-Received: by 2002:a05:690c:450d:b0:7d1:dd7b:b734 with SMTP id 00721157ae682-81fd4b5a2c8mr136703347b3.23.1785770238444; Mon, 03 Aug 2026 08:17:18 -0700 (PDT) X-Received: by 2002:a05:690c:450d:b0:7d1:dd7b:b734 with SMTP id 00721157ae682-81fd4b5a2c8mr136702797b3.23.1785770237899; Mon, 03 Aug 2026 08:17:17 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fccf2e239sm57358447b3.5.2026.08.03.08.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 08:17:17 -0700 (PDT) Date: Mon, 3 Aug 2026 11:17:14 -0400 From: Brian Masney To: Louis-Alexis Eyraud Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Chun-Jie Chen , Philipp Zabel , Edward-JW Yang , Richard Cochran , Chen-Yu Tsai , kernel@collabora.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Irving-CH Lin Subject: Re: [PATCH v5 18/25] clk: mediatek: Add MT8189 vlpckgen clock support Message-ID: References: <20260801-mt8189-clocks-system-base-v5-0-ac4410697cc2@collabora.com> <20260801-mt8189-clocks-system-base-v5-18-ac4410697cc2@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260801-mt8189-clocks-system-base-v5-18-ac4410697cc2@collabora.com> User-Agent: Mutt/2.4.0 (2026-06-19) Hi Louis-Alexis, On Sat, Aug 01, 2026 at 01:21:04PM +0200, Louis-Alexis Eyraud wrote: > Add support for the MT8189 vlpckgen clock controller, which provides > muxes and dividers for clock selection in vlp domain for other IP blocks. > > Co-developed-by: Irving-CH Lin > Signed-off-by: Irving-CH Lin > Co-developed-by: AngeloGioacchino Del Regno > Signed-off-by: AngeloGioacchino Del Regno > Signed-off-by: Louis-Alexis Eyraud > --- > drivers/clk/mediatek/Makefile | 3 +- > drivers/clk/mediatek/clk-mt8189-vlpckgen.c | 285 +++++++++++++++++++++++++++++ > 2 files changed, 287 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > index 9d3d2983bfb2..3b25df9e7b50 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -123,7 +123,8 @@ obj-$(CONFIG_COMMON_CLK_MT8188_VDOSYS) += clk-mt8188-vdo0.o clk-mt8188-vdo1.o > obj-$(CONFIG_COMMON_CLK_MT8188_VENCSYS) += clk-mt8188-venc.o > obj-$(CONFIG_COMMON_CLK_MT8188_VPPSYS) += clk-mt8188-vpp0.o clk-mt8188-vpp1.o > obj-$(CONFIG_COMMON_CLK_MT8188_WPESYS) += clk-mt8188-wpe.o > -obj-$(CONFIG_COMMON_CLK_MT8189) += clk-mt8189-apmixedsys.o clk-mt8189-topckgen.o > +obj-$(CONFIG_COMMON_CLK_MT8189) += clk-mt8189-apmixedsys.o clk-mt8189-topckgen.o \ > + clk-mt8189-vlpckgen.o > obj-$(CONFIG_COMMON_CLK_MT8192) += clk-mt8192-apmixedsys.o clk-mt8192.o > obj-$(CONFIG_COMMON_CLK_MT8192_AUDSYS) += clk-mt8192-aud.o > obj-$(CONFIG_COMMON_CLK_MT8192_CAMSYS) += clk-mt8192-cam.o > diff --git a/drivers/clk/mediatek/clk-mt8189-vlpckgen.c b/drivers/clk/mediatek/clk-mt8189-vlpckgen.c > new file mode 100644 > index 000000000000..8eda5331972e > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8189-vlpckgen.c > @@ -0,0 +1,285 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2025-2026 MediaTek Inc. > + * Qiqi Wang > + * Irving-CH Lin > + * Copyright (C) 2026 Collabora Ltd. > + * AngeloGioacchino Del Regno > + * Louis-Alexis Eyraud > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include There are also some headers that can likely be dropped here as well. I'm not going to comment on this on any other patches. I'll just list any new issues I see. Brian