From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
John Ogness <john.ogness@linutronix.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v1 2/6] serial: txx9: Drop usage of uart_match_port()
Date: Mon, 3 Aug 2026 20:59:47 +0200 [thread overview]
Message-ID: <anDksB-66XoEIToX@monoceros> (raw)
In-Reply-To: <01a84877-9cc7-8136-d5a8-e368a36cda93@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On Mon, Aug 03, 2026 at 08:27:22PM +0300, Ilpo Järvinen wrote:
> On Fri, 31 Jul 2026, Uwe Kleine-König wrote:
>
> > In this driver .iotype is always UPIO_PORT. So uart_match_port() is
> > equivalent to comparing .iobase. Remove the call to uart_match_port()
> > which then only has a single caller that is handled in the next commit.
>
> Not directly related to the change. The txx9 driver seems to have some
> iotype switch/cases as well so some !UPIO_PORT deadcode too.
So patch #1 could get rid of these, too. Will look into that for v2.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-08-03 18:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 9:39 [PATCH v1 0/6] serial: Some yak shaving Uwe Kleine-König
2026-07-31 9:39 ` [PATCH v1 1/6] serial: txx9: Drop noop probe function and dangerous remove callback Uwe Kleine-König
2026-07-31 9:39 ` [PATCH v1 2/6] serial: txx9: Drop usage of uart_match_port() Uwe Kleine-König
2026-08-03 14:46 ` Greg Kroah-Hartman
2026-08-03 18:57 ` Uwe Kleine-König
2026-08-03 17:27 ` Ilpo Järvinen
2026-08-03 18:59 ` Uwe Kleine-König [this message]
2026-07-31 9:39 ` [PATCH v1 3/6] serial: 8250: Make uart_match_port() a 8250 specific function Uwe Kleine-König
2026-08-03 17:23 ` Ilpo Järvinen
2026-08-03 19:22 ` Hugo Villeneuve
2026-07-31 9:39 ` [PATCH v1 4/6] serial: 8250: Fix corner case for port matching Uwe Kleine-König
2026-07-31 9:39 ` [PATCH v1 5/6] serial: 8250: hub6: Add cleanup code Uwe Kleine-König
2026-07-31 9:39 ` [PATCH v1 6/6] serial: 8250: pnp: Annotate init and exit functions for conditional discarding Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anDksB-66XoEIToX@monoceros \
--to=ukleinek@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox