From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66F49440A23 for ; Tue, 4 Aug 2026 09:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785837359; cv=none; b=AyUVpKF69PtbVrpa1iKTps1sOwKnTtwN2AY9R8lRvZulpPhhPzP1ZceF6MwVqHYgPdNY7B4rsuD2FS2tlHVPaz1wJouJ34dnGwp+uU6jdLNOjzT7pzAqrZLElm7Qi/RH5wDQjF0wpvHE7d8UXTIBd9CH9GxK6jRYNGcw1F40mZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785837359; c=relaxed/simple; bh=BdCQ7B6ms8+cZLFi44DRH277ZqfecQSQ8JhTAxDQzhY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eCDoVEh0kdcK2UTxE+EfN73Tjv2hXc09cZPIGUKUOnYPNzNGBo+b9i+2gOBQVUhyNYo49oMI4RJe9Kix3GZa8EHxuOQ67Am0Z/3K/z+vITpSqKKE/s39ul/D83y6NRm6v90Y9f8fre2tgZU/OGTBQLI817cjC7fr+kZeY9T9DC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=niUJn22K; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="niUJn22K" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38dc69c74b8so4158694a91.0 for ; Tue, 04 Aug 2026 02:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1785837352; x=1786442152; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=jbdEx1M+4FfJ4IeX59PvZeBMByZsH3JmFbsrDkmiAU8=; b=niUJn22Koi10Nv5ckuGGscWiUTsAG6SkXtcmbzYUbYnr05t2fmMiEQj0I2Rggn/XSz PBgrcBLL+G0WPTpw9lEz3yAU7ANDMy2iKCnWA/30Aj6m56CIvrrwC2f71NuT/OuLhNTx DE0CD3kEcq921lRunzveBvcMr4ZgJfNyZug0o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785837352; x=1786442152; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jbdEx1M+4FfJ4IeX59PvZeBMByZsH3JmFbsrDkmiAU8=; b=Ihbi/akYhOodaMOs977L/aj2cDcwYl6OfL6u4jDQwHNMjwmObzWltR648en6vLkz7b 1njVogmQx2mFgpyMBuZRcbzshOafFj1nEFDHQE+6EDeKrur6LSbza4JV+z6o5Kj130VE NyeSp57OC3/SbVczofpGcJlaioLh19crpxYCB8niWWOg4QTjbCVNraB5h6E16yYFKP3C I71XyufhFelQkUNWTINqhd7YysTF/eTKGu8ACfTDBinTs0hS/N/gdeLtmvmqsepDCszm k5DeisWS/3bVgdk2qoOW5KVyu8hobSuaa9kJbYty8bvAM1lINuHSEJAB4qJl/EifJvXm xAbw== X-Forwarded-Encrypted: i=1; AHgh+RoZxnSowO0vC8Ujq3/e/LCydnZPg9osbAvFpOtyXodeiKqXEL8VeTk91OyCVRsDX4uDkGa03n0nHfIsNvs=@vger.kernel.org X-Gm-Message-State: AOJu0YylvXjaow0wSl25pJZ7CPBW61uyIoKPxdGcea3qPtXT7zbZNaPu 8ddDgj3bw82LtQm6R2G5pZh9O0NtlQAuybTDW/oiOnDYZKCh2mEBaaA0w3vUPGIMMw== X-Gm-Gg: AR+sD11CHJQ8tk2NhP+AfFEedxoNGLEyyH8u/jKaiay2D11GX7kcFTyA5KSytycz+/x q1xIEXOom7S08GIyaCXu9Xd0zq4qtgisXcJILsMU6EI+rTQE4Bcw/Cyz7xtLJkCAVwpaYbJE146 Z3rnvT4KArsjXoNhA3pufORzq66ak40dcxJhkcDdG8mcmb7kY4aEdu0vPQD0YhoChb+vSIH5gSR iQQnoKcPtG2beBOdZBvxN/6h/RpgdrBJlsReIh2i6ri/UiGw8meSUXu/d/l0YW3GwcXH17CKx1Q efn/O5Y8tLJHJ7U9lqQ0yvBHKc2/KlFmClWsEj23y2Nzq85pVhwpk7OJEfOwb/RB6xtemhZwHKJ vfQy8+Mg1PytRSNcwKgwpD+UhMP4K3Zew9bekmU5FF/7t6/HqXjVa55bxhrxCBC5+dC2/raVQxG RetE7yNY7utHL6GneC7F5wtsRP+7+dfqjCphblpeKsKtUxaztmHqNOBwrnK6Un4Ye8/jQyON1LF zuxAs9o+8iLipfitF28ujBQMvNM X-Received: by 2002:a17:90b:3bc8:b0:38e:6497:ca45 with SMTP id 98e67ed59e1d1-38fbc59b19fmr11657536a91.39.1785837352272; Tue, 04 Aug 2026 02:55:52 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:32eb:b46b:e9eb:65c5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38febff7eedsm1076407a91.5.2026.08.04.02.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 02:55:51 -0700 (PDT) Date: Tue, 4 Aug 2026 18:55:48 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Haoqin Huang , Minchan Kim , Jens Axboe , Nick Terrell , David Sterba , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Sergey Senozhatsky Subject: Re: [PATCH v6 0/5] zram: fix zstd error paths and add parameter validation Message-ID: References: <20260803141256.60599-1-haoqinhuang7@gmail.com> <20260804093841.67920-1-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On (26/08/04 18:53), Sergey Senozhatsky wrote: > > Patch 1 removes zstd_release_params() from both zstd_create() and > > zstd_setup_params() error paths -- the former is a layering violation > > in a per-CPU callback, the latter is redundant as zcomp_init() already > > calls release_params() on setup failure. > > > > Patch 2 rejects zero-size dictionaries and prints distinct error > > messages for sz < 0 (returns the original error code) and sz == 0 > > ("empty file"). Currently errors are silently swallowed. > > > > Patch 3 adds pr_fmt to each backend file so that pr_err() messages > > are auto-prefixed with the algorithm name. > > > > Patch 4 validates dict and level parameters in each backend's > > .setup_params(), rejecting unsupported combinations and out-of-range > > levels. > > > > Patch 5 resets per-priority params on algorithm change before init. > > > > Changes since v5: > > - Patch 2: split pr_err into sz < 0 and sz == 0 branches > > - New patch 3: add pr_fmt to all backends; tweak winbits message; > > add missing SPDX headers to lz4 and lz4hc > > - Patch 4: removed inline algo-name prefixes (now handled by pr_fmt); > > added comment for lz4hc < 1 lower bound; added braces to if > > branches for consistency > > Reviewed-by: Sergey Senozhatsky Oh, and also Tested-by: Sergey Senozhatsky