From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE313E715E for ; Tue, 4 Aug 2026 08:36:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785832603; cv=none; b=FW4WUFiAHRKrtqclJDs9vM/62/ccjWTkYjCQTQMtiQZH87s2IWWdj0JPlrpFiq0RToY1g3c9xieS2W1GLh9dYQB/Adaw5JEanKuBPw5o6kukiyWE9LsqMVua3iyqZwVIf6P/Vo9p2Ioi8NWcXQFlcNkiAM0VaDeMgOlZfIqcmYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785832603; c=relaxed/simple; bh=5MWfV7JtZD8FvT2forTlTQOkThUV4gx53BSMGlc8wtE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZNcLcwsA8heVdkT9tyn4mAbOXmv22Zhz11CRv+N3UZephy8rgTbc+17tkQk2l502uquILKm76mj/nbIP081JjZqqlhnECHL7rJ4Is35ItBI/i/7WhMNnyQBmn7dShR4DVvOz7ajs24Pk9UtrZvh/lxd+V/C0rqw14l3LLEtTw9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k7+lPT8A; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jwSjSf88; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k7+lPT8A"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jwSjSf88" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6748CG6m3236495 for ; Tue, 4 Aug 2026 08:36:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=CtIYfvuQGYpPMIfnMPrF20Bg ArpUrPjM17HZ62h4ejI=; b=k7+lPT8A/gPTokolX0fs5Cqn5siQ7X9XX5HyLdfw B06p68pV97/se7TCwC9pJZ9lC7EzH4XDbSdaIU60uLblC3wlqtk3z8UZ9ya6W4CI r332ChGwVYFkTB1bnhW7pDea2Pqrx4Zj66BG/nAPxQlkan6h/RgixXs9oMOHCb3h DupWlGoPzhBmCe8rzulZ3suUGgIfASTEEG4+jHO2unL7c1NW9rTGZpUzB+c4FXoA w1O4I1Ta6mobHXNYHoRZ5PjpOz/X8wY2782+5DzpjZcPdcP85Wp7Kxoz2FnRIsNB v9dWVB6wM9E+C4EqY4oDSoKa67a5Xn0amsvrasb6kkuQFQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fu5hqsq2h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 08:36:40 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cbbb9c9bfc3so2374038a12.1 for ; Tue, 04 Aug 2026 01:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785832599; x=1786437399; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CtIYfvuQGYpPMIfnMPrF20BgArpUrPjM17HZ62h4ejI=; b=jwSjSf88uFUAd1hqOyo72dE+hw5WoUfr1u37qoI4dHvL1QQY1lnGQhA/WsxOsXHSNr /sK9/i+NORUVRb78/Djcbzq7/U29FcNvu8wu5yjZDnVx7vvMRWs5Yr/tJpBr6PJQiYGT fB3w3hL5gF8Cf1hU+JDSkREILuiSUfBSB+i1Nrfd14X0a0vZzEnSFBJmjRHJxPFG1/Gh uRAHdHEMM2jz/ogT2+BvUET4kxowI4I9EoD6SDikFtCsOh1M1pMwhLAytGlAU8TAVwdK ZLwDrims8XarlJccSBtiau85JKbanOezz+a8nvAjT9lKiP9xmv0l1ypv6zctTwOiyFEg 1YSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785832599; x=1786437399; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CtIYfvuQGYpPMIfnMPrF20BgArpUrPjM17HZ62h4ejI=; b=RZYswOh8ATx79tz3oBt6XplSaVysffEcaW0ZEhB9WoE4U9HPZ12hKVAsfFL0c11Q7w af+XNsmBd1sqFozwqjOMGxaUq0781yyGyN+H2bkl7GI6Tc/js/IIR3n4511dXxZ1/VyA 1Q6illvhlf5ofAtMYcDchT8twgIz4WmjM8qOVY5njpAh5gHEtY4pzvJJtnmd3qLE8GYV z8I1uOwOUzcoo4IY81qgx3wWTnfeFVRNCw1SfAAQP/hhuQE0RqGib9IeIPp7tsKtFEOv yIRy6ONJYRfSgmnf2uXk9yXGF9c8S9TEHMRNpR1Ep5bZpkWZepMWlrXum2rjqBMxZv05 fF/w== X-Forwarded-Encrypted: i=1; AHgh+RpfdHUDwog1ruFtFcf/NR4VO5KmXOQcqxA0vY00Q9U5wfcRUyTq61RdgcG/V5WRr4tJRrDfyjnP/WluVCA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2XUJmJ8My1J+2AGi5wVJNsdfMIwuHryrHnmv4pa1OKv/wdGZv Ag/DfU2cd2n5UNmPME4ZlA1vTr3eUtIUqHzIqfDNfpEUI1v5esByJkh63rdpGcAGP2bW8+BRTGG cGY275cPEgIN57TjBvdQdACnNhzC+JqinRtSouxR8L5heNSkbHZ6owT9L/t16Viz0Cpk= X-Gm-Gg: AR+sD11xc7SPlRaE1Po6EK8d98tn2+eT8MiCTsfHQRKKpg57ponEWNVIjYxfW5KDNKP IoFDouvB33WjYqsW+CvkoMlajePs+3mu4oBaiMy4F5CmMPjF7EnLUkyuGgUh2ZiBCFMPUlcEgwb jDb+ZvEE1fEBRzarivQGs4UChkrTzhuIOXtIRgj2Z4gRdXXm1yJqAhqN5BWKxiMz/8kYM/siCLA x99v16rqIlRYMzYd9eSK03hLBnVvaK/xvA7itAjEu+IRgaw+l73RuuOiegg8JqU8y9Nf+CwFLuG cCIX3fs+u9S+4S3Ov7Qsgip+9IA5y1YCUD61hkG0/zDOkB3r5c3hxNtk8Nm8riPYkiSZq2vFp6d hsaL3u5ahkuUs3A== X-Received: by 2002:a17:903:4686:b0:2ca:cde5:29c4 with SMTP id d9443c01a7336-2d0523fb501mr134870145ad.47.1785832599265; Tue, 04 Aug 2026 01:36:39 -0700 (PDT) X-Received: by 2002:a17:903:4686:b0:2ca:cde5:29c4 with SMTP id d9443c01a7336-2d0523fb501mr134869715ad.47.1785832598731; Tue, 04 Aug 2026 01:36:38 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d0a9ff4d61sm2987295ad.24.2026.08.04.01.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 01:36:38 -0700 (PDT) Date: Tue, 4 Aug 2026 14:06:30 +0530 From: Mohd Ayaan Anwar To: Konrad Dybcio , Krzysztof Kozlowski , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Wasim Nazir , Mohd Ayaan Anwar , Umang Chheda , Yijie Yang Cc: Loic Poulain , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Fix regulator voting for the Qualcomm SGMII SerDes PHY Message-ID: References: <20260804-b4-sgmiieth_serdes_regulator-v2-0-c4bc688177dd@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260804-b4-sgmiieth_serdes_regulator-v2-0-c4bc688177dd@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDA2NyBTYWx0ZWRfX3l6ky3YLSgsq ObGo7sNmJKHO2uvJOagLofo6Wjn3QyWIAQcHgvR6T+SkuNCxIKyvBrIPKklfkOHmWiAH/c62NAM BXbz7T6p/fn8gcPl71GG2hPXMAZ+uUI= X-Proofpoint-GUID: g9oC95_zbqX8N0sRKA841jRbl7y5RzOY X-Proofpoint-ORIG-GUID: g9oC95_zbqX8N0sRKA841jRbl7y5RzOY X-Authority-Analysis: v=2.4 cv=EoniaycA c=1 sm=1 tr=0 ts=6a71a498 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=c92rfblmAAAA:8 a=EUspDBNiAAAA:8 a=qZ3wfW_fQ0jb69Zj-6wA:9 a=CjuIK1q_8ugA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=GvGzcOZaWPEFPQC_NcjD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDA2NyBTYWx0ZWRfX6ttKFqFsrG23 tNXswh+oz7RMh2qIdA/qMemB0EKE8wqTM56lFI1uJFK+0cYaDpJWWMkiF7s8lPiLfGosRu/XGJ5 lx/hXMN1ba/cA065Jd3s03nOMbd5+ILJnUU0u+ZFR6LwaP4GshrcjTxftZCPOn4KQF0rXa9ca3Q 147JvVnuOLkTTC3ee5ogI60m14feG4h2+HUsZYCckJ4IQUNzZxXTVTBThYxUpx4u5pk9DhShqAk vIVcKbaEdZuqMPQgkgqaUt0ez5LDiqFZSYYCLH1vygaV7vKGViUC2anuJoFQIgqn4wGuUZMMmzT yJLydJutlG5pf2FuIiTpCQ2SaUrv7k95XP9eZ7Zr9+tf0Rbn4a825I9mQiy5XhHBoond9SjtFjP 9EbWRepY3aN0h0shnWSm4e6jeLKImUsBHagHuw4npbgr+fP2xVbgawaLLeFP22GyBtYtvF2shn/ yGChVzdZyP1i3QwpFjw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_02,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 suspectscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040067 On Tue, Aug 04, 2026 at 12:57:56AM +0530, Mohd Ayaan Anwar wrote: > This series corrects this by: > > 1. Fixing the DT binding to describe both named supplies. > 2. Fixing all affected board DTS to use the correct vdda-0p9-supply > and vdda-1p2-supply properties. > 3. Adding bulk regulator support to the PHY driver so it enables both > supplies and sets the proper current loads. > > The patches are sequenced to maintain bisectability. With the driver > change, the PHY framework will continue to vote for the regulator > described by 'phy-supply'. The DT changes which follow then remove > 'phy-supply' in favour of 'vdda-0p9' and 'vdda-1p2'. > Sashiko raises some valid concerns [0]: -- 1. This isn't a bug introduced by this patch, but I noticed that another file in the tree, monaco-monza-som.dtsi, still has the exact same configuration you are fixing here. It retains the deprecated phy-supply property and lacks the required 0.9V rail. Should monaco-monza-som.dtsi be updated similarly in this patch or as a follow-up in this series? 2. This is a pre-existing issue, but does registering the PHY provider before setting the driver data create a race condition here? Looking at the end of qcom_dwmac_sgmii_phy_probe(): provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); if (IS_ERR(provider)) return PTR_ERR(provider); phy_set_drvdata(phy, data); By calling devm_of_phy_provider_register() first, the PHY is made available to consumers before phy_set_drvdata() initializes the private data. If a consumer (such as a deferred probe workqueue) concurrently looks up the PHY and immediately invokes an operation like phy_power_on(), could qcom_dwmac_sgmii_phy_power_on() read a NULL driver data pointer and cause a NULL pointer dereference when attempting to access data->vregs? -- For 1., I can either post a follow-up patch or add it as part of v3. For 2., this is a genuine pre-existing bug. I will raise a separate patch to move phy_set_drvdata() before devm_of_phy_provider_register() to close the race window. Ayaan [0] https://sashiko.dev/#/patchset/20260804-b4-sgmiieth_serdes_regulator-v2-0-c4bc688177dd@oss.qualcomm.com