From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lgeamrelo12.lge.com (lgeamrelo12.lge.com [156.147.23.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75C0B48B37E for ; Tue, 4 Aug 2026 17:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.147.23.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863014; cv=none; b=ehDh5BIy0qix/Etw2m1rVtiLGDOD/a/rUAtftuu0oC4sv6SEzkP3hlIYkOV8zEn0Op++gG0PSRzZMuxH2/2Vmf/68q5Fb24kJVL8lsa8S9WnhdpUXS8Jg4Kzfa+ZQ/Szq5ZRNJSFQ8SpePdK/29U0duXYT1yH9Hc4DSBzzLHZZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863014; c=relaxed/simple; bh=NYDMnNC3t0NWFnHR3FWvf1KekHxPiQTXp9H+OysdqWw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lD/DGgd46tXDPpf5s19wOroNJFB49VUdR/H5WMFFBt9u5PhlNQuwseaGAeWf3mmd1keNLJPEwaCgYbX06lWcfE6lxS4ACqGlbi/XrU+NEdanCct1qYExS9cf58Qu6sPpd+x8mPTsG42p9nFsNZS62/nuhKXqJXLqbwpwHLVs1eE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com; spf=pass smtp.mailfrom=lge.com; arc=none smtp.client-ip=156.147.23.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lge.com Received: from unknown (HELO lgemrelse7q.lge.com) (156.147.1.151) by 156.147.23.52 with ESMTP; 5 Aug 2026 01:33:21 +0900 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: youngjun.park@lge.com Received: from unknown (HELO yjaykim-PowerEdge-T330) (10.177.112.156) by 156.147.1.151 with ESMTP; 5 Aug 2026 01:33:20 +0900 X-Original-SENDERIP: 10.177.112.156 X-Original-MAILFROM: youngjun.park@lge.com Date: Wed, 5 Aug 2026 01:33:20 +0900 From: Youngjun Park To: Barry Song Cc: Youngjun Park , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/swap: fix stale comment on swap_info_struct::cluster_info Message-ID: References: <20260728155907.391820-1-youngjun.park@lge.com> <20260728155907.391820-2-youngjun.park@lge.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Aug 04, 2026 at 05:51:52PM +0800, Barry Song wrote: > On Tue, Jul 28, 2026 at 11:59 PM Youngjun Park wrote: > > > > From: Youngjun Park > > > > From: Youngjun Park > > > > setup_swap_clusters_info() allocates cluster_info for every swap area, > > not only for SSDs. > > > > Signed-off-by: Youngjun Park > > --- > > include/linux/swap.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/swap.h b/include/linux/swap.h > > index 2cb1d29307c5..e12c73891b48 100644 > > --- a/include/linux/swap.h > > +++ b/include/linux/swap.h > > @@ -246,7 +246,7 @@ struct swap_info_struct { > > struct plist_node list; /* entry in swap_active_head */ > > signed char type; /* strange name for an index */ > > unsigned int max; /* size of this swap device */ > > - struct swap_cluster_info *cluster_info; /* cluster info. Only for SSD */ > > + struct swap_cluster_info *cluster_info; /* one per cluster, on every device */ > > Do we still need "on every device", since it is on every device? > > Thanks > Barry Hi Barry! Right, Will trim it to /* one per cluster * Youngjun