From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7150F48986E for ; Tue, 4 Aug 2026 18:13:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785867235; cv=fail; b=RFpbFgzhgp/WoS1tN4x7wWS8XnG2PI/r9XSXb7OXGlFYla6ZdsdmxHiSZNfnU8vzeDJcQ/bXzBcRhXzyuHpzW95VwWvAQ+ZZ3IFmDcng+5zK5y4aXC3/gKbXHn4/s+sXnSPjnPiELLRjYGPW/4Q4w0Qrqf4T7w+BDG3R107aebY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785867235; c=relaxed/simple; bh=PT0P9RxZ61t9R9qU+RovTKzLXPaSwMLMKpzAAL6rPaw=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=rpIF76IH+6u4DHQGUmAbAF/INUklPelh1kaKxdLlZQNjD2HEsk/KMa6MqVDrgktuhrIoofPPwykXb3WX86SZObyj25h5ZUid+FYGVg0w/1juQJoH20GfTBb/Zm6e0XCnlwG7KUek1oEwtMP9Ao5Wj2GpDIsxe7Z2MOFGE8QF8Rw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UgW1t4Ju; arc=fail smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UgW1t4Ju" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1785867233; x=1817403233; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=PT0P9RxZ61t9R9qU+RovTKzLXPaSwMLMKpzAAL6rPaw=; b=UgW1t4JuYegNWg/V19KoYN1tBXH3EekkR1B2oVyjjmiGN5ynNiLoGO4C 7aO1Z11roGnfz2VL4vpIpVu0JHbeQghqa6o7vMcCRdL46ND9802hsnEy9 hLBNadojCIbaSonISPbHz8s0ngFyEYoKDwlQOOkXKokjIY+sYjLV3DY9N UPjLVGL0VrWF3T3lciAdo3cd3A417FWHm4+uJrIfGVi8Ul0dvM/uC0PPQ Ki3nQyspSXHJCa3Xl6VhmUNBPDXbmhTlpC67PX1B4pdEZB1OeOJX2mKSV puhUfEuHS7EbHH2zInz4fkplcoxdM7HhpSxMzS0pq5kfA3Bi5bQfYl7yF Q==; X-CSE-ConnectionGUID: 1nTC5bRQSsS6t5vkxTLIKQ== X-CSE-MsgGUID: W4qN5t38SRm8PgrFKtFtLQ== X-IronPort-AV: E=McAfee;i="6800,10657,11865"; a="97933616" X-IronPort-AV: E=Sophos;i="6.25,204,1779174000"; d="scan'208";a="97933616" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2026 11:13:53 -0700 X-CSE-ConnectionGUID: Zi3kSbDLSv6xdtuAa837GA== X-CSE-MsgGUID: AN3gOrnCS3OOke4IXQJHLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,204,1779174000"; d="scan'208";a="286221668" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2026 11:13:53 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 4 Aug 2026 11:13:52 -0700 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 4 Aug 2026 11:13:48 -0700 Received: from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.33) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 4 Aug 2026 11:13:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DBZFVUnruorVfUsY4gMu+Kuf7+eJ5z/y/7QPIhKD/LJgVqHp7TIIpsgBsOGJQ/CeZ+qgbYfY2AJUEtYuqM3/J7mLIT8f3RelT/RplV+G9KDW1sxlMV/PKEXjNC3wdXpcKqc0zccLN0JjYZwiDmJ8S8Hv3AWDLRPq8dWA3PDy5DtO2vF2o30gHu1twopeJmR9bfg7QujWzDg4rJ7+3NFNBPAZOVXMGqTLOrIDOyFAeB1guCE/ELbvRuO2CqNUwJw2ekvD+Wejr9gxl4jA7VXK7FxYxfD5KYyuWD7F3feP4lFVaXVo8KYJq9c3i+agS590ZobrxSAzdNNONBSDXc5dZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CDWV84t3CRy9OcuFTXcjf/yGl/BxUaCxW1iglZ3PLlw=; b=aj1xhXDrj1P5+TU0qLdUKtebkQ/zZR7ghKybeuW8Ak26u70TxHWGilHGAbmA1M8oWCZAkA0eM/pPbcunz+56vMjulPeyq6/mjWxTco9/p5ksjyUyEoDaRrS5WHrW0C6l9nO5lM68OeXBRYc7VydQ6mDY9gMw3FwoAfEP6QbgypHXVVHhy/PjlAJrIO6tH9IKimPX5wu1YU7Xerd0seM11v+xB5if1zyhyfLvDcXMaFO2unDuuWH8tRseyZhqiKhcv3FOxs2Z/xlUXbWrorkIOc6iMdWOIqkZ178EjhuelQgu8HsuB+Ew++rYj4M1hjnH6ZnKe28K5Dp2zw4VWy3jvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ1PR11MB6083.namprd11.prod.outlook.com (2603:10b6:a03:48a::9) by IA3PR11MB705945.namprd11.prod.outlook.com (2603:10b6:208:626::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Tue, 4 Aug 2026 18:13:37 +0000 Received: from SJ1PR11MB6083.namprd11.prod.outlook.com ([fe80::3454:2577:75f2:60a6]) by SJ1PR11MB6083.namprd11.prod.outlook.com ([fe80::3454:2577:75f2:60a6%4]) with mapi id 15.21.0270.017; Tue, 4 Aug 2026 18:13:36 +0000 Date: Tue, 4 Aug 2026 11:13:35 -0700 From: "Luck, Tony" To: Chen Yu CC: Reinette Chatre , Ben Horgan , James Morse , Dave Martin , Babu Moger , Fenghua Yu , Borislav Petkov , Thomas Gleixner , Dave Hansen , Peter Newman , , , Subject: Re: [RFC PATCH 05/31] x86/resctrl: Parse ACPI CMRC table Message-ID: References: <0189d930c672498480557c5c16efe42940a06b5e.1785680802.git.yu.c.chen@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SJ0PR03CA0292.namprd03.prod.outlook.com (2603:10b6:a03:39e::27) To SJ1PR11MB6083.namprd11.prod.outlook.com (2603:10b6:a03:48a::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PR11MB6083:EE_|IA3PR11MB705945:EE_ X-MS-Office365-Filtering-Correlation-Id: 99aa75ad-9d07-4195-a9e6-08def2541a6a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|7416014|376014|11063799006|10067099003|4143699003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 9GPmHEVuHL0QTCTgDaJU/ieJF3oQbMjnC7BZ3A4+Su2+veULinuKQi0hQCelBgdWMZnmBm07p+LnNJ/qDpmpmRwfmNubYiCXasCDDrzFyVr0e/3p7S/LpxIk1HQehh9B+3JubXjltd5mnA9rCMLz53alxXUHqsnlv54ZRzLTYUfJfzEPxAivV5dDFgNdNDAzWFDbYlubnQCPFiot70X1gt2EMgCwU/D2IikMF/3InKTg6LZumGW/h85roU3VA7Xki6YdoUvHY4GR+i90vMes6rlYMmeJGLam+w0NPY6e05pXC0P2ZLdgwbvX0lQMH7jfOami2CTpym/jpiMzd8WZdlCuaAsHaUrEPq8njjtc/Q43NeAZ4j8nOB+QgJZRWmXGhdwV1Z5gSaRq8H5atVSQpTZMfvy4tpmYaWTSoEkUMWLOYJ40bmc8B6C5Lwzrz5Cg8op2vfD2vTrxSi0NkDc/9wHdecKqM623ZsZEmdwkxxPy+s6hZUIQ8rtTekwXszf/OPREIiv8MiNQX4R0JkYNX9HD0DgskYf7t6W2LkjzzH6jccuxa447eGpKtx2JwCTTISg+QpBnSfH4BAR9kG48tmRUAuw7y+NZswQ3JPDmcOFJrwTQ38yVtzbqVVywGnoSrZ87VlKyl+f1ZROz8iUKbGo1Ha60BvajgkLI0IfDXi0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ1PR11MB6083.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(7416014)(376014)(11063799006)(10067099003)(4143699003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zrRJd72uJ94+i2lbFvHKO3JHd6MyfLBdQL4kCd03ESg7tsd2X+78rBvuiWE+?= =?us-ascii?Q?kN7rUppfciIdTqaY8t60EHkXzdhAeX1/ircvzmhdzF5kekJ9Y2NXrZi1/p3b?= =?us-ascii?Q?xGjZOk6eqUOKrBY+TauHaDnxLb0I1IErdTHr+3nwwICRhSfKQ25Wkt05P63J?= =?us-ascii?Q?zSwvN0N1H/KFZSwWOZo73/P5h9Ogfp88uN6EB0aVleuZeSJe0dH8Nlmfkr5T?= =?us-ascii?Q?FtfjHZCu5ukoh5+NkcCBqzXm6VmDXZm1PA7fRQ+Dzx/3MNorJJcnMhIOpg0j?= =?us-ascii?Q?f4RkXIj+P1lITUO2rbyKV4EHpY7zYqN+/qET76j5JixaXLtpJ1qqdQKtkS2X?= =?us-ascii?Q?QocSzN/fdN1BAbmjJDN+f8CIE3ZmQKv6FsZn54K2SUqN8CtHfRjw+qUZ76l7?= =?us-ascii?Q?1Tylj68SezbjfwLcoMsvXRD1Rd63BahDpMAatGp+icdYtHQag86+3SpDZTcS?= =?us-ascii?Q?h2vRievrD21hKWbZAM+dBhNwLATE6WxLsz9jewP1YPvFQoxXz03EeGuG2S8r?= =?us-ascii?Q?0amBGcEIn07KS/CiSRvW1rszvJzXSwHyoRKCRXqPhvb6uGurL7anXDiQc977?= =?us-ascii?Q?FASUKfYoIvnQENsziv49GfQDJkneFoMd/v8N5TJoiaqVHYSzSg7UaAXtv7Zc?= =?us-ascii?Q?u0REK/F+inOrQahad8Au29bTlfOzahrWLRyOGMCKh3k/wiJawlYrODueMZOu?= =?us-ascii?Q?dDreJeuvy/hXjSS8c3Haysa5kH4PT+NPsCp5l/YIjYLpaUZnwG2bwoDwTX0k?= =?us-ascii?Q?qm+ZDeAA7YCUm45TLae8/QdVRpUVrLTiEyUyIoK7x5v8dY99oIUg2rUyBIEz?= =?us-ascii?Q?+wLAXwd9ttOJt/Uzn3jTB/W2dBLYGWKvDXp3lp4IbltRr/FtWYxFI7NSBkht?= =?us-ascii?Q?VwtqaIKCHPjMZUKaZ/++qd/VL7bvqpK/Jr2Q8UwArWNqhFmAg6HsZNMN/d4G?= =?us-ascii?Q?CuWPQbH9baZyHMH1I06feDsVlRM8W4RIuyWltbiweDDOM/sfs1nvP4DCP9x9?= =?us-ascii?Q?ZQflVAtpKWroRLPcEm33XexCx6ogUzG8uBHio16bYpfvPlQtXg/FckZoulTF?= =?us-ascii?Q?vMkZegDXbusmlgLu/zwLRpW32kyvW47hSZLMRFSFLjwX76uxxrIBq5QmqaVz?= =?us-ascii?Q?brn3yDzcIl9Jy9Dk1KCLgxRqEqMbi40Bmg7/Dv69oIaZT8ZlsJdL2uYel5Y7?= =?us-ascii?Q?mufG1LuI8zTXnaLlFY80ZtM+rvHXc6GdBnjPr94KoZCBteHnCH2gPvylYayg?= =?us-ascii?Q?QEjmg2vvEqLUXPMi0xjcagAdX3nzBeYvj4R3rYv7kO/o8/ScyUytQqZwkP1W?= =?us-ascii?Q?CEYT2dt5YFn7T7uG/56Eg0uRms6GYG3xcpGf4SITgTZbZQOUEOc3uPPPJI6W?= =?us-ascii?Q?t1GWfVMoJB5P0EKwmD71ir7ChjLQPPO87HsYS6tyXUcIEvqN/0x7DW2Mj+wz?= =?us-ascii?Q?/sPmEeiVEz2CDZd4IQH76XJ6z2dIyeH2je1t6cMO32kavdf6QrAwwgjdZfrP?= =?us-ascii?Q?TWaF214sxhyHQpaFlKEI/GEofAhQPVXnvOB8kU9V7cTT6WZC+JSt55/P/hAF?= =?us-ascii?Q?nUxpHmbQbccGOI5eiiHc6E5h1e4FtOTHzhtkAmTNMobdwCtP3FYPuTcfOPnt?= =?us-ascii?Q?O+Wcyme95j9K/dTV4FI0g/9F9NXjzzmouKz346Jgi/lbUmwty75uRKGCkXoc?= =?us-ascii?Q?PdRIBxbZlsKu9vFicfVhtzUZbq3IIexCmFRux00/MXciQalehKwjfGoAShgq?= =?us-ascii?Q?nxBJRN1MGQ=3D=3D?= X-Exchange-RoutingPolicyChecked: hW2ERGRtL2nAra/ipK2maNZxd1k472DtlPVr+M4LtIV9Bp4DG2jktVVxQFzp8ECmAY3uJAusbqSZqkAFbXp2mtuaxuiiHtmOMRMfyR5FNlhOBcbXfRb9wDCM66Bd5PRj2061nPTxfIgHPXDo8WozvdAsUN2WTuUJzxmAw5A7ofIyPLOFmiCAlLVCDXHiVsHYVZFewxS2LpvBuN31ky3s289TDPRuQP4bTUNdzZ25F08TlabLfrKJsvSX1RW9yvz47IcNzWurmuiEWp7rBBZ+6yz2Q/d8PbDw4Osxvt71K28a8wrDxJbgjUUZ9S7tolF4CTgkJFafAE831q7OPTQpeA== X-MS-Exchange-CrossTenant-Network-Message-Id: 99aa75ad-9d07-4195-a9e6-08def2541a6a X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 18:13:36.8706 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z/LuGxJSO6Cf7MQqQ/M/iIYidcqZjoIawN5PHHsd77EXO1BqgS+po9B3KaHS3WSdo+ULAMkKLsyLZ9HJH3iIpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR11MB705945 X-OriginatorOrg: intel.com On Tue, Aug 04, 2026 at 10:19:26AM -0700, Luck, Tony wrote: > On Mon, Aug 03, 2026 at 12:03:48AM +0800, Chen Yu wrote: > > > > +/* Scale to bytes for the monitoring counters when ERDT is enabled. */ > > +static int erdt_scale; > > Single value for scale? See below. Now I've read ahead to patch 9 and see how this is used to set resctrl_rmid_realloc_threshold. Needs better comments here and for above erdt_get_scale() > > > + > > int erdt_get_max_rmid(void) > > { > > return erdt_max_rmid; > > } > > > > +int erdt_get_scale(void) > > +{ > > + return erdt_scale; > > +} > > + > > + erdt_scale = max_t(int, erdt_scale, cmrc->up_scale); > > I'd expect that on a machine all CMRC tables would report the same > up_scale factor. But RDT architecture allows them to be different. Two > ways to handle this: > > 1) Check that they are all the same. Complain if they are different and > don't enable cache occupancy events. > > 2) Save the value for each domain and use that value to upscale when > reporting to user. I see in patch 9 that you do use this option "2" with "cmrc->up_scale". > Picking the max value doesn't feel like a good answer. Given how this is actually used, seems like the best option. > > > + > > + return 0; > > +} > -Tony