Re: [PATCH v5 4/5] phy: qcom: m31-eusb2: Set phy type to EUSB2

[Thinh Nguyen <Thinh.Nguyen@synopsys.com>]

On Thu, Jul 23, 2026, Krishna Kurapati wrote:
> USB controllers like DWC3 are agnostic of the kind of phy (USB2/eUSB2)
> connected to it. Set the phy type to EUSB2 to let the controller know
> the phy type when queried during its probe.
> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> index 0bec8657149c..158c3a55ba56 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> @@ -16,6 +16,8 @@
>  #include <linux/reset.h>
>  #include <linux/slab.h>
>  
> +#include <dt-bindings/phy/phy.h>
> +

Same here. This is already included in <linux/phy/phy.h>

BR,
Thinh

>  #include <linux/regulator/consumer.h>
>  
>  #define USB_PHY_UTMI_CTRL0		(0x3c)
> @@ -277,6 +279,8 @@ static int m31eusb2_phy_probe(struct platform_device *pdev)
>  		return dev_err_probe(dev, PTR_ERR(phy->phy),
>  				     "failed to create phy\n");
>  
> +	phy_set_type(phy->phy, PHY_TYPE_EUSB2);
> +
>  	ret = devm_regulator_bulk_get_const(dev, M31_EUSB_NUM_VREGS,
>  					    m31_eusb_phy_vregs, &phy->vregs);
>  	if (ret)
> 
> -- 
> 2.34.1
>