From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCD3E26ED59 for ; Wed, 5 Aug 2026 04:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785902621; cv=none; b=Go9CHixF21NZ3PoLFsc8jC0e3T6UxNAqCzUJZ8r0qPIr8dr8BIYJBDQVJI6jQdvM1DvEW6UfVVESC0GRSNlSiKuCw94vK7kqysI1bJ7SxX2DVAxTwi7Y0/2cNlo0IOILb4Z5Qosc1bqT8Yv6ajxYnBHuu/FsVwc7p3kmzCvp2T8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785902621; c=relaxed/simple; bh=RCacXLcQzLMkZt/V4onImpot57AhofGIO21OqzIF1Vk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=QgzJi6RPJdbpC3g4jIg4x/zBiXZfEX7j5QBhEYauUZG14NrCHMR5euYqDjyb4sq7hgnqrKTbxTmkPkwNwDJZyh8FW3GH3jFA/A+HDhZqfsSP7lBeE+k9adkhGfp+/MI/0g1iB0sjdAMC5ckb/sDPbTonPk9tVNR93T2Zm0Wg5yc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S7KKniPS; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S7KKniPS" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38dc69c74b8so560798a91.0 for ; Tue, 04 Aug 2026 21:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785902620; x=1786507420; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5emTV60DveNs6kRLEdh1K0m5cgWO3OGrdXp8a1oXBuw=; b=S7KKniPSigH6nzWZsJ9VaCAk+cf/Ukts/71wy2vMK+5ZIXsiqkCo20EPDzSceWzgmq Hs9ytNzflpHEVCufgnD9qhl5uV4oFf1sXsa7BkT6O8KX2zWJiABC8mNyGbj33Zslwn33 xTFz2xzqKBaPqThlleRyIzk4J86fKkVbOmtlpKmdgpXBaX6XoTZPbZMrVpNOBcBeYnc5 WPdbtvpLcNwBpVvuMuSrKcNp035nMxPBFReuhUm1XS1gSzacfjtJKLwUcAvCqeVAXvsT 5H6F5vOA5i/oAHqHHW0LFq2bafIqYUmIUDyGFsbERj0leMvV1dvjqOye4PqderDq4LNg CuKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785902620; x=1786507420; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5emTV60DveNs6kRLEdh1K0m5cgWO3OGrdXp8a1oXBuw=; b=g6ozEag5xUPz3IjaInoTpS+D+54Lr+Ye9ib0LCbqor6ui8srNvkJQY8Ar4TihZSm1G o240Jvw7GSy/vNGClA+4SlDOLiAhRuDKTUQrCd23cTJ6ciKy1OHzI2VrSYtFmdWHGeWA SluW9fNhnv77snA81hypqGkbFoXXZRBeQGNr6AdfOUzwo8weBsLbxmADSX5RTzlYbkQK gXG7sSZWG7MZKdYMwyYeOboVIBIBsq4Q4jjdZE86Xv+N2gCg9Lh5/jCZmb1YNYNWl8s2 kPF9WbgGsjQNiwdTq9hd7svSG4GqwXbUr3Gr1AKBxi1xwUYGuG/73tIuIAa4oELrGNCL ocLw== X-Forwarded-Encrypted: i=1; AHgh+RpsE6Df0NvYl8bzRn5bucNH6zo7ZfCS0pXowrZhMoqDB/5bEufbRDsnwzZaiyHIyXCvGU+eDSZVVu/Rw2Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyblmY23CQYEe4Ri7DOq+K77GLSaFQbBdlADCIl0xllBdRovERA 43cB+WdR2Hzm3ohzPK1u5JNQDF9uthiAwkc2aWZ5HFzw/CwI38XCqO7o X-Gm-Gg: AR+sD11Qynj7h1QdDWsGB9mjoNn1bGbsmuC3Z3KPEzPYPwlwAjPrAxjeJ7QWl8XPicN nH9DPBb9oSZBo/JZXgfW+DChrx9TDjI/tQY1GGe2zkgqqgAL8Jq/A2dQy9mz3HC6tJk2IzC+kUf CEiZStgXq+i4F5pziUX3inRr/qqTmS80QTQc8GPkTZr20bDCZ8B9wFLjG+3D1daL5Lmr02i8Ht6 Z5NkpysQukqq3shJ/ig+92YMN5fBEYbPWml5rw7lCTepDvXfzPWN7bD6jCOYeXjOdzUOPNKYQOE U6EO3IJ1/GcbNbjCGcq2JUtSjdGehnHXDc4RQo3+PAsu6zAElcQDC7L4BdILVwBbZBD5j0GtaUn dKCKRduVXc6fZTobIE+7yFVz91hrok3qs7hCa8CpcXR4tLPKaJq/0RzciftxO+yFMs93G5rwgo+ hkvxhjlwUGUM1fgzYwNmm3A2pJeSb+5S26LhsuWSHwh/ef50rklbii0UFi8mA9455nDcIpX+NhO 5YG15O869b6+/ah8txZb1gc78nw9Q== X-Received: by 2002:a17:90b:52c6:b0:38e:75f3:ad4d with SMTP id 98e67ed59e1d1-3903c5381efmr3687413a91.7.1785902619905; Tue, 04 Aug 2026 21:03:39 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:bf3a:ac93:79c4:84fd]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fca508a48sm8323396c88.1.2026.08.04.21.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 21:03:39 -0700 (PDT) Date: Tue, 4 Aug 2026 21:03:36 -0700 From: Dmitry Torokhov To: Mark Pearson , "Derek J. Clark" Cc: Henrique de Moraes Holschuh , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Nitin Joshi , Andrzej Pietrasiewicz , platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86: thinkpad_acpi: Use input_device_enabled() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline From: Andrzej Pietrasiewicz Use the new helper. Inspecting input device's 'users' member needs to be done under device's mutex, so add appropriate invocations. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Henrique de Moraes Holschuh Link: https://lore.kernel.org/r/20200608112211.12125-7-andrzej.p@collabora.com Signed-off-by: Dmitry Torokhov --- Not sure how this got stuck in my patch queue but it is still valid... drivers/platform/x86/lenovo/thinkpad_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c index 445e1403308e..f8e116e8a65d 100644 --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c @@ -2547,9 +2547,10 @@ static void hotkey_poll_setup(const bool may_warn) lockdep_assert_held(&hotkey_mutex); + mutex_lock(&tpacpi_inputdev->mutex); if (hotkey_poll_freq > 0 && (poll_driver_mask || - (poll_user_mask && tpacpi_inputdev->users > 0))) { + (poll_user_mask && input_device_enabled(tpacpi_inputdev)))) { if (!tpacpi_hotkey_task) { tpacpi_hotkey_task = kthread_run(hotkey_kthread, NULL, TPACPI_NVRAM_KTHREAD_NAME); @@ -2566,6 +2567,7 @@ static void hotkey_poll_setup(const bool may_warn) poll_user_mask, poll_driver_mask); } } + mutex_unlock(&tpacpi_inputdev->mutex); } static void hotkey_poll_setup_safe(const bool may_warn) -- 2.55.0.571.g244d577d93-goog -- Dmitry