From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EA9C3B5307 for ; Wed, 5 Aug 2026 04:33:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785904433; cv=none; b=HtrJh3JKdgm5jmW962anqloqk+Q0cYRoKFfLkg8voekRPz/tqLzXBlHtQ3OWTgco3qGKx9RmqZE0dnXXGpY9Ss0cOkik6FZZn3rnqyQcFi9/djo8TdWJ5EhNKr68zP1ytVJ1gENjf9zrVdwLjJFiPeK3VwlrocFaZIsm7RK21B0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785904433; c=relaxed/simple; bh=hmPVkxHG0GAgX7S5j0UfseU867TpcLXvRK+Y2JAHh50=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZFmLGiL+OfQSuX2BqSp9UjQgFSc0W+i+igy7nPZXYmHDHgY7O1XJIGm4/XJC+6FE47DkETYFNj1ARLv6XJjMTxN/PDzTIzJ6qd+wx6wDxnswf0ZnCGOBW17BM5gHzQmPjmdfospfwC1shw+ccEVo+L1DEUq3NtgPWI5UHHV00tw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qw5pxP2y; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qw5pxP2y" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-8423f236418so475173b3a.1 for ; Tue, 04 Aug 2026 21:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785904432; x=1786509232; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=L+VSIt/dK4uaFU6UoLSPrTrRpY150XN2pn30jvRWAek=; b=Qw5pxP2ySPYDEsCusknMzs54qVav0CARSAubYbI5ME8i3VJtd3FPc454FMzRmBA/is jETSr5LVCOmEMARJUl0Okiur7nvVDevjGk9zGnvNa0ONUMXipuGIX4qBHwZQXHqipC56 V2ktohl5ol7gTBNnCoYu/UlrvpLeB0Pi+fwM8NlSiL7/ACCMxrzZ3aUbd95FthVbHOmL eASa/Je1/4UmBalRpoyup+hcggV9Grk02DvA/X7d/nVrF/vDlA7LPxHVQaT2z3A328ha mBvHmgigr6yF0Yc0bOA2RbX2ZhIlkGGxFQ9sGnDkA4YZupMVov+KnjVSFcV7HJIngbZ6 EU8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785904432; x=1786509232; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=L+VSIt/dK4uaFU6UoLSPrTrRpY150XN2pn30jvRWAek=; b=L19ljgkydLeVSQe9Z3S9p9eFmGXEww9ZqPO+sPmUTZyVUvr8Ovrfdq3jnz3m610CRs g2x++uK/pbBu8USCy8fLHN5z3/QUJfS7I2AMCr7GYHuWhc07eGJSO7mHuL5i04Xmq+b0 C8KL6CMXDT/X+mbq4aaHPb+8xq/0gVrtLmLM+cY1p5o4dvRGmq3yOIlcWnIoWdOfTZLm DNHDOThLqShJMvaUho0eCv8/Qw18uFK08xODCZUMzqVD0/E/tNbsT3Frv5+iWyXUN4Dz XvFE9jwL9mZjMIgzD/NdIH+tG598/Gp5+2O4KDpq4cL5GyXjJqm+Hn/1QZf3zESUio+p GboQ== X-Forwarded-Encrypted: i=1; AHgh+RqVVyXlDT3I/4pbC0nq0b9swwZHf+NxTzGU1FULPZ35KGEusPSor9+PhrR7YtdHxHP9yRGfMLzWphom9G8=@vger.kernel.org X-Gm-Message-State: AOJu0YyjPtvVR+hBBKMq3koquliw1xGQSC8u0ZqYaM5TP9FxeDkEEEwY n9Q/m385l9rLVipd8bBVoMCGsaBfRGpbsZt3f3cgGeaIIZiKjiV7GkJh X-Gm-Gg: AR+sD11/Ib0SyAEc3vyaJ1YfHm7U1Ph8yNm/lW8oI+bikZYi23R7w8txwSCpgkjQHPL 4z8UFU01lEf/fRfY/bwZ5t0XKnipOmgtzwOe2Vezwky/x329l53fTh4j9brkavq9GkwZv97ICZ2 /9OTK23adYqeqgFXHFdHioSB/7WqB0EMFW1HXSk0NMrnb0K1r1qM73zlpUq6p0NTENND08w8ulc y9t0GY1SK+W+qfuChA1iZdGC7LLAfZCOBr7i4xq7f1Cn6uME16L66dWmoF0HzKBOViyOq2IcxAY EsXilKIYSk9ySR6a3/nc9oVnQRAEijYXQ5SGMmlBssc4IcRAaM8ONR6VHJQEM11j+duZJpb8oLc 0lvPbnsgeYLDuGBxexY5mWjGgUJ2UFz87uhdcV9jEXFR+yqK+nPVy0/wC4KZRwLQIGySLXY5f/v j54FUs68sWVerIMzColORxS4+Z9Ytf4fjXwSfvyM/CBIU7hLfCoAn8OIWBaUHsBPUEn8YG4fWAx odwfaYCSq7BddgUWuRDaMNj5p7kUw== X-Received: by 2002:a05:6a20:d52a:b0:3b4:5ff3:45cb with SMTP id adf61e73a8af0-3cb85df276cmr4903580637.8.1785904431560; Tue, 04 Aug 2026 21:33:51 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:bf3a:ac93:79c4:84fd]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3158673be99sm19559233eec.15.2026.08.04.21.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 21:33:50 -0700 (PDT) Date: Tue, 4 Aug 2026 21:33:48 -0700 From: Dmitry Torokhov To: Myeonghun Pak Cc: Linus Walleij , Samuel Ortiz , Rabin Vincent , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Input: stmpe-keypad - disable keypad on probe failure Message-ID: References: <20260804141525.39388-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260804141525.39388-1-mhun512@gmail.com> Hi Myeonghun, On Tue, Aug 04, 2026 at 11:15:25PM +0900, Myeonghun Pak wrote: > stmpe_keypad_chip_init() enables the keypad block before programming > its registers. If any subsequent register access fails, the function > returns without disabling the block. The later IRQ request and input > device registration failures have the same problem. What exactly is the problem with leaving keyboard block enabled? Thanks. -- Dmitry